[Bouffalolab] Disable strict_warnings for pigweed enabled and fix to …

…get Wi-Fi BSSID (#26099) * disable strict warnings compile options for pigweed enabled and fix to get wifi bssid * Fix restyle
project-chip · Apr 14, 2023 · 3b46d4a · 3b46d4a
1 parent 666f6f3
commit 3b46d4a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/examples/lighting-app/bouffalolab/bl602/with_pw_rpc.gni b/examples/lighting-app/bouffalolab/bl602/with_pw_rpc.gni
@@ -24,4 +24,9 @@ chip_enable_pw_rpc = true
 chip_build_pw_trace_lib = false
 
 cpp_standard = "gnu++17"
-#pw_trace_BACKEND = "$dir_pw_trace_tokenized"
+
+# pigweed updated to a1bd248 makes compile conversion errors;
+# it seems riscv gcc (version > 10) can fixes this issue.
+# let's disable strict warnings for RPC enabled for now.
+remove_default_configs = [ "$dir_pw_build:strict_warnings" ]
+treat_warnings_as_errors = false
diff --git a/examples/lighting-app/bouffalolab/bl702/with_pw_rpc.gni b/examples/lighting-app/bouffalolab/bl702/with_pw_rpc.gni
@@ -24,4 +24,9 @@ chip_enable_pw_rpc = true
 chip_build_pw_trace_lib = false
 
 cpp_standard = "gnu++17"
-#pw_trace_BACKEND = "$dir_pw_trace_tokenized"
+
+# pigweed updated to a1bd248 makes compile conversion errors;
+# it seems riscv gcc (version > 10) can fixes this issue.
+# let's disable strict warnings for RPC enabled for now.
+remove_default_configs = [ "$dir_pw_build:strict_warnings" ]
+treat_warnings_as_errors = false
diff --git a/src/platform/bouffalolab/BL602/DiagnosticDataProviderImpl.cpp b/src/platform/bouffalolab/BL602/DiagnosticDataProviderImpl.cpp
@@ -221,9 +221,7 @@ DiagnosticDataProvider & GetDiagnosticDataProviderImpl()
 
 CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBssId(MutableByteSpan & BssId)
 {
- static uint8_t macAddress[kMaxHardwareAddrSize];
-
- memcpy(macAddress, wifiMgmr.wifi_mgmr_stat_info.bssid, kMaxHardwareAddrSize);
+ BssId = ByteSpan(wifiMgmr.wifi_mgmr_stat_info.bssid, sizeof(wifiMgmr.wifi_mgmr_stat_info.bssid));
 
  // TODO: This does not actually put the data in the out param.
  return CHIP_ERROR_READ_FAILED;