Skip to content

Commit

Permalink
Align naming in Thread Network Diagnostics cluster XML with the spec. (
Browse files Browse the repository at this point in the history
…#24290)

* Align naming in Thread Network Diagnostics cluster XML with the spec.

* Auto-update ZAP files.

* Regenerate generated code.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Mar 30, 2023
1 parent 15a24c7 commit 4499740
Show file tree
Hide file tree
Showing 105 changed files with 864 additions and 835 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1245,6 +1245,11 @@ server cluster SoftwareDiagnostics = 52 {
}

server cluster ThreadNetworkDiagnostics = 53 {
enum ConnectionStatusEnum : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

enum NetworkFault : ENUM8 {
kUnspecified = 0;
kLinkDown = 1;
Expand All @@ -1262,11 +1267,6 @@ server cluster ThreadNetworkDiagnostics = 53 {
kLeader = 6;
}

enum ThreadConnectionStatus : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

bitmap ThreadNetworkDiagnosticsFeature : BITMAP32 {
kPacketCounts = 0x1;
kErrorCounts = 0x2;
Expand Down Expand Up @@ -1306,7 +1306,7 @@ server cluster ThreadNetworkDiagnostics = 53 {

struct SecurityPolicy {
int16u rotationTime = 0;
bitmap16 flags = 1;
int16u flags = 1;
}

struct OperationalDatasetComponents {
Expand All @@ -1325,7 +1325,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
}

info event ConnectionStatus = 0 {
ThreadConnectionStatus connectionStatus = 0;
ConnectionStatusEnum connectionStatus = 0;
}

info event NetworkFaultChange = 1 {
Expand All @@ -1340,8 +1340,8 @@ server cluster ThreadNetworkDiagnostics = 53 {
readonly attribute nullable int64u extendedPanId = 4;
readonly attribute nullable octet_string<17> meshLocalPrefix = 5;
readonly attribute int64u overrunCount = 6;
readonly attribute NeighborTable neighborTableList[] = 7;
readonly attribute RouteTable routeTableList[] = 8;
readonly attribute NeighborTable neighborTable[] = 7;
readonly attribute RouteTable routeTable[] = 8;
readonly attribute nullable int32u partitionId = 9;
readonly attribute nullable int8u weighting = 10;
readonly attribute nullable int8u dataVersion = 11;
Expand Down Expand Up @@ -4073,8 +4073,8 @@ endpoint 0 {
callback attribute extendedPanId;
callback attribute meshLocalPrefix;
callback attribute overrunCount;
callback attribute neighborTableList;
callback attribute routeTableList;
callback attribute neighborTable;
callback attribute routeTable;
callback attribute partitionId;
callback attribute weighting;
callback attribute dataVersion;
Expand Down
20 changes: 10 additions & 10 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@
}
],
"package": [
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/zcl/zcl-with-test-extensions.json",
"type": "zcl-properties",
"category": "matter",
"version": 1,
"description": "Matter SDK ZCL data with some extensions"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
}
],
"endpointTypes": [
Expand Down Expand Up @@ -3745,7 +3745,7 @@
"enabled": 1,
"attributes": [
{
"name": "channel",
"name": "Channel",
"code": 0,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3857,7 +3857,7 @@
"reportableChange": 0
},
{
"name": "NeighborTableList",
"name": "NeighborTable",
"code": 7,
"mfgCode": null,
"side": "server",
Expand All @@ -3873,7 +3873,7 @@
"reportableChange": 0
},
{
"name": "RouteTableList",
"name": "RouteTable",
"code": 8,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3905,7 +3905,7 @@
"reportableChange": 0
},
{
"name": "weighting",
"name": "Weighting",
"code": 10,
"mfgCode": null,
"side": "server",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,11 @@ server cluster SoftwareDiagnostics = 52 {
}

server cluster ThreadNetworkDiagnostics = 53 {
enum ConnectionStatusEnum : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

enum NetworkFault : ENUM8 {
kUnspecified = 0;
kLinkDown = 1;
Expand All @@ -1171,11 +1176,6 @@ server cluster ThreadNetworkDiagnostics = 53 {
kLeader = 6;
}

enum ThreadConnectionStatus : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

bitmap ThreadNetworkDiagnosticsFeature : BITMAP32 {
kPacketCounts = 0x1;
kErrorCounts = 0x2;
Expand Down Expand Up @@ -1215,7 +1215,7 @@ server cluster ThreadNetworkDiagnostics = 53 {

struct SecurityPolicy {
int16u rotationTime = 0;
bitmap16 flags = 1;
int16u flags = 1;
}

struct OperationalDatasetComponents {
Expand All @@ -1234,7 +1234,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
}

info event ConnectionStatus = 0 {
ThreadConnectionStatus connectionStatus = 0;
ConnectionStatusEnum connectionStatus = 0;
}

info event NetworkFaultChange = 1 {
Expand All @@ -1248,8 +1248,8 @@ server cluster ThreadNetworkDiagnostics = 53 {
readonly attribute nullable int16u panId = 3;
readonly attribute nullable int64u extendedPanId = 4;
readonly attribute nullable octet_string<17> meshLocalPrefix = 5;
readonly attribute NeighborTable neighborTableList[] = 7;
readonly attribute RouteTable routeTableList[] = 8;
readonly attribute NeighborTable neighborTable[] = 7;
readonly attribute RouteTable routeTable[] = 8;
readonly attribute nullable int32u partitionId = 9;
readonly attribute nullable int8u weighting = 10;
readonly attribute nullable int8u dataVersion = 11;
Expand Down Expand Up @@ -3437,8 +3437,8 @@ endpoint 0 {
callback attribute panId;
callback attribute extendedPanId;
callback attribute meshLocalPrefix;
callback attribute neighborTableList;
callback attribute routeTableList;
callback attribute neighborTable;
callback attribute routeTable;
callback attribute partitionId;
callback attribute weighting;
callback attribute dataVersion;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3745,7 +3745,7 @@
"enabled": 1,
"attributes": [
{
"name": "channel",
"name": "Channel",
"code": 0,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3857,7 +3857,7 @@
"reportableChange": 0
},
{
"name": "NeighborTableList",
"name": "NeighborTable",
"code": 7,
"mfgCode": null,
"side": "server",
Expand All @@ -3873,7 +3873,7 @@
"reportableChange": 0
},
{
"name": "RouteTableList",
"name": "RouteTable",
"code": 8,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3905,7 +3905,7 @@
"reportableChange": 0
},
{
"name": "weighting",
"name": "Weighting",
"code": 10,
"mfgCode": null,
"side": "server",
Expand Down
22 changes: 11 additions & 11 deletions examples/bridge-app/bridge-common/bridge-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,11 @@ server cluster SoftwareDiagnostics = 52 {
}

server cluster ThreadNetworkDiagnostics = 53 {
enum ConnectionStatusEnum : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

enum NetworkFault : ENUM8 {
kUnspecified = 0;
kLinkDown = 1;
Expand All @@ -938,11 +943,6 @@ server cluster ThreadNetworkDiagnostics = 53 {
kLeader = 6;
}

enum ThreadConnectionStatus : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

bitmap ThreadNetworkDiagnosticsFeature : BITMAP32 {
kPacketCounts = 0x1;
kErrorCounts = 0x2;
Expand Down Expand Up @@ -982,7 +982,7 @@ server cluster ThreadNetworkDiagnostics = 53 {

struct SecurityPolicy {
int16u rotationTime = 0;
bitmap16 flags = 1;
int16u flags = 1;
}

struct OperationalDatasetComponents {
Expand All @@ -1001,7 +1001,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
}

info event ConnectionStatus = 0 {
ThreadConnectionStatus connectionStatus = 0;
ConnectionStatusEnum connectionStatus = 0;
}

info event NetworkFaultChange = 1 {
Expand All @@ -1016,8 +1016,8 @@ server cluster ThreadNetworkDiagnostics = 53 {
readonly attribute nullable int64u extendedPanId = 4;
readonly attribute nullable octet_string<17> meshLocalPrefix = 5;
readonly attribute int64u overrunCount = 6;
readonly attribute NeighborTable neighborTableList[] = 7;
readonly attribute RouteTable routeTableList[] = 8;
readonly attribute NeighborTable neighborTable[] = 7;
readonly attribute RouteTable routeTable[] = 8;
readonly attribute nullable int32u partitionId = 9;
readonly attribute nullable int8u weighting = 10;
readonly attribute nullable int8u dataVersion = 11;
Expand Down Expand Up @@ -1607,8 +1607,8 @@ endpoint 0 {
callback attribute extendedPanId;
callback attribute meshLocalPrefix;
callback attribute overrunCount;
callback attribute neighborTableList;
callback attribute routeTableList;
callback attribute neighborTable;
callback attribute routeTable;
callback attribute partitionId;
callback attribute weighting;
callback attribute dataVersion;
Expand Down
8 changes: 4 additions & 4 deletions examples/bridge-app/bridge-common/bridge-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -2489,7 +2489,7 @@
"enabled": 1,
"attributes": [
{
"name": "channel",
"name": "Channel",
"code": 0,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -2601,7 +2601,7 @@
"reportableChange": 0
},
{
"name": "NeighborTableList",
"name": "NeighborTable",
"code": 7,
"mfgCode": null,
"side": "server",
Expand All @@ -2617,7 +2617,7 @@
"reportableChange": 0
},
{
"name": "RouteTableList",
"name": "RouteTable",
"code": 8,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -2649,7 +2649,7 @@
"reportableChange": 0
},
{
"name": "weighting",
"name": "Weighting",
"code": 10,
"mfgCode": null,
"side": "server",
Expand Down
22 changes: 11 additions & 11 deletions examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,11 @@ server cluster SoftwareDiagnostics = 52 {
}

server cluster ThreadNetworkDiagnostics = 53 {
enum ConnectionStatusEnum : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

enum NetworkFault : ENUM8 {
kUnspecified = 0;
kLinkDown = 1;
Expand All @@ -792,11 +797,6 @@ server cluster ThreadNetworkDiagnostics = 53 {
kLeader = 6;
}

enum ThreadConnectionStatus : ENUM8 {
kConnected = 0;
kNotConnected = 1;
}

bitmap ThreadNetworkDiagnosticsFeature : BITMAP32 {
kPacketCounts = 0x1;
kErrorCounts = 0x2;
Expand Down Expand Up @@ -836,7 +836,7 @@ server cluster ThreadNetworkDiagnostics = 53 {

struct SecurityPolicy {
int16u rotationTime = 0;
bitmap16 flags = 1;
int16u flags = 1;
}

struct OperationalDatasetComponents {
Expand All @@ -855,7 +855,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
}

info event ConnectionStatus = 0 {
ThreadConnectionStatus connectionStatus = 0;
ConnectionStatusEnum connectionStatus = 0;
}

info event NetworkFaultChange = 1 {
Expand All @@ -870,8 +870,8 @@ server cluster ThreadNetworkDiagnostics = 53 {
readonly attribute nullable int64u extendedPanId = 4;
readonly attribute nullable octet_string<17> meshLocalPrefix = 5;
readonly attribute int64u overrunCount = 6;
readonly attribute NeighborTable neighborTableList[] = 7;
readonly attribute RouteTable routeTableList[] = 8;
readonly attribute NeighborTable neighborTable[] = 7;
readonly attribute RouteTable routeTable[] = 8;
readonly attribute nullable int32u partitionId = 9;
readonly attribute nullable int8u weighting = 10;
readonly attribute nullable int8u dataVersion = 11;
Expand Down Expand Up @@ -1416,8 +1416,8 @@ endpoint 0 {
callback attribute extendedPanId;
callback attribute meshLocalPrefix;
callback attribute overrunCount;
callback attribute neighborTableList;
callback attribute routeTableList;
callback attribute neighborTable;
callback attribute routeTable;
callback attribute partitionId;
callback attribute weighting;
callback attribute dataVersion;
Expand Down
Loading

0 comments on commit 4499740

Please sign in to comment.