Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
mrjerryjohns and bzbarsky-apple authored Jun 11, 2021
1 parent 203ffc8 commit 9cfc555
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/chip-tool/commands/pairing/PairingCommand.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ CHIP_ERROR PairingCommand::RunInternal(NodeId remoteId)

//
// We're about to call methods into the stack, so lock
// appropriately. None of the following calls below before the unlock are, nor should be
// appropriately. None of the following calls below before the unlock are, nor should be,
// blocking.
//
{
Expand Down
3 changes: 2 additions & 1 deletion src/controller/CHIPDeviceController.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ class DLL_EXPORT DeviceController : public Messaging::ExchangeDelegate,
* This expects to be called with external thread synchronization, and will not internally
* grab the CHIP stack lock.
*
* This will also not stop the CHIP event queue / thread (if one exists).
* This will also not stop the CHIP event queue / thread (if one exists). Consumers are expected to
* ensure this happend before calling this method.
*/
virtual CHIP_ERROR Shutdown();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ void GenericPlatformManagerImpl_POSIX<ImplClass>::_RunEventLoop()
//
// If we haven't set mHasValidChipTask by now, it means that the application did not call StartEventLoopTask
// and consequently, are running the event loop from their own, externally managed task.
// Let's trackt his appropriately since we need this info later when stopping the event queues.
// Let's track his appropriately since we need this info later when stopping the event queues.
//
if (!mHasValidChipTask)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class GenericPlatformManagerImpl_POSIX : public GenericPlatformManagerImpl<ImplC

//
// TODO: This variable is very similar to mMainLoopIsStarted, track the
// cleanup and consolidated in this issue:
// cleanup and consolidation in this issue:
//
bool mEventQueueHasStopped = false;

Expand Down

0 comments on commit 9cfc555

Please sign in to comment.