[chip-tool] Do not call ErrorStr after RunCommand in interactive mode…

… as ErrorStr use a single static buffer to compute the error string and in interactive mode the stack continue to do some work and it may race

examples/chip-tool/commands/common/CHIPCommand.h

@@ -94,6 +94,14 @@ class CHIPCommand : public Command
  void SetCommandExitStatus(CHIP_ERROR status)
  {
  mCommandExitStatus = status;
+ // In interactive mode the stack is not shut down once a command is ended.
+ // That means calling `ErrorStr(err)` from the main thread when command
+ // completion is signaled may race since `ErrorStr` uses a static sErrorStr
+ // buffer for computing the error string. Call it here instead.
+ if (IsInteractive() && CHIP_NO_ERROR != status)
+ {
+ ChipLogError(chipTool, "Run command failure: %s", chip::ErrorStr(status));
+ }
  StopWaiting();
  }
 

examples/chip-tool/commands/common/Commands.cpp

@@ -181,9 +181,7 @@ int Commands::RunInteractive(const char * command)
  delete[] argv[i];
  }
 
- VerifyOrReturnValue(CHIP_NO_ERROR == err, EXIT_FAILURE, ChipLogError(chipTool, "Run command failure: %s", chip::ErrorStr(err)));
-
- return EXIT_SUCCESS;
+ return (err == CHIP_NO_ERROR) ? EXIT_SUCCESS : EXIT_FAILURE;
 }
 
 CHIP_ERROR Commands::RunCommand(int argc, char ** argv, bool interactive)