cleaner fix for shell

project-chip · Feb 4, 2022 · a9e1577 · a9e1577
1 parent 4ef244c
commit a9e1577
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/examples/shell/efr32/BUILD.gn b/examples/shell/efr32/BUILD.gn
@@ -49,10 +49,6 @@ efr32_sdk("sdk") {
  defines = [
  "BOARD_ID=${efr32_board}",
  "OPENTHREAD_CONFIG_CLI_TRANSPORT=OT_CLI_TRANSPORT_CONSOLE",
- "ENABLE_CHIP_SHELL",
-
- # shell app use openthread but do not have the NETWORK_COMMISSIONING cluster or zap config.
- "_NO_NETWORK_COMMISSIONING_DRIVER_",
  ]
 }
 

diff --git a/examples/shell/efr32/args.gni b/examples/shell/efr32/args.gni
@@ -22,3 +22,4 @@ pw_log_BACKEND = "${chip_root}/src/lib/support/pw_log_chip"
 pw_assert_BACKEND = "$dir_pw_assert_log"
 chip_enable_openthread = true
 chip_openthread_ftd = true
+chip_build_libshell = true
diff --git a/examples/shell/efr32/include/CHIPProjectConfig.h b/examples/shell/efr32/include/CHIPProjectConfig.h
@@ -113,3 +113,5 @@
  * A size, in bytes, of the individual debug event logging buffer.
  */
 #define CHIP_DEVICE_CONFIG_EVENT_LOGGING_DEBUG_BUFFER_SIZE (512)
+
+#define _NO_NETWORK_COMMISSIONING_DRIVER_
diff --git a/examples/shell/mbed/CMakeLists.txt b/examples/shell/mbed/CMakeLists.txt
@@ -21,8 +21,6 @@ include(${MBED_PATH}/tools/cmake/app.cmake)
 
 project(${APP_TARGET})
 
-# shell app use openthread but do not have the NETWORK_COMMISSIONING cluster or zap config
-add_definitions(-D_NO_NETWORK_COMMISSIONING_DRIVER_)
 
 add_subdirectory(${MBED_PATH} ./mbed_build)
 add_subdirectory(${MBED_OS_POSIX_SOCKET_PATH} ./mbed_os_posix_socket_build)

diff --git a/examples/shell/mbed/main/include/CHIPProjectConfig.h b/examples/shell/mbed/main/include/CHIPProjectConfig.h
@@ -33,3 +33,7 @@
 // Use a default pairing code if one hasn't been provisioned in flash.
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE 20202021
 #define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xF00
+
+// shell app use openthread but do not have the NETWORK_COMMISSIONING cluster or zap config
+// Do not instanciate the NETWORK_COMMISSIONING thread driver
+#define _NO_NETWORK_COMMISSIONING_DRIVER_
diff --git a/examples/shell/nrfconnect/CHIPProjectConfig.h b/examples/shell/nrfconnect/CHIPProjectConfig.h
@@ -42,3 +42,7 @@
  * 0x4E53: nrfconnect shell
  */
 #define CHIP_DEVICE_CONFIG_DEVICE_PRODUCT_ID 0x4E53
+
+// shell app use openthread but do not have the NETWORK_COMMISSIONING cluster or zap config
+// Do not instanciate the NETWORK_COMMISSIONING thread driver
+#define _NO_NETWORK_COMMISSIONING_DRIVER_
diff --git a/examples/shell/nrfconnect/CMakeLists.txt b/examples/shell/nrfconnect/CMakeLists.txt
@@ -31,9 +31,6 @@ endif()
 
 project(chip-nrfconnect-shell-example)
 
-# shell app use openthread but do not have the NETWORK_COMMISSIONING cluster or zap config
-add_definitions(-D_NO_NETWORK_COMMISSIONING_DRIVER_)
-
 include(${CHIP_ROOT}/config/nrfconnect/app/enable-gnu-std.cmake)
 
 target_compile_options(app PRIVATE -Werror)

diff --git a/src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp b/src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp
@@ -24,8 +24,6 @@
 #include <platform/ThreadStackManager.h>
 
 #include <limits>
-#include <string>
-#include <vector>
 
 using namespace chip;
 using namespace chip::Thread;