Remove log only delegate bridge from darwin chip controller (#15737)

* Stop processing Address change notifications within darwin chip device controller * Restyle
project-chip · Aug 2, 2023 · bc1f785 · bc1f785
1 parent 0ad3af7
commit bc1f785
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/src/darwin/Framework/CHIP/CHIPDeviceController.mm b/src/darwin/Framework/CHIP/CHIPDeviceController.mm
@@ -198,7 +198,7 @@ - (BOOL)startup:(_Nullable id<CHIPPersistentStorageDelegate>)storageDelegate
  params.fabricStorage = _fabricStorage;
  params.fabricIndependentStorage = _persistentStorageDelegateBridge;
  commissionerParams.storageDelegate = _persistentStorageDelegateBridge;
- commissionerParams.deviceAddressUpdateDelegate = _pairingDelegateBridge;
+ commissionerParams.deviceAddressUpdateDelegate = nullptr;
  commissionerParams.pairingDelegate = _pairingDelegateBridge;
 
  commissionerParams.operationalCredentialsDelegate = _operationalCredentialsDelegate;

diff --git a/src/darwin/Framework/CHIP/CHIPDevicePairingDelegateBridge.h b/src/darwin/Framework/CHIP/CHIPDevicePairingDelegateBridge.h
@@ -23,8 +23,7 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-class CHIPDevicePairingDelegateBridge : public chip::Controller::DevicePairingDelegate,
- public chip::Controller::DeviceAddressUpdateDelegate
+class CHIPDevicePairingDelegateBridge : public chip::Controller::DevicePairingDelegate
 {
 public:
  CHIPDevicePairingDelegateBridge();
@@ -40,8 +39,6 @@ class CHIPDevicePairingDelegateBridge : public chip::Controller::DevicePairingDe
 
  void OnCommissioningComplete(chip::NodeId deviceId, CHIP_ERROR error) override;
 
- void OnAddressUpdateComplete(chip::NodeId nodeId, CHIP_ERROR error) override;
-
 private:
  id<CHIPDevicePairingDelegate> mDelegate;
  dispatch_queue_t mQueue;

diff --git a/src/darwin/Framework/CHIP/CHIPDevicePairingDelegateBridge.mm b/src/darwin/Framework/CHIP/CHIPDevicePairingDelegateBridge.mm
@@ -109,9 +109,3 @@
  }
  }
 }
-
-void CHIPDevicePairingDelegateBridge::OnAddressUpdateComplete(chip::NodeId nodeId, CHIP_ERROR error)
-{
- // Todo, is there any benefit of exposing this anymore?
- NSLog(@"OnAddressUpdateComplete. Status %s", chip::ErrorStr(error));
-}