Design AccessControlProvider interface #10249
Labels
acl
Access Control feature
Comments
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this issue
Oct 15, 2021
- Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues project-chip#10236 and project-chip#10249 - Fully isolated as a module - Has unit tests
woody-apple
pushed a commit
to mlepage-google/connectedhomeip
that referenced
this issue
Oct 27, 2021
- Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues project-chip#10236 and project-chip#10249 - Fully isolated as a module - Has unit tests
andy31415
pushed a commit
that referenced
this issue
Oct 27, 2021
* Add initial prototype of AccessControl module - Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues #10236 and #10249 - Fully isolated as a module - Has unit tests * Remove file comments from files * Add 'k' prefix to enum values * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Remove "empty" .cpp files * Apply suggestions from code review * Apply suggestions from code review * Fix compatibility under different compilers * Fix unit test compatability on different compilers * Restyled by clang-format * Change forward declaration to include Allows tooling to detect circular dependencies. * Changes from code review suggestions - rename namespace access --> Access - rename DataProvider --> AccessControlDataProvider - decouple DataProvider lifecycle (Init/Finish) - rename DataProviderImpl --> ExampleAccessControlDataProvider - change GetInstance/SetInstance to global functions - remove Config.h since global instance must be set - change EntryIterator::Next to return pointer - add comments to Privilege and AuthMode - remove SubjectDescriptor.isCommissioning for now - improve naming of CAT subjects in SubjectDescriptor - change SubjectId typedef to use NodeId * Make tests table-driven Should also fix some build complaints on ESP32 * Restyled by clang-format * Restyle * Add more metatesting Ensure not just that results are correct, but that they were correctly obtained. * Restyled by clang-format * Change enums to enum classes * Address review comments * Use basic types in lib/core Basic types (FabricIndex etc.) were moved in PR #10925 from app to lib/core, so now they can be used from this module. * A bit of cleanup * Refactor SubjectId and SubjectDescriptor Also, remove CatId and move PasscodeId into lib/core. * Restyled by clang-format * Add clarifying examples to documentation. Co-authored-by: Restyled.io <commits@restyled.io>
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this issue
Oct 28, 2021
* Add initial prototype of AccessControl module - Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues project-chip#10236 and project-chip#10249 - Fully isolated as a module - Has unit tests * Remove file comments from files * Add 'k' prefix to enum values * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Remove "empty" .cpp files * Apply suggestions from code review * Apply suggestions from code review * Fix compatibility under different compilers * Fix unit test compatability on different compilers * Restyled by clang-format * Change forward declaration to include Allows tooling to detect circular dependencies. * Changes from code review suggestions - rename namespace access --> Access - rename DataProvider --> AccessControlDataProvider - decouple DataProvider lifecycle (Init/Finish) - rename DataProviderImpl --> ExampleAccessControlDataProvider - change GetInstance/SetInstance to global functions - remove Config.h since global instance must be set - change EntryIterator::Next to return pointer - add comments to Privilege and AuthMode - remove SubjectDescriptor.isCommissioning for now - improve naming of CAT subjects in SubjectDescriptor - change SubjectId typedef to use NodeId * Make tests table-driven Should also fix some build complaints on ESP32 * Restyled by clang-format * Restyle * Add more metatesting Ensure not just that results are correct, but that they were correctly obtained. * Restyled by clang-format * Change enums to enum classes * Address review comments * Use basic types in lib/core Basic types (FabricIndex etc.) were moved in PR project-chip#10925 from app to lib/core, so now they can be used from this module. * A bit of cleanup * Refactor SubjectId and SubjectDescriptor Also, remove CatId and move PasscodeId into lib/core. * Restyled by clang-format * Add clarifying examples to documentation. Co-authored-by: Restyled.io <commits@restyled.io>
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this issue
Oct 28, 2021
* Add initial prototype of AccessControl module - Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues project-chip#10236 and project-chip#10249 - Fully isolated as a module - Has unit tests * Remove file comments from files * Add 'k' prefix to enum values * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Remove "empty" .cpp files * Apply suggestions from code review * Apply suggestions from code review * Fix compatibility under different compilers * Fix unit test compatability on different compilers * Restyled by clang-format * Change forward declaration to include Allows tooling to detect circular dependencies. * Changes from code review suggestions - rename namespace access --> Access - rename DataProvider --> AccessControlDataProvider - decouple DataProvider lifecycle (Init/Finish) - rename DataProviderImpl --> ExampleAccessControlDataProvider - change GetInstance/SetInstance to global functions - remove Config.h since global instance must be set - change EntryIterator::Next to return pointer - add comments to Privilege and AuthMode - remove SubjectDescriptor.isCommissioning for now - improve naming of CAT subjects in SubjectDescriptor - change SubjectId typedef to use NodeId * Make tests table-driven Should also fix some build complaints on ESP32 * Restyled by clang-format * Restyle * Add more metatesting Ensure not just that results are correct, but that they were correctly obtained. * Restyled by clang-format * Change enums to enum classes * Address review comments * Use basic types in lib/core Basic types (FabricIndex etc.) were moved in PR project-chip#10925 from app to lib/core, so now they can be used from this module. * A bit of cleanup * Refactor SubjectId and SubjectDescriptor Also, remove CatId and move PasscodeId into lib/core. * Restyled by clang-format * Add clarifying examples to documentation. Co-authored-by: Restyled.io <commits@restyled.io>
|
Spent a few days on this, progressing well, PR coming soon. |
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this issue
Nov 8, 2021
New interface (issue project-chip#10249) and new implementation (issue project-chip#10250). Implementation is all in-memory and uses only static storage and stack (no heap). Some details missing (e.g. CAT support) but most is here, though not yet hooked up to other code. Comes with unit tests.
andy31415
pushed a commit
that referenced
this issue
Nov 16, 2021
* Add full implementation of access control New interface (issue #10249) and new implementation (issue #10250). Implementation is all in-memory and uses only static storage and stack (no heap). Some details missing (e.g. CAT support) but most is here, though not yet hooked up to other code. Comes with unit tests. * Fix configuration Was added at last minute, missed this spot. * Address code review comments - rewrite portions of the check loop to use boolean instead of goto - refactor privilege checking to make it clearer - ensure storage classes are POD types (with static_assert) - remove memsets on storage classes (for now, can re-add later) - clarify some comments - remove debug log statement * Restyled by clang-format * Address code review comments Also fix some compiler warnings/errors on other builds * Add tests for fabric filtered indexing Refactor the index conversion (to/from fabric filtered) to be clearer. * Restyled by clang-format * Address code review comments - change Target::Flags from int to unsigned - use unsigned in static_asserts for flags - tweak auto variables * Add docs and comments - Add API documentation (mainly to clarify in/out parameters). - Add implementation comments (where warranted). - Add more unit tests (mainly for removing subjects/targets). - A few fixes to get aforementioned tests passing. - A bit of refactoring/renaming to clarify the code. * Restyled by whitespace * Restyled by clang-format * Some code review suggestions * Restyled by clang-format * Fix errors on other compilers * Fix more build errors on other compilers * More code review suggestions * Restyled by clang-format * Fix typo in config flag Co-authored-by: Restyled.io <commits@restyled.io>
|
Interface is added in PR #11550. |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this issue
Dec 3, 2021
* Add initial prototype of AccessControl module - Not complete, always allows actions - Not hooked up to interaction model or messaging layer - Progress toward issues project-chip#10236 and project-chip#10249 - Fully isolated as a module - Has unit tests * Remove file comments from files * Add 'k' prefix to enum values * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Remove "empty" .cpp files * Apply suggestions from code review * Apply suggestions from code review * Fix compatibility under different compilers * Fix unit test compatability on different compilers * Restyled by clang-format * Change forward declaration to include Allows tooling to detect circular dependencies. * Changes from code review suggestions - rename namespace access --> Access - rename DataProvider --> AccessControlDataProvider - decouple DataProvider lifecycle (Init/Finish) - rename DataProviderImpl --> ExampleAccessControlDataProvider - change GetInstance/SetInstance to global functions - remove Config.h since global instance must be set - change EntryIterator::Next to return pointer - add comments to Privilege and AuthMode - remove SubjectDescriptor.isCommissioning for now - improve naming of CAT subjects in SubjectDescriptor - change SubjectId typedef to use NodeId * Make tests table-driven Should also fix some build complaints on ESP32 * Restyled by clang-format * Restyle * Add more metatesting Ensure not just that results are correct, but that they were correctly obtained. * Restyled by clang-format * Change enums to enum classes * Address review comments * Use basic types in lib/core Basic types (FabricIndex etc.) were moved in PR project-chip#10925 from app to lib/core, so now they can be used from this module. * A bit of cleanup * Refactor SubjectId and SubjectDescriptor Also, remove CatId and move PasscodeId into lib/core. * Restyled by clang-format * Add clarifying examples to documentation. Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: