[TC-DRLK-2.8] Door-lock Set User Command is returning success instead of INVALID_COMMAND #19563
Comments
bzbarsky-apple
added
spec
|
@Morozov-5F do you have time to take a look at this one? Or any pointers to anyone else working on door locks? |
|
@Ashwinigrl - for future bug reports, please attach logs instead of pasting (paste only small excerpts that are human reviewed for relevance). https://github.com/project-chip/connectedhomeip/blob/master/docs/BUG_REPORT.md |
|
The actual command would also be useful for fast reproduction. the command you used for |
It's at the top of the first log: That "10" is out of range of the enum. |
|
@bzbarsky-apple 10 is out of range. We expected a failure but seeing success. |
|
It is really interesting. The |
|
Spec Issue Review: Assigning to @Morozov-5F |
|
Spec Issue Review: Tagging cert blocker. |
|
@Morozov-5F Yes, the underlying code does not yet know to do range checks on enums.... Sorry. :( |
|
@bzbarsky-apple no problem, should be a fairly straightforward fix |
- Refactor the cluster, so it is consistent in way of handling commands
cjandhyala
changed the title
- Refactor the cluster, so it is consistent in way of handling commands
- Refactor the cluster, so it is consistent in way of handling commands
- Refactor the cluster, so it is consistent in way of handling commands
* [#19622] Return generic failure instead of not found for schedule operations in the door lock * [#19563] Check enum ranges for Door Lock commands - Refactor the cluster, so it is consistent in way of handling commands * Refactoring of the door lock cluster: move credential error checking into a single function, fix typos * Fix tests for Door Lock cluster and run them against the lock app * Update auto-generated files
* [#19622] Return generic failure instead of not found for schedule operations in the door lock * [#19563] Check enum ranges for Door Lock commands - Refactor the cluster, so it is consistent in way of handling commands * Refactoring of the door lock cluster: move credential error checking into a single function, fix typos * Fix tests for Door Lock cluster and run them against the lock app * Update auto-generated files
* [#19622] Return generic failure instead of not found for schedule operations in the door lock * [#19563] Check enum ranges for Door Lock commands - Refactor the cluster, so it is consistent in way of handling commands * Refactoring of the door lock cluster: move credential error checking into a single function, fix typos * Fix tests for Door Lock cluster and run them against the lock app * Update auto-generated files Co-authored-by: Evgeniy Morozov <morozov.evgeniy.95@gmail.com>
Problem -In Set User command, after giving invalid UserType value we are getting success response
Actual Behavior -After giving UserType value as invalid we are getting success response
Expected Behavior - After giving user type value as invalid we have to get INVALID_COMMAND
App used - lock app
Platform - Chip-tool - RPI-4, 8GB RAM
DUT - RPI-4, 8GB RAM
Network - Ble-wifi
Commit - 9493d7b
TH LOG :
DUT LOG :
The text was updated successfully, but these errors were encountered: