Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Leave event is emitted on internal deletions of fabrics #19936

Open
tcarmelveilleux opened this issue Jun 24, 2022 · 4 comments
Open
Assignees
Labels
commissioning Involves placing devices on the network, initial setup p1 priority 1 work V1.0

Comments

@tcarmelveilleux
Copy link
Contributor

Problem

The Basic Info cluster Leave event is required to be generated when a fabric is removed. It is not certain this is generated in every instance of fabric removal.

Proposed Solution

  • Audit all paths of fabric removal to ensure Leave event is generated.
@tcarmelveilleux tcarmelveilleux added V1.0 commissioning Involves placing devices on the network, initial setup labels Jun 24, 2022
@tcarmelveilleux tcarmelveilleux self-assigned this Jun 24, 2022
@Damian-Nordic
Copy link
Contributor

@tcarmelveilleux Note that after e5e09f5c00 Leave event is no longer generated because ACLs are removed first and then generating a report fails with UNSUPPORTED_ACCESS error. I onced fixed it by moving this part to operational-credentials-server.cpp to have a better control over the order of the operation (see #18434), but maybe we should do the other way around. The point is to execute all the actions in a single listener because otherwise it's very easy to break things by changing order of initialization of certain components.

@bzbarsky-apple
Copy link
Contributor

#21012 tracks the ordering issue there.

@franck-apple franck-apple added the p1 priority 1 work label Oct 24, 2022
@stale
Copy link

stale bot commented Apr 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 25, 2023
@bzbarsky-apple
Copy link
Contributor

We now generate Leave events in FabricWillBeRemoved, which is a notification from the fabric table. So any fabric removal that the fabric table knows about will generate the event.

@tcarmelveilleux Are you worried about fabric removals directly from storage, bypassing the fabric table?

@stale stale bot removed the stale Stale issue or PR label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commissioning Involves placing devices on the network, initial setup p1 priority 1 work V1.0
Projects
None yet
Development

No branches or pull requests

4 participants