[opcreds] Fix LEAVE event on RemoveFabric #18434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
mspang
pullapprove
bot
requested review from
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #18434: Size comparison from 1f1986b to 5e5b29f Increases (24 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (12 builds for cc13x2_26x2, linux)
Full report (29 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
Is it actually spec compliant to emit a bunch of traffic into a fabric after a node has already received a valid RemoveFabric command? I understand why we would want to do this. But is it permitted? |
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
mrjerryjohns
approved these changes
May 16, 2022
LuDuda
approved these changes
May 17, 2022
LEAVE event is not emitted on RemoveFabric or factory reset. There are two reasons for that: - Removing a fabric causes closing all active ReadHandlers for a given fabric, so we must flush the event log before that happens. - There are two listeners for removing a fabric; the one that removes ACLs for a given fabric index is executed prior to the other one that generates LEAVE event. That causes "Accces control: denied" error. Fix both issues.
|
PR #18434: Size comparison from f59e7e6 to 6dc4790 Increases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
May 17, 2022
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 15, 2022
…p#18434) * [opcreds] Fix LEAVE event on RemoveFabric LEAVE event is not emitted on RemoveFabric or factory reset. There are two reasons for that: - Removing a fabric causes closing all active ReadHandlers for a given fabric, so we must flush the event log before that happens. - There are two listeners for removing a fabric; the one that removes ACLs for a given fabric index is executed prior to the other one that generates LEAVE event. That causes "Accces control: denied" error. Fix both issues. * Add comment (cherry picked from commit d016401)
Damian-Nordic
added a commit
to markaj-nordic/connectedhomeip
that referenced
this pull request
Aug 5, 2022
…ject-chip#18434)" This reverts commit 5547a6e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LEAVE event is not emitted on RemoveFabric or factory reset.
There are two reasons for that:
for a given fabric, so we must flush the event log before
that happens.
that removes ACLs for a given fabric index is executed
prior to the other one that generates LEAVE event. That
causes "Acccess control: denied" error.
Change overview
Fix both issues.
Testing
Verified using nRF Connect examples that LEAVE event is delivered successfully.