chip-tool accesscontrol write acl accepts any random arguments #21892
Labels
Comments
|
This is true for all JSON parsing, not just acesscontrol. |
|
@bluebin14 So just to make sure I understand, the issue there is the |
|
@bzbarsky-apple yes I was asked to file an issue so someone can determine if it's an issue or not. It came up when incorrect fabricId was being passed which are now ignored anyway. |
|
@bluebin14 |
|
fabricIndex |
|
Ok. The fabricIndex bit is in fact allowed to be sent by the spec, so excluding it would be a bit odd. |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 24, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes project-chip#21892
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 24, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes project-chip#21892
andy31415
pushed a commit
that referenced
this issue
Feb 24, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes #21892
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes project-chip/connectedhomeip#21892
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes project-chip/connectedhomeip#21892
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this issue
Mar 22, 2023
This helps catch cases when someone mis-types the name of an optional struct field. Fixes project-chip#21892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
chip-tool accesscontrol write acl accepts any random arguments, e.g.
./chip-tool accesscontrol write acl '[{"water":123,"privilege":5,"authMode":2,"subjects":[],"targets":null}]' 12344321 0Proposed Solution
Do not accept random arguments.
The text was updated successfully, but these errors were encountered: