Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out various issues with the chip standalone server code #2302

Closed
bzbarsky-apple opened this issue Aug 24, 2020 · 4 comments
Closed

Sort out various issues with the chip standalone server code #2302

bzbarsky-apple opened this issue Aug 24, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

I was looking over #2042 and I had a few questions I could not find answers to:

  1. Why was chip-tool the right place to place the standalone server? It does not seem to share any code with the existing chip-tool command-line client...
  2. Why was various code in src/app commented out instead of making sure that the new chip server is linked with -ffunction-sections, which would have presumably fixed the link issues encountered?
  3. Where did the generated code for the new server come from? It's missing some modifications (e.g. replacing boolean with bool in the signature of halSleepCallback) that are needed to make the generated silicon labs code compile.

Proposed Solution

Sort out the above.

@erjiaqing @andy31415 @woody-apple @jelderton

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@bzbarsky-apple
Copy link
Contributor Author

@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Aug 25, 2020

Why was chip-tool the right place to place the standalone server? It does not seem to share any code with the existing chip-tool command-line client...

And in particular, I believe the medium-term plan is to include generated client code for various clusters in chip-tool (e.g. onoff client), which is not the same generated code that the standalone server wants, presumably. So at that point they will be fighting over the gen directory or we'll have two separate gen directories or something...

@franck-apple franck-apple added the bug Something isn't working label Aug 25, 2020
@franck-apple franck-apple added this to the V1.0 milestone Aug 25, 2020
@bzbarsky-apple
Copy link
Contributor Author

This code has been moved, looks like, in #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants