[cirque] Initial support for Cirque test #2042

erjiaqing · 2020-08-10T03:33:43Z

Summary of Changes

Adds a zcl server for posix mock devices.
Adds the dockerfile for integration into cirque.
Adds cirque based on-off cluster test.
Implements CHIPTestBase as a helper class.

How to test

Install and start a cirque flask server
Run do_on-off-cluster-test.sh

Note:

Cirque does not support running docker images with params, and does not support running a command in background, so we build two docker images, this should be fixed once cirque implements either running a command in background or running image with params.

fixes #1891

andy31415 · 2020-08-10T13:18:01Z

examples/chip-tool/server.cpp

+
+constexpr chip::NodeId kLocalNodeId = 12344321;
+
+#define println(format, ...) printf(format "\n", ##__VA_ARGS__)


could we just use printf and avoid the extra indirection?

Could you re-upload the branch to update? I don't seem to see updated changes.

andy31415 · 2020-08-10T13:18:55Z

examples/chip-tool/server.cpp

+class ServerCallback : public SecureSessionMgrCallback
+{
+public:
+ virtual void OnMessageReceived(const MessageHeader & header, Transport::PeerConnectionState * state,


I would suggest using 'override' instead of virtual to make it clear we override a base method

andy31415 · 2020-08-10T13:19:41Z

examples/chip-tool/server.cpp

+ }
+};
+
+static ServerCallback gCallbacks;


static not needed in anonymous namespace

andy31415 · 2020-08-10T13:32:10Z

src/test_driver/linux-cirque/helper/CHIPTestBase.py

+ fp.write(ret_log.log)
+
+
+def create_device_from_config():


could we use DEVICE_CONFIG.values() insead?

I can only see the config used as a list - should it be a list instead of a dict?

andy31415 · 2020-08-10T13:35:43Z

src/test_driver/linux-cirque/helper/CHIPTestBase.py

+
+ device_ids = set()
+
+ for device in self.device_config:


could use for device in self.device_config.values() and use **device instead of **self.device_config[device]

No longer applied since we switched to flask api

andy31415 · 2020-08-10T13:37:35Z

src/test_driver/linux-cirque/test-on-off-cluster.py

+ except:
+ traceback.print_exc(file=sys.stdout)
+ test_success = False
+ pass


pass here and below do not seem needed

Fixed by moving test warpper to base class

andy31415 · 2020-08-10T13:39:00Z

src/test_driver/linux-cirque/helper/CHIPTestBase.py

+ continue
+ self.logger.info("return ip: {}".format(ipstr))
+ return str(ipaddr)
+ except:


what exceptions can happen here?

Could you add a comment about them and why it is appropriate to silently ignore them? I am used to at least logging exceptions.

Added a comment to explain why just ignore the exception

erjiaqing · 2020-08-12T07:19:48Z

src/app/util/client-api.c

- return emberAfSendInterPan(panId, destinationLongId, destinationShortId, multicastId, emAfCommandApsFrame->clusterId, profileId,
- *emAfResponseLengthPtr, emAfZclBuffer);
-}
+// EmberStatus emberAfSendCommandUnicastToBindingsWithCallback(EmberAfMessageSentFunction callback)


These functions will not be called and will block chip-server from linking, so comment them out.

erjiaqing · 2020-08-12T07:20:04Z

src/app/util/attribute-storage.c

-
- return true;
-}
+// bool emberAfEndpointEnableDisable(uint8_t endpoint, bool enable)


These functions will not be called and will block chip-server from linking, so comment them out.

erjiaqing · 2020-08-12T07:20:15Z

src/app/util/util.c

- emberAfGetEui64(myEui64);
- return (0 == memcmp(eui64, myEui64, EUI64_SIZE) ? true : false);
-}
+// EmberStatus emberAfEndpointEventControlSetDelayMS(EmberEventControl * controls, uint8_t endpoint, uint32_t delayMs)


These functions will not be called and will block chip-server from linking, so comment them out.

why do they block chip-server from linking?

erjiaqing · 2020-08-12T07:53:29Z

I guess #1761 can be implemented first so we can have a valid chip server implementation.

gjc13 · 2020-08-12T08:05:21Z

examples/chip-tool/gen/att-storage.h

@@ -0,0 +1,87 @@
+/**


Do we need these files under examples/chip-tool/gen? I personally believe they should be in the core library.

According to current status, seems we will still put them in seperate example directories.

this particular file is generated specifically for the app, is different for every collection of clusters

- Adds a zcl server for posix mock devices. - Adds the dockerfile for integration into cirque.

github-actions · 2020-08-18T02:45:55Z

Size increase report for "nrf-example-build"

File	Section	File	VM
chip-nrf52840-lock-example.out	.text	16	16

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.text,16,16
[Unmapped],0,-14
.strtab,0,-19
.debug_abbrev,0,-24
.symtab,0,-32
.debug_aranges,0,-160
.debug_ranges,0,-264
.debug_frame,0,-484
.debug_line,0,-968
.debug_str,0,-1206
.debug_loc,0,-2244
.debug_info,0,-2345

github-actions · 2020-08-18T02:46:04Z

Size increase report for "nrfconnect-example-build"

File	Section	File	VM
chip-nrf52840-lock-example.elf	[LOAD #1 [RWX]]	8	8
chip-nrf52840-lock-example.elf	text	8	8

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
[LOAD #1 [RWX]],8,8
text,8,8
[Unmapped],0,-17
.strtab,0,-19
.debug_abbrev,0,-24
.symtab,0,-32
.debug_aranges,0,-160
.debug_ranges,0,-264
.debug_frame,0,-484
.debug_line,0,-1041
.debug_str,0,-1206
.debug_loc,0,-2244
.debug_info,0,-2345

github-actions · 2020-08-18T02:46:10Z

Size increase report for "linux-example-build"

File	Section	File	VM
chip-standalone-demo.out	.text	80	80
chip-standalone-demo.out	.dynstr	52	52
chip-standalone-demo.out	.rodata	32	32
chip-standalone-demo.out	.dynsym	24	24
chip-standalone-demo.out	.rela.plt	24	24
chip-standalone-demo.out	.eh_frame	16	16
chip-standalone-demo.out	.gnu.version_r	16	16
chip-standalone-demo.out	.plt	16	16
chip-standalone-demo.out	.plt.sec	16	16
chip-standalone-demo.out	.got	8	8
chip-standalone-demo.out	[3 Others]	-4	-4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_str,0,7311
.debug_info,0,6399
.debug_abbrev,0,373
.debug_line,0,313
.debug_loc,0,254
.debug_ranges,0,128
.text,80,80
.strtab,0,53
.dynstr,52,52
.debug_macro,0,49
.rodata,32,32
.dynsym,24,24
.rela.plt,24,24
.symtab,0,24
.eh_frame,16,16
.gnu.version_r,16,16
.plt,16,16
.plt.sec,16,16
.got,8,8
[3 Others],-4,-4
[Unmapped],0,-288

github-actions · 2020-08-18T02:46:17Z

Size increase report for "esp32-example-build"

File	Section	File	VM
chip-wifi-echo.elf	.flash.text	-12	-12

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,-4
.flash.text,-12,-12
.symtab,0,-16
.strtab,0,-19
.debug_abbrev,0,-24
.debug_aranges,0,-160
.debug_ranges,0,-232
.debug_frame,0,-480
.debug_loc,0,-825
.debug_str,0,-1206
.debug_line,0,-1952
.debug_info,0,-2346

github-actions · 2020-08-18T02:46:28Z

Size increase report for "gn_nrf-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

github-actions · 2020-08-18T02:46:35Z

Size increase report for "gn_linux-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

woody-apple · 2020-08-18T16:58:37Z

@erjiaqing Can we try to get this integrated into GitHub workflows?

erjiaqing · 2020-08-19T01:57:06Z

@erjiaqing Can we try to get this integrated into GitHub workflows?

I will submit another PR to integrate this into Github workflows.

erjiaqing requested review from andy31415, anush-apple, BroderickCarlin, chrisdecenzo, hawk248, jelderton, robszewczyk, saurabhst and woody-apple as code owners August 10, 2020 03:33

boring-cyborg bot added config examples labels Aug 10, 2020

restyled-io bot mentioned this pull request Aug 10, 2020

Restyle Issue1891 cirque #2043

Closed

erjiaqing changed the title ~~Issue1891 cirque~~ [cirque] Initial support for Cirque test Aug 10, 2020

erjiaqing requested review from yunhanw-google and gjc13 August 10, 2020 03:52

andy31415 reviewed Aug 10, 2020

View reviewed changes

boring-cyborg bot added the app label Aug 12, 2020

erjiaqing force-pushed the issue1891-cirque branch from b9d5f38 to 04117e1 Compare August 12, 2020 07:16

erjiaqing commented Aug 12, 2020

View reviewed changes

erjiaqing force-pushed the issue1891-cirque branch from 04117e1 to bc3d870 Compare August 12, 2020 07:21

gjc13 reviewed Aug 12, 2020

View reviewed changes

andy31415 approved these changes Aug 13, 2020

View reviewed changes

erjiaqing force-pushed the issue1891-cirque branch 2 times, most recently from 863ee7c to c4bef25 Compare August 13, 2020 13:30

gjc13 and others added 3 commits August 18, 2020 10:12

[cirque] Add cirque test for Linux

593108d

- Adds a zcl server for posix mock devices. - Adds the dockerfile for integration into cirque.

[cirque] Initial support for Cirque test

aeda8f5

Restyled by shellharden

61ac26c

restyled-commits and others added 2 commits August 18, 2020 10:12

Restyled by shfmt

6ee04f3

Switch to flask

bfd0a7a

erjiaqing force-pushed the issue1891-cirque branch from c4bef25 to bfd0a7a Compare August 18, 2020 02:13

Set a timeout in chip-tool to avoid infinity wait

f8c97cd

woody-apple approved these changes Aug 18, 2020

View reviewed changes

jelderton approved these changes Aug 18, 2020

View reviewed changes

woody-apple mentioned this pull request Aug 19, 2020

Run Cirque in GitHub workflows #2245

Closed

woody-apple merged commit 89043b0 into project-chip:master Aug 19, 2020

This was referenced Aug 24, 2020

We should not be forcing the Linux device layer on non-Linux host systems by default #2301

Closed

Sort out various issues with the chip standalone server code #2302

Closed

erjiaqing deleted the issue1891-cirque branch January 29, 2021 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cirque] Initial support for Cirque test #2042

[cirque] Initial support for Cirque test #2042

erjiaqing commented Aug 10, 2020 •

edited

Loading

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020

andy31415 Aug 12, 2020

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020

andy31415 Aug 10, 2020

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020

andy31415 Aug 10, 2020

erjiaqing Aug 12, 2020 •

edited

Loading

erjiaqing Aug 12, 2020

erjiaqing Aug 12, 2020

erjiaqing Aug 12, 2020

rwalker-apple Aug 24, 2020

erjiaqing commented Aug 12, 2020

gjc13 Aug 12, 2020 •

edited

Loading

erjiaqing Aug 18, 2020

rwalker-apple Aug 24, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

woody-apple commented Aug 18, 2020

erjiaqing commented Aug 19, 2020


		constexpr chip::NodeId kLocalNodeId = 12344321;

		#define println(format, ...) printf(format "\n", ##__VA_ARGS__)

[cirque] Initial support for Cirque test #2042

[cirque] Initial support for Cirque test #2042

Conversation

erjiaqing commented Aug 10, 2020 • edited Loading

Summary of Changes

How to test

Note:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erjiaqing Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erjiaqing commented Aug 12, 2020

gjc13 Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

github-actions bot commented Aug 18, 2020

woody-apple commented Aug 18, 2020

erjiaqing commented Aug 19, 2020

erjiaqing commented Aug 10, 2020 •

edited

Loading

erjiaqing Aug 12, 2020 •

edited

Loading

gjc13 Aug 12, 2020 •

edited

Loading