Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Bridge app support in YAML #23147

Closed
manjunath-grl opened this issue Oct 12, 2022 · 6 comments · Fixed by #23198
Closed

Need Bridge app support in YAML #23147

manjunath-grl opened this issue Oct 12, 2022 · 6 comments · Fixed by #23198
Labels
CSG_1.x Request from CSG for support post 1.0 yaml Missing features or bugs in the YAML test harness

Comments

@manjunath-grl
Copy link
Contributor

manjunath-grl commented Oct 12, 2022

Feature description

Automated Bridged Device Basic Information cluster(BRBINFO) test, showing response as Unsupported_Cluster when executed and we got to know that python scripts that execute the YAML tests need to be updated to run them against the bridge app.

Diff link:
master...manjunath-grl:connectedhomeip:Bridge_App_Support

Platform

all

Platform Version(s)

No response

Anything else?

image
BRBINFO-2.1
Test_TC_BRBINFO_1_1.zip

@bzbarsky-apple
Copy link
Contributor

Is there more to this than compiling bridge-app and teaching the harness script about it? Which testcases should get run against bridge-app @manjunath-grl ?

@bzbarsky-apple bzbarsky-apple added the yaml Missing features or bugs in the YAML test harness label Oct 13, 2022
@manjunath-grl
Copy link
Contributor Author

Bridged Device Basic Information cluster (BRBINFO-1.1/2.1) testcases should get run against bridge-app
Diff link:
master...manjunath-grl:connectedhomeip:Bridge_App_Support

@bzbarsky-apple
Copy link
Contributor

@manjunath-grl So Test_TC_BRBINFO_2_2 and Test_TC_BRBINFO_2_3 should not run against bridge-app? Just 1.1/2.1?

@manjunath-grl
Copy link
Contributor Author

No those tests also need support I just gave BRBINFO-1.1 and 2.1 test as example

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Oct 14, 2022

OK. What is the full set of tests that need to run against bridge-app?

Note, by the way, that the test in cfab658 will fail against bridge-app because endpoint 1 in that app is not one of the bridged endpoints.... And if you fix that to use endpoint 3, say, the contains: [1] constraint on AttributeList will fail, because CI seems to set BRBINFO.S.A0001 but bridge-app does not in fact have that attribute on that endpoint.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 14, 2022
@bzbarsky-apple
Copy link
Contributor

For now I just did Test_TC_BRBINFO_* as the set of tests to run against bridge-app, but we can adjust as needed.

@raju-apple raju-apple added the CSG_1.x Request from CSG for support post 1.0 label Oct 14, 2022
bzbarsky-apple added a commit that referenced this issue Oct 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSG_1.x Request from CSG for support post 1.0 yaml Missing features or bugs in the YAML test harness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants