Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [SQA] [TC-SWTCH-2.2] Misleading data in MultiPressComplete Event. #23872

Closed
Saravana-kr22 opened this issue Dec 2, 2022 · 1 comment · Fixed by #23895
Closed

[BUG] [SQA] [TC-SWTCH-2.2] Misleading data in MultiPressComplete Event. #23872

Saravana-kr22 opened this issue Dec 2, 2022 · 1 comment · Fixed by #23895

Comments

@Saravana-kr22
Copy link
Contributor

Saravana-kr22 commented Dec 2, 2022

Reproduction steps

1. Subscribe the event : `echo '{"Name":"MultiPressComplete","PreviousPosition":1,"TotalNumberOfPressesCounted":1}' > /tmp/chip_all_clusters_fifo_<PID> `
2. Open the Interactive mode : `./chip-tool interactive start `
3. Run the subscription of the event : `switch subscribe-event multi-press-complete 1 100 1 1 `

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

87994ad

Platform

raspi

Platform Version(s)

RPI-4, 8GB-RAM variant

Issue:

As per the spec MultiPressComplete Event Should have the data of the PreviousPosition,TotalNumberOfPressesCounted. But for the commit: 87994ad in master has the data of Newposition instead of PreviousPosition.

Excepted outcome:

[1659695330.923244][3912:3918] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_003B Event 0x0000_0005
[1659695330.923264][3912:3918] CHIP:TOO: Event number: 45
[1659695330.923283][3912:3918] CHIP:TOO: Priority: Info
[1659695330.923302][3912:3918] CHIP:TOO: Timestamp: 17754336
[1659695330.923326][3912:3918] CHIP:TOO: MultiPressComplete: {
[1659695330.923346][3912:3918] CHIP:TOO: PrevioiusPosition: 1
[1659695330.923366][3912:3918] CHIP:TOO: TotalNumberOfPressesCounted: 1
[1659695330.923385][3912:3918] CHIP:TOO: }

Actual outcome:

[1669976114.571487][35475:35477] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_003B Event 0x0000_0006
[1669976114.571538][35475:35477] CHIP:TOO: Event number: 6
[1669976114.571561][35475:35477] CHIP:TOO: Priority: Info
[1669976114.571584][35475:35477] CHIP:TOO: Timestamp: 18863395
[1669976114.571622][35475:35477] CHIP:TOO: MultiPressComplete: {
[1669976114.571654][35475:35477] CHIP:TOO: NewPosition: 1
[1669976114.571687][35475:35477] CHIP:TOO: TotalNumberOfPressesCounted: 1
[1669976114.571714][35475:35477] CHIP:TOO: }

Reference: Spec, Test-plan

Log: TC-SWTCH-2.2.txt

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Dec 3, 2022
It's called PreviousPosition, not NewPosition.

Fixes project-chip#23872
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Dec 3, 2022
It's called PreviousPosition, not NewPosition.

Fixes project-chip#23872
@bzbarsky-apple
Copy link
Contributor

@Saravana-kr22 Very nice catch!

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Dec 5, 2022
It's called PreviousPosition, not NewPosition.

Fixes project-chip#23872
bzbarsky-apple added a commit that referenced this issue Dec 5, 2022
It's called PreviousPosition, not NewPosition.

Fixes #23872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants