Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staying in active mode through end of commissioning fails if commissioning window closes before commissioning ends #24047

Closed
bzbarsky-apple opened this issue Dec 12, 2022 · 3 comments · Fixed by #27204
Labels
icd Intermittently Connected Devices sleepy

Comments

@bzbarsky-apple
Copy link
Contributor

Even after #23936 we can end up going back to sleep in the middle of commissioning as follows:

  1. A commissioning window is opened for 5 mins
  2. We enter active mode.
  3. Foud (4) minutes later a PASE session is established and commissioning starts.
  4. One (1) minute after that the commissioning window timer fires and we close the commissioning window, which takes us out of active mode, even though commissioning may not be done.

What we should probably do is that if the commissioning window is closed while we have a live PASE session we stay in active mode until the PASE session is closed.

@bzbarsky-apple bzbarsky-apple added sleepy icd Intermittently Connected Devices labels Dec 12, 2022
@bzbarsky-apple
Copy link
Contributor Author

@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jun 10, 2023
@bzbarsky-apple
Copy link
Contributor Author

The spec has now been clarified to say that we stay in active mode as long as either a commissioning window is open or a fail-safe is armed.

We currently implement the former, but we should implement the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icd Intermittently Connected Devices sleepy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant