Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FanControl] Align with spec editorial in Fan Control cluster #27358

Closed
mhazley opened this issue Jun 20, 2023 · 0 comments · Fixed by #27434
Closed

[FanControl] Align with spec editorial in Fan Control cluster #27358

mhazley opened this issue Jun 20, 2023 · 0 comments · Fixed by #27434
Assignees
@mhazley
Labels
app-clusters Application cluster work Spec XML align SDK XML does not match the spec (including naming, etc) v1.2

Comments

@mhazley
Copy link
Contributor

mhazley commented Jun 20, 2023

Description

Following this PR there are some small editorial items that need addressed in SDK.

  • The two bitmaps are now data types; RockBitmap & WindBitmap
  • The anonymous enum types are now data types; FanModeEnum & FanModeSequenceEnum
@mhazley mhazley added app-clusters Application cluster work v1.2 labels Jun 20, 2023
@mhazley mhazley self-assigned this Jun 20, 2023
@mhazley mhazley changed the title [FanControl] [FanControl] Align with spec editorial Jun 20, 2023
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Jun 20, 2023
@bzbarsky-apple bzbarsky-apple changed the title [FanControl] Align with spec editorial [FanControl] Align with spec editorial in Fan Control cluster Jun 20, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 22, 2023
Closed
@mhazley mhazley mentioned this issue Jun 23, 2023
Merged
@mergify mergify bot closed this as completed in #27434 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhazley mhazley

Labels
app-clusters Application cluster work Spec XML align SDK XML does not match the spec (including naming, etc) v1.2
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fan Control Spec Editorial Alignment dysonltd/connectedhomeip
2 participants
@mhazley @bzbarsky-apple