Fan Control Spec Editorial Alignment #27434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #27434: Size comparison from c8b49b9 to ffd9b94 Increases above 0.2%:
Increases (22 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl602, esp32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 23, 2023
|
Note: the test failures are because the type names in YAML need to be adjusted. |
bzbarsky-apple
approved these changes
Jun 23, 2023
|
PR #27434: Size comparison from 42cf63b to 3462653 Increases above 0.2%:
Increases (22 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #27434: Size comparison from a5d8a93 to 01848c3 Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #27434: Size comparison from c8cacd5 to 9a228fc Increases above 0.2%:
Increases (24 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, bl702l, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jul 5, 2023
* Update to the Fan Control renames from project-chip#27434. * Put in the correct Darwin versions for fall release in availability.yaml. * Move anything that is not 100% known to be stable right now to provisional for Darwin fall release in availability.yaml. * Add backwards-compat shim for MTRFanControlWindSettingMask. * Turn off darwin-framework-tool tests that would use the now-not-existing APIs. * Fix availability annotations for initWithResponseValue for command response payloads. * Replace non-generated MTR_NEWLY_* annotations with appropriate API_AVAILABLE and MTR_DEPRECATED.
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Update to the Fan Control renames from #27434. * Put in the correct Darwin versions for fall release in availability.yaml. * Move anything that is not 100% known to be stable right now to provisional for Darwin fall release in availability.yaml. * Add backwards-compat shim for MTRFanControlWindSettingMask. * Turn off darwin-framework-tool tests that would use the now-not-existing APIs. * Fix availability annotations for initWithResponseValue for command response payloads. * Replace non-generated MTR_NEWLY_* annotations with appropriate API_AVAILABLE and MTR_DEPRECATED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ReneJosefsen made some editorial changes to the spec which are addressed in this Pull Request.
@bzbarsky-apple I think this will trigger some darwin changes which I'm not sure about, please let me know if you'd like me to make them as part of this PR.
Links
Fixes #27358