Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CHIP_CONFIG_NON_POSIX_LONG_OPT needs to be defined when false #29216

Closed
bzbarsky-apple opened this issue Sep 13, 2023 · 3 comments · Fixed by #29582
Closed

[BUG] CHIP_CONFIG_NON_POSIX_LONG_OPT needs to be defined when false #29216

bzbarsky-apple opened this issue Sep 13, 2023 · 3 comments · Fixed by #29582
Labels
bug Something isn't working needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

Try to compile with -Wundef.

@ATmobica

Bug prevalence

Always

GitHub hash of the SDK that was being used

b02c984

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Sep 13, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2023
Open
@ATmobica
Copy link
Contributor

@hugueskamba Could you please take over this issue?

@bzbarsky-apple
Copy link
Contributor Author

@ATmobica @hugueskamba this is one of two remaining issues that keep us from turning on -Wundef.

@bzbarsky-apple
Copy link
Contributor Author

@ATmobica @hugueskamba and I guess the real question is why this was not done as a gn build arg or something with fallback defines in CHIPDeviceConfig.h or something like that....

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 5, 2023
@bzbarsky-apple
Enable -Wundef by default.
cde780a 
* Fixes project-chip#29216
* Fixes project-chip#29209
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 5, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 5, 2023
@bzbarsky-apple
Enable -Wundef by default.
af8b291 
* Fixes project-chip#29216
* Fixes project-chip#29209
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 5, 2023
@bzbarsky-apple
Enable -Wundef by default on some platforms.
ab6d77c 
* Fixes project-chip#29216
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 5, 2023
@bzbarsky-apple
Enable -Wundef by default on some platforms.
e1141ff 
* Fixes project-chip#29216
@mergify mergify bot closed this as completed in #29582 Oct 5, 2023
mergify bot pushed a commit that referenced this issue Oct 5, 2023
@bzbarsky-apple
Enable -Wundef by default. (#29582)
8296a75 
* Enable -Wundef by default on some platforms.

* Fixes #29216

* Fix a bunch more errors.

* Restrict -Wundef to where it actually passes CI.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Enable -Wundef by default. (project-chip#29582)
59ce9f8 
* Enable -Wundef by default on some platforms.

* Fixes project-chip#29216

* Fix a bunch more errors.

* Restrict -Wundef to where it actually passes CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable -Wundef by default. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ATmobica