Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] Implement variable use in Yaml commands for groupId (and possibly others) #29637

Closed
lpbeliveau-silabs opened this issue Oct 6, 2023 · 0 comments · Fixed by #29641
Closed

[Tooling] Implement variable use in Yaml commands for groupId (and possibly others) #29637

lpbeliveau-silabs opened this issue Oct 6, 2023 · 0 comments · Fixed by #29641
Labels
needs triage tools

Comments

@lpbeliveau-silabs
Copy link
Contributor

Reproduction steps / Feature

  1. In yaml, define variable in configs as such:
G1:
    type: int16u
    defaultValue: 0x0101
  1. Have a command use the variable for its groupId:
    - label:
...
      groupId: G1
  1. Get an error running the python runner:

TEST OUT : groupId: G1 <-- Unexpected type. Expecting "int", got "str"

Platform

python

Platform Version(s)

No response

Type

YAML tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Oct 6, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 7, 2023
@bzbarsky-apple
Allow groupId to be a variable in YAML tests.
e6cd90e 
This allows targeting group messages at a group id that's a config define.

Fixes project-chip#29637
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 7, 2023
Merged
@mergify mergify bot closed this as completed in #29641 Oct 10, 2023
mergify bot pushed a commit that referenced this issue Oct 10, 2023
@bzbarsky-apple
Allow groupId to be a variable in YAML tests. (#29641)
71e23f9 
This allows targeting group messages at a group id that's a config define.

Fixes #29637
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Allow groupId to be a variable in YAML tests. (project-chip#29641)
4c5df67 
This allows targeting group messages at a group id that's a config define.

Fixes project-chip#29637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow groupId to be a variable in YAML tests. bzbarsky-apple/connectedhomeip
1 participant
@lpbeliveau-silabs