Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.3] Implement Non-Concurrent Spec Change #8728 in SDK #31660

Closed
simonhmorris1 opened this issue Jan 24, 2024 · 0 comments · Fixed by #31739
Closed

[1.3] Implement Non-Concurrent Spec Change #8728 in SDK #31660

simonhmorris1 opened this issue Jan 24, 2024 · 0 comments · Fixed by #31739
Labels
bug Something isn't working linux needs triage

Comments

@simonhmorris1
Copy link
Contributor

simonhmorris1 commented Jan 24, 2024 •
edited by bzbarsky-apple
Loading

Reproduction steps

Run in non-concurrent mode.
The ConnectNetworkResponse(Success) is not sent as required by the https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8728 spec change.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8728

Non-concurrent mode in lighting app requires examples/lighting-app/linux/include/CHIPProjectAppConfig.h to be modified as follows.
#define CHIP_DEVICE_CONFIG_SUPPORTS_CONCURRENT_CONNECTION 0

Bug prevalence

Every time.

GitHub hash of the SDK that was being used

88c0d58

Platform

raspi

Platform Version(s)

Head of SDK

Type

Spec Compliance Issue

Anything else?

https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8728
@simonhmorris1 simonhmorris1 added bug Something isn't working needs triage labels Jan 24, 2024
@github-actions github-actions bot added the linux label Jan 24, 2024
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Jan 24, 2024
@simonhmorris1
Update Non-concurrent mode to latest spec (project-chip#31660)
d0d56dd
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Jan 26, 2024
@simonhmorris1
Handle unused variable (project-chip#31660)
2ea6231
@simonhmorris1 simonhmorris1 mentioned this issue Jan 29, 2024
Merged
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Jan 30, 2024
@simonhmorris1
Trigger from BTP, use regular member (project-chip#31660)
1f02d9c
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Jan 31, 2024
@simonhmorris1
Fix override (project-chip#31660)
afdccbc
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Feb 5, 2024
@simonhmorris1
Use generic OperationalNetworkStarted (project-chip#31660)
f88d95c
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Feb 5, 2024
@simonhmorris1
Replace variable with mState (project-chip#31660)
60959b4 
Use mState instead of mTerminateOnPacketTxComplete
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Feb 6, 2024
@simonhmorris1
Sorted namespace out (project-chip#31660)
f49bedd
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Feb 13, 2024
@simonhmorris1
Address review comments (project-chip#31660)ffffffffffffffffffff
70e19c3 
Close GATT so that BlueZ will disconnect.
Add kOperationalNetworkStarted event type
simonhmorris1 added a commit to simonhmorris1/connectedhomeip that referenced this issue Feb 14, 2024
@simonhmorris1
Access BleLayer mState through function (project-chip#31660)
eeaf38b
@mergify mergify bot closed this as completed in #31739 Feb 14, 2024
mergify bot pushed a commit that referenced this issue Feb 14, 2024
@simonhmorris1 @restyled-commits
Non concurrent mode now sends connect network response as per spec (#…
2696bc9 
…31739)

* Update Non-concurrent mode to latest spec (#31660)

* Handle unused variable (#31660)

* Restyled by clang-format

* Trigger from BTP, use regular member (#31660)

* Fix override (#31660)

* Restyled by whitespace

* Restyled by clang-format

* Use generic OperationalNetworkStarted (#31660)

* Replace variable with mState (#31660)
Use mState instead of mTerminateOnPacketTxComplete

* Sorted namespace out (#31660)

* Restyled by clang-format

* Address review comments (#31660)ffffffffffffffffffff

Close GATT so that BlueZ will disconnect.
Add kOperationalNetworkStarted event type

* Restyled by clang-format

* Access BleLayer mState through function (#31660)

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
raul-marquez-csa pushed a commit to raul-marquez-csa/connectedhomeip that referenced this issue Feb 16, 2024
@simonhmorris1 @restyled-commits @raul-marquez-csa
Non concurrent mode now sends connect network response as per spec (p…
b8507cb 
…roject-chip#31739)

* Update Non-concurrent mode to latest spec (project-chip#31660)

* Handle unused variable (project-chip#31660)

* Restyled by clang-format

* Trigger from BTP, use regular member (project-chip#31660)

* Fix override (project-chip#31660)

* Restyled by whitespace

* Restyled by clang-format

* Use generic OperationalNetworkStarted (project-chip#31660)

* Replace variable with mState (project-chip#31660)
Use mState instead of mTerminateOnPacketTxComplete

* Sorted namespace out (project-chip#31660)

* Restyled by clang-format

* Address review comments (project-chip#31660)ffffffffffffffffffff

Close GATT so that BlueZ will disconnect.
Add kOperationalNetworkStarted event type

* Restyled by clang-format

* Access BleLayer mState through function (project-chip#31660)

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linux needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Non concurrent mode now sends connect network response as per spec simonhmorris1/connectedhomeip
1 participant
@simonhmorris1