Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pretty doesn't cover files not using nlbuild-autotools #345

Closed
rwalker-apple opened this issue Apr 13, 2020 · 6 comments
Closed

Make pretty doesn't cover files not using nlbuild-autotools #345

rwalker-apple opened this issue Apr 13, 2020 · 6 comments
Assignees
Milestone

Comments

@rwalker-apple
Copy link
Contributor

Problem

Example applications, sample source, etc. are excluded from tree formatting facilities unless they are under the nlbuild-autotools make system.

Proposed Solution

Write an umbrella checker/helper, a la our shellcheck scanner, to help pretty and pretty-check the tree.

@rwalker-apple rwalker-apple added this to the M4.3 milestone Apr 13, 2020
@rwalker-apple rwalker-apple self-assigned this Apr 13, 2020
@gerickson
Copy link
Contributor

The easiest solve here would be to just add the files that aren't presently covered with:

PRETTY_FILES += <files to cover with 'make pretty' and 'make pretty-check'>

in the appropriate parent makefiles (for example, src/platform/Makefile.am) or to just add a new makefile for this purpose only at src/platform/EFR32/Makefile.am and src/platform/nRF5/Makefile.am.

@rwalker-apple
Copy link
Contributor Author

that could work, but then we'd keep track of files not covered in those Makefiles somehow?

@gerickson
Copy link
Contributor

that could work, but then we'd keep track of files not covered in those Makefiles somehow?

I think if we want make dist to include those files in an archive distribution, we'd want to do that anyway.

@rwalker-apple
Copy link
Contributor Author

that could work, but then we'd keep track of files not covered in those Makefiles somehow?

I think if we want make dist to include those files in an archive distribution, we'd want to do that anyway.

Might we prefer that all the code we author in the project to be pretty independent of whether it's part of any archive distribution or external product?

@gerickson
Copy link
Contributor

that could work, but then we'd keep track of files not covered in those Makefiles somehow?

I think if we want make dist to include those files in an archive distribution, we'd want to do that anyway.

Might we prefer that all the code we author in the project to be pretty independent of whether it's part of any archive distribution or external product?

I agree, I think; however, I'm not quite clear how that relates. Can you clarify?

@rwalker-apple
Copy link
Contributor Author

closing this issue as irrelevant now that we've essentially moved restyled.io, not relying on make pretty

rerasool pushed a commit to SiliconLabs/matter that referenced this issue Dec 19, 2022
…nd SiWx917

Merge in WMN_TOOLS/matter from docs_path_update to RC_1.0.1

Squashed commit of the following:

commit 65d4f24730ef39c156617fa9ddc931c12edc67fa
Author: Chirag Bansal <chirag.bansal@silabs.com>
Date:   Thu Dec 1 15:33:28 2022 +0530

    removing the matter - Shortcut.lnk

commit 519217ee0c8348bd6273ceb746f65a02ba5387f4
Merge: 2d37288219 594603298c
Author: Chirag Bansal <chirag.bansal@silabs.com>
Date:   Thu Dec 1 15:31:05 2022 +0530

    Merge branch 'RC_1.0.1' of https://stash.silabs.com/scm/wmn_tools/matter into docs_path_update

commit 2d37288219e31d10ec25d57047657b14695d9371
Author: Chirag Bansal <Chirag.Bansal@silabs.com>
Date:   Fri Nov 25 15:27:42 2022 +0000

    Pull request project-chip#311: 917 SOC on-network bring up, 63A/64A/70A board bring ups, MG24-9116 OTA Update fix

    Merge in WMN_TOOLS/matter from feature/wifi_RC_1.0.1_wifi_temp to RC_1.0.1

    Squashed commit of the following:

    commit 9f9a4eed5f10f73c212170329e79823507fc339f
    Author: Manav Mehta <Manav.Mehta@silabs.com>
    Date:   Thu Nov 24 13:45:26 2022 +0000

        Modified to build 87C instead of 86C in non-RC branches

    commit eb737d5184ad7cc1d5b16287f272b2f9620d00f0
    Author: Sharad Patil <sharad.patil@silabs.com>
    Date:   Thu Nov 24 18:35:17 2022 +0530

        Rebase conflict solved for Thermostat app

    commit 2e62a2d411ebc51a3ab0262bef79bd393028f7cb
    Author: Manav Mehta <Manav.Mehta@silabs.com>
    Date:   Wed Nov 23 17:27:27 2022 +0000

        Fix build logic for 63A, 64A, 70A for Wi-Fi NCP

    ... and 16 more commits

... and 10 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants