-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash doing onnetwork connection with chip-device-ctrl #7982
Comments
It looks like we init the Stack
which I suspect corresponds to this part of the log:
So What I don't understand is why this does not bite our other controllers, the ones we test in CI... |
So with If I compile chip-tool with So some obvious questions:
|
OK, so I tried the fix from my question 2 combined with compiling chip-tool with
which is not surprising. I also just checked and if I compile chip-tool with Also, I am confused by the semantics of the
I don't see how consumers can sanely make sense of that... We really need to have our notifications come in some deterministic order and need our state machine to not look wildly different in these different cases. And ideally have fewer cases. |
Problem
Steps to reproduce:
48ed12b9f196e8c384ca102d6663d0766694d65e
.scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false
./scripts/build_python.sh
./out/debug/standalone/chip-all-clusters-app
source ./out/python_env/bin/activate && chip-device-ctrl
chip-device-ctrl
prompt runconnect -ip ::1 20202021 12344321
The python controller crashes.
Stack to crash:
What's happening here is that we land in
DeviceCommissioner::OperationalDiscoveryComplete
, callController::DeviceController::PersistDevice
, end up inDevice::Serialize
, and crash getting the connection state becausemSessionManager
is null.Bisect shows this is a regression from #7666. @pan-apple
Proposed Solution
Figure out where things are going wrong and fix the crash.
The text was updated successfully, but these errors were encountered: