add IpVlan topology to CHIP #10139
Merged
add IpVlan topology to CHIP #10139
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
yunhanw-google
approved these changes
Oct 1, 2021
Damian-Nordic
approved these changes
Oct 1, 2021
jmartinez-silabs
approved these changes
Oct 1, 2021
msandstedt
approved these changes
Oct 1, 2021
andy31415
approved these changes
Oct 1, 2021
|
Approved but @mingchik - where is this executed? Description of testing "manual run" does not help me being not as familiar with cirque. How does one "manually run"? Could you include the command in the description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
add ipv6 topology
Testing
Manual run