Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor System::Clock cleanup #10153

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Followups from PR #10056 Indirect access for System::Clock functions

Fixes #10146 Remove GetMonotonicMicroseconds() call
Fixes #10145 remove.
Fixes #10144 The static cast should have the / 1000 within it

Change overview

Testing

CI. No changes to functionality intended.

#### Problem

Followups from PR project-chip#10056 Indirect access for System::Clock functions

Fixes project-chip#10146 Remove GetMonotonicMicroseconds() call
Fixes project-chip#10145 remove.
Fixes project-chip#10144 The static cast should have the / 1000 within it

#### Change overview

- Removes the global backward-compatibility wrappers for `GetMonotonic…()`.
- Correctly parenthesize the project-chip#10146 cast.

#### Testing

CI. No changes to functionality intended.
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "gn_qpg-example-build" from 80df9f2

File Section File VM
chip-qpg6100-lighting-example.out .text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,45
.debug_info,0,19
.text,16,16
.debug_abbrev,0,14
.debug_line,0,6
.debug_frame,0,4
[Unmapped],0,-16


@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "nrfconnect-example-build" from 80df9f2

File Section File VM
chip-shell.elf text 16 16
chip-lock.elf text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,19
.debug_loc,0,16
text,16,16
.debug_abbrev,0,14
.debug_frame,0,4
.debug_line,0,3

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_loc,0,36
.debug_info,0,19
text,16,16
.debug_abbrev,0,14
.debug_line,0,7
.debug_frame,0,4


@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size increase report for "esp32-example-build" from 80df9f2

File Section File VM
chip-all-clusters-app.elf .flash.text 24 24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,128
.flash.text,24,24
.debug_line,0,16
.debug_frame,0,4
[Unmapped],0,-24


@andy31415
Copy link
Contributor

@andy31415 andy31415 merged commit 4905a6b into project-chip:master Oct 4, 2021
@kpschoedel kpschoedel deleted the x7715-clock-cleanups branch October 4, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants