Generate cluster objects for all clusters. #10156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're only generating them for the ones enabled in controller-clusters.zap.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon,
vivien-apple and
woody-apple
saurabhst
approved these changes
Oct 1, 2021
mrjerryjohns
approved these changes
Oct 1, 2021
turon
approved these changes
Oct 1, 2021
carol-apple
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're only generating them for the ones enabled in controller-clusters.zap.
Problem
Not generating cluster objects for some clusters; makes other things that try to use the cluster objects in signatures not compile.
Change overview
Generate them for all clusters.
Testing
Tree compiles.