Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10412

pjzander-signify · 2021-10-12T12:34:46Z

Problem

Reading of the revision attributes from clusters from dynamic endpoints are returning an incorrect value.

Change overview

If attributes from dynamic endpoints that reside in memory are read or written, an error will be returned.
The storage of the revision attributes in dynamic endpoints will be done externally.
The bridge examples will handle the cluster revision attributes and return the correct value.

NOTE:

This pull request replaces pull request Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10151
This pull request contains format changes

Testing

Reading the revision attributes of all the clusters in the dynamic endpoints and confirm that the returned values are correct.

examples/bridge-app/esp32/main/main.cpp

bzbarsky-apple · 2021-10-13T22:49:11Z

@pjzander-signify How does this differ from #10151? What was the reason for abandoning that one, and the reviews that had already happened there, and opening this one?

pjzander-signify · 2021-10-15T08:57:23Z

@bzbarsky-apple There was something strange about #10151, it created a branch (issue_9823) and I was unable to commit the formatted c files so I decided to close that pull request and make a new one.

bzbarsky-apple · 2021-10-18T13:34:52Z

/rebase

…when the endpoint is dynamic

bzbarsky-apple · 2021-10-18T13:39:34Z

@msandstedt @saurabhst @LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Please take a look?

github-actions · 2021-10-18T13:54:04Z

PR #10412: Size comparison from 5c2afb7 to 3beebef

5 builds

platform	target	config	section	`5c2afb7`	`3beebef`	change
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	`1126280`	1126312	32
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	486104	486120	16
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462352	462352	0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	70984	70984	0
			noinit	33216	33216	0
			text	458146	458148	2

15 builds

platform	target	config	section	`5c2afb7`	`3beebef`	change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0
			.data	1800	1800	0
			.text	782420	782452	32
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	761724	761756	32
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762632	762664	32
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0
			.data	1852	1852	0
			.text	762148	762180	32
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515176	515192	16
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357172	357172	0
	lighting-app	k32w061+se05x+release	.bss	78560	78560	0
			.data	1900	1900	0
			.text	613800	613800	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58432	58432	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	135989	135989	0
			.text	1326066	1326082	16
	chip-tool	debug	.bss	17552	17552	0
			.data	1584	1584	0
			.data.rel.ro	83312	83312	0
			.dynamic	592	592	0
			.got	4336	4336	0
			.init	27	27	0
			.init_array	416	416	0
			.rodata	174560	174560	0
			.text	2422885	`2422917`	32
	ota-provider-app	debug	.bss	37472	37472	0
			.data	752	752	0
			.data.rel.ro	23176	23176	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	109848	109848	0
			.text	1009314	1009346	32
	ota-requestor-app	debug	.bss	205728	205728	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	127896	127896	0
			.text	1128626	1128658	32
	shell	debug	.bss	16072	16072	0
			.data	242	242	0
			.data.rel.ro	35120	35120	0
			.dynamic	592	592	0
			.got	3496	3496	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	71855	71855	0
			.text	568898	568898	0
	tv-app	debug	.bss	216368	216368	0
			.data	2032	2032	0
			.data.rel.ro	55536	55536	0
			.dynamic	592	592	0
			.got	4400	4400	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	151464	151464	0
			.text	1462818	1462850	32
	bridge-app	debug+rpc	.bss	52880	52880	0
			.data	976	976	0
			.data.rel.ro	25496	25496	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110484	110484	0
			.text	`1050821`	1050981	160
	lighting-app	debug+rpc	.bss	42200	42200	0
			.data	1106	1106	0
			.data.rel.ro	52240	52240	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	127665	127665	0
			.text	1252226	1252258	32

2 builds

platform	target	config	section	`5c2afb7`	`3beebef`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219384	1219384
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197440	1197440

12 builds

platform	target	config	section	`5c2afb7`	`3beebef`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60280	60280	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198624	198624	0	0.0
			.flash.text	870142	870154	12	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62776	62776	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207056	207056	0	0.0
			.flash.text	900599	900519	-80	-0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112316	112316	0	0.0
			rodata	97528	97528	0	0.0
			text	577428	577436	8	0.0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0	0.0
			rodata	94028	94028	0	0.0
			text	558928	558936	8	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0	0.0
			rodata	95008	95008	0	0.0
			text	562084	562092	8	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0	0.0
			rodata	94088	94088	0	0.0
			text	558720	558728	8	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71640	71640	0	0.0
			text	518908	518908	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108556	108556	0	0.0
			rodata	88320	88320	0	0.0
			text	550632	550640	8	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113688	113688	0	0.0
			rodata	92772	92772	0	0.0
			text	506888	506900	12	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0	0.0
			rodata	89284	89284	0	0.0
			text	488380	488392	12	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66284	66284	0	0.0
			text	439504	439504	0	0.0

github-actions · 2021-10-18T14:04:35Z

Size increase report for "gn_qpg-example-build" from 5c2afb7

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	16	16

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,230
.debug_ranges,0,136
.debug_str,0,19
.text,16,16
.debug_info,0,14
[Unmapped],0,-16
.debug_line,0,-19

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

github-actions · 2021-10-18T14:47:27Z

Size increase report for "esp32-example-build" from 5c2afb7

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	12	12

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_ranges,0,304
.debug_loc,0,152
.debug_info,0,40
.debug_line,0,32
.debug_str,0,18
.flash.text,12,12
.riscv.attributes,0,2
[Unmapped],0,-12

github-actions · 2021-10-18T14:47:40Z

Size increase report for "nrfconnect-example-build" from 5c2afb7

File	Section	File	VM
chip-lock.elf	device_handles	8	8
chip-lock.elf	text	8	8

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_loc,0,242
.debug_ranges,0,136
.debug_str,0,18
.debug_info,0,14
device_handles,8,8
text,8,8
.debug_line,0,-26

boring-cyborg bot added app examples labels Oct 12, 2021

andy31415 approved these changes Oct 13, 2021

View reviewed changes

examples/bridge-app/esp32/main/main.cpp Show resolved Hide resolved

pjzander-signify added 2 commits October 18, 2021 13:35

Return an error when trying to read/write internal stored attributes …

fb27a49

…when the endpoint is dynamic

Change dynamic endpoints so that the cluster revision is read externally

3beebef

woody-apple force-pushed the issue_9823 branch from 87fe821 to 3beebef Compare October 18, 2021 13:35

pullapprove bot added the review - pending label Oct 18, 2021

bzbarsky-apple approved these changes Oct 18, 2021

View reviewed changes

Damian-Nordic approved these changes Oct 18, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 18, 2021

bzbarsky-apple merged commit 44304c5 into project-chip:master Oct 18, 2021

pjzander-signify deleted the issue_9823 branch October 20, 2021 07:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10412

Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10412

pjzander-signify commented Oct 12, 2021

bzbarsky-apple commented Oct 13, 2021 •

edited

Loading

pjzander-signify commented Oct 15, 2021

bzbarsky-apple commented Oct 18, 2021

bzbarsky-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021

github-actions bot commented Oct 18, 2021

github-actions bot commented Oct 18, 2021

Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10412

Global Attribute ClusterRevision looks broken for clusters of bridged devices (#9823) #10412

Conversation

pjzander-signify commented Oct 12, 2021

Problem

Change overview

Testing

bzbarsky-apple commented Oct 13, 2021 • edited Loading

pjzander-signify commented Oct 15, 2021

bzbarsky-apple commented Oct 18, 2021

bzbarsky-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

github-actions bot commented Oct 18, 2021

github-actions bot commented Oct 18, 2021

github-actions bot commented Oct 18, 2021

bzbarsky-apple commented Oct 13, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading