Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove *SoftwareUpdateManager* files which were never used #10521

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Remove *SoftwareUpdateManager* files which were never used #10521

merged 4 commits into from
Oct 15, 2021

Conversation

holbrookt
Copy link
Contributor

Problem

  • "SoftwareUpdateManager" were imported from the beginning of CHIP but have never been used, and don't implement anything related to CHIP spec

Change overview

  • remove unused files

Testing

  • build succeeds, unit tests pass

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10521: Size comparison from 2377fea to 0269c9b

8 builds
platform target config section 2377fea 0269c9b change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135029 135029 0 0.0
.text 1321298 1321298 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 173792 173792 0 0.0
.text 2422117 2422117 0 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109080 109080 0 0.0
.text 1008946 1008946 0 0.0
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127152 127152 0 0.0
.text 1128594 1128594 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574322 0 0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150792 150792 0 0.0
.text 1466802 1466802 0 0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109748 109748 0 0.0
.text 1050565 1050565 0 0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126897 126897 0 0.0
.text 1251714 1251714 0 0.0
2 builds
platform target config section 2377fea 0269c9b change % change
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1219128 1219128 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1197112 1197112 0 0.0
2 builds
platform target config section 2377fea 0269c9b change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198168 198168 0 0.0
.flash.text 869458 869458 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206756 206756 0 0.0
.flash.text 900459 900551 92 0.0
.iram0.text 125115 125115 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10521: Size comparison from 2377fea to d254202

8 builds
platform target config section 2377fea d254202 change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135029 135029 0 0.0
.text 1321298 1321298 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 173792 173792 0 0.0
.text 2422117 2422117 0 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109080 109080 0 0.0
.text 1008946 1008946 0 0.0
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127152 127152 0 0.0
.text 1128594 1128594 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574322 0 0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150792 150792 0 0.0
.text 1466802 1466802 0 0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109748 109748 0 0.0
.text 1050565 1050565 0 0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126897 126897 0 0.0
.text 1251714 1251714 0 0.0
2 builds
platform target config section 2377fea d254202 change % change
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1219128 1219128 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1197112 1197112 0 0.0
2 builds
platform target config section 2377fea d254202 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198168 198168 0 0.0
.flash.text 869458 869458 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206756 206756 0 0.0
.flash.text 900459 900551 92 0.0
.iram0.text 125115 125115 0 0.0

@github-actions
Copy link

PR #10521: Size comparison from 2377fea to 132e9ef

Increases above 1.0% from 132e9ef to 2377fea:

platform target config section 2377fea 132e9ef change % change
linux shell debug .rodata 71343 72239 896 1.3
8 builds
platform target config section 2377fea 132e9ef change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135029 135893 864 0.6
.text 1321298 1322338 1040 0.1
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 173792 174656 864 0.5
.text 2422117 2423157 1040 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109080 109960 880 0.8
.text 1008946 1009986 1040 0.1
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127152 128032 880 0.7
.text 1128594 1129634 1040 0.1
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 72239 896 1.3
.text 574322 575362 1040 0.2
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150792 151656 864 0.6
.text 1466802 1467842 1040 0.1
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109748 110644 896 0.8
.text 1050565 1051605 1040 0.1
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126897 127761 864 0.7
.text 1251714 1252754 1040 0.1

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10521: Size comparison from 2377fea to b5fa375

8 builds
platform target config section 2377fea b5fa375 change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 514540 515268 728 0.1
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 357520 712 0.2
lighting-app k32w061+se05x+release .bss 78568 78568 0 0.0
.data 1900 1900 0 0.0
.text 613216 613944 728 0.1
p6 lock-app default .bss 68224 68224 0 0.0
.data 2416 2416 0 0.0
.heap 962704 962704 0 0.0
.text 1125776 1126544 768 0.1
qpg lighting-app qpg6100+debug .bss 53536 53536 0 0.0
.data 996 996 0 0.0
.text 485728 486272 544 0.1
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 461912 462464 552 0.1
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70988 70988 0 0.0
noinit 33216 33216 0 0.0
text 457904 458194 290 0.1

Increases above 1.0% from b5fa375 to 2377fea:

platform target config section 2377fea b5fa375 change % change
linux shell debug .rodata 71343 72239 896 1.3
14 builds
platform target config section 2377fea b5fa375 change % change
efr32 lighting-app BRD4161A .bss 118020 118020 0 0.0
.data 1800 1800 0 0.0
.text 781852 782620 768 0.1
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 761124 761892 768 0.1
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 762032 762800 768 0.1
lighting-app BRD4161A+rpc .bss 131348 131348 0 0.0
.data 1852 1852 0 0.0
.text 761592 762380 788 0.1
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135029 135893 864 0.6
.text 1321298 1322338 1040 0.1
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 173792 174656 864 0.5
.text 2422117 2423157 1040 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109080 109960 880 0.8
.text 1008946 1009986 1040 0.1
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127152 128032 880 0.7
.text 1128594 1129634 1040 0.1
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 72239 896 1.3
.text 574322 575362 1040 0.2
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150792 151656 864 0.6
.text 1466802 1467842 1040 0.1
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109748 110644 896 0.8
.text 1050565 1051605 1040 0.1
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126897 127761 864 0.7
.text 1251714 1252754 1040 0.1
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1219128 1219840 712 0.1
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1197112 1197824 712 0.1
2 builds
platform target config section 2377fea b5fa375 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198168 198632 464 0.2
.flash.text 869458 869758 300 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206756 207212 456 0.2
.flash.text 900459 900771 312 0.0
.iram0.text 125115 125115 0 0.0
10 builds
platform target config section 2377fea b5fa375 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112320 112320 0 0.0
rodata 97180 97632 452 0.5
text 577324 577592 268 0.0
lock-app nrf52840dk_nrf52840 bss 111352 111352 0 0.0
rodata 93676 94128 452 0.5
text 558764 559032 268 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111420 111420 0 0.0
rodata 94660 95112 452 0.5
text 561936 562204 268 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111360 111360 0 0.0
rodata 93736 94188 452 0.5
text 558540 558808 268 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71788 452 0.6
text 518964 519232 268 0.1
lighting-app nrf52840dk_nrf52840+rpc bss 108560 108560 0 0.0
rodata 87960 88416 456 0.5
text 550528 550796 268 0.0
nrf5340dk_nrf5340_cpuapp bss 113692 113692 0 0.0
rodata 92420 92872 452 0.5
text 506780 507048 268 0.1
lock-app nrf5340dk_nrf5340_cpuapp bss 112724 112724 0 0.0
rodata 88936 89388 452 0.5
text 488216 488484 268 0.1
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 66432 452 0.7
text 439564 439832 268 0.1

@bzbarsky-apple bzbarsky-apple merged commit 7192bf8 into project-chip:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@shana-apple shana-apple Awaiting requested review from shana-apple

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
efr32 esp32 openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holbrookt @msandstedt @yufengwangca @bzbarsky-apple