Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a build argument to be able to change time delta between two retries during case session #11486

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Added a build argument to be able to change time delta between two retries during case session #11486

merged 2 commits into from
Nov 5, 2021

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Time delta between two retries is by default 300ms for controller and chip-tool during case session. 300ms is too small as a reaction time for constrained device

Change overview

  • Added build argument to be able to change delta between two retries for case session
  • Updated python script to include build argument for python controller

Testing

  • Manual testing with python controller with argument and without
  • Manual testing with chip-tool with argument and without
  • Build and manual testing example app to validate no regression

@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
7743e1a 
…NTERVAL
@boring-cyborg boring-cyborg bot added the scripts label Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

PR #11486: Size comparison from 7addec8 to 7743e1a

Full report (1 build for telink)
platform target config section 7addec8 7743e1a change % change
telink lighting-app tlsr9518adk80d (read/write) 662902 662902 0 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 457992 457992 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

PR #11486: Size comparison from 7addec8 to 94667a1

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7addec8 94667a1 change % change
efr32 lighting-app BRD4161A (read only) 744880 744880 0 0.0
(read/write) 115708 115708 0 0.0
.bss 113932 113932 0 0.0
.data 1772 1772 0 0.0
.text 744872 744872 0 0.0
BRD4161A+rpc (read only) 732408 732408 0 0.0
(read/write) 132324 132324 0 0.0
.bss 130436 130436 0 0.0
.data 1888 1888 0 0.0
.text 732400 732400 0 0.0
lock-app BRD4161A (read only) 724160 724160 0 0.0
(read/write) 113524 113524 0 0.0
.bss 111788 111788 0 0.0
.data 1732 1732 0 0.0
.text 724152 724152 0 0.0
window-app BRD4161A (read only) 725072 725072 0 0.0
(read/write) 113844 113844 0 0.0
.bss 112108 112108 0 0.0
.data 1736 1736 0 0.0
.text 725064 725064 0 0.0
esp32 all-clusters-app c3devkit (read only) 882530 882530 0 0.0
(read/write) 1305960 1305960 0 0.0
.dram0.bss 57576 57576 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198664 198664 0 0.0
.flash.text 882530 882530 0 0.0
.iram0.text 57624 57624 0 0.0
m5stack (read only) 913387 913387 0 0.0
(read/write) 423268 423268 0 0.0
.dram0.bss 60088 60088 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204908 204908 0 0.0
.flash.text 913387 913387 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699216 699216 0 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613728 613728 0 0.0
lock-app k32w061+debug (read/write) 592036 592036 0 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516048 516048 0 0.0
shell k32w061+debug (read/write) 657528 657528 0 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570936 570936 0 0.0
linux all-clusters-app debug (read only) 1703617 1703617 0 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139189 139189 0 0.0
.text 1430962 1430962 0 0.0
bridge-app debug+rpc (read only) 1291605 1291605 0 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110964 110964 0 0.0
.text 1084725 1084725 0 0.0
chip-tool debug (read only) 4508917 4508917 0 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231824 231824 0 0.0
.text 4008629 4008629 0 0.0
lighting-app debug+rpc (read only) 1552617 1552617 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129585 129585 0 0.0
.text 1289426 1289426 0 0.0
ota-provider-app debug (read only) 1250841 1250841 0 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112200 112200 0 0.0
.text 1042514 1042514 0 0.0
ota-requestor-app debug (read only) 1329137 1329137 0 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124176 124176 0 0.0
.text 1106882 1106882 0 0.0
shell debug (read only) 787529 787529 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 608114 608114 0 0.0
tv-app debug (read only) 1816577 1816577 0 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155240 155240 0 0.0
.text 1519026 1519026 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291408 2291408 0 0.0
.bss 178892 178892 0 0.0
.data 5224 5224 0 0.0
.heap 852328 852328 0 0.0
.text 1254008 1254008 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271568 2271568 0 0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1234168 1234168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249224 2249224 0 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1211824 1211824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048464 2048464 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011064 1011064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861303 0 0.0
bss 111256 111256 0 0.0
rodata 96872 96872 0 0.0
text 577556 577556 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823631 823631 0 0.0
bss 107608 107608 0 0.0
rodata 88048 88048 0 0.0
text 551704 551704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786326 0 0.0
bss 112632 112632 0 0.0
rodata 92128 92128 0 0.0
text 507012 507012 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838007 838007 0 0.0
bss 110292 110292 0 0.0
rodata 93240 93240 0 0.0
text 559040 559040 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763306 0 0.0
bss 111700 111700 0 0.0
rodata 88548 88548 0 0.0
text 488588 488588 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844103 844103 0 0.0
bss 110428 110428 0 0.0
rodata 94952 94952 0 0.0
text 563200 563200 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837863 0 0.0
bss 110328 110328 0 0.0
rodata 93240 93240 0 0.0
text 558776 558776 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775963 775963 0 0.0
bss 109080 109080 0 0.0
rodata 72496 72496 0 0.0
text 519796 519796 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690986 690986 0 0.0
bss 110060 110060 0 0.0
rodata 67140 67140 0 0.0
text 440388 440388 0 0.0
p6 all-clusters-app default (read/write) 2300168 2300168 0 0.0
.bss 106840 106840 0 0.0
.data 2520 2520 0 0.0
.heap 923984 923984 0 0.0
.text 1258432 1258432 0 0.0
lock-app default (read/write) 2212872 2212872 0 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171136 1171136 0 0.0
qpg lighting-app qpg6100+debug (read only) 490604 490604 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485284 485284 0 0.0
lock-app qpg6100+debug (read only) 466944 466944 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461624 461624 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662902 662902 0 0.0
bss 69072 69072 0 0.0
noinit 33216 33216 0 0.0
text 457992 457992 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking as this is a build configuration update.

@woody-apple woody-apple merged commit f0d4c42 into project-chip:master Nov 5, 2021
@mkardous-silabs mkardous-silabs deleted the feature/ctrl_case_retries branch November 6, 2021 00:26
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 10, 2021
@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
235b221 
…NTERVAL (project-chip#11486)
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 11, 2021
@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
22f892a 
…NTERVAL (project-chip#11486)
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Nov 11, 2021
@mkardous-silabs @jmartinez-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
5bf0dcf 
…NTERVAL (project-chip#11486)
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Nov 12, 2021
@mkardous-silabs @jmartinez-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
7a1cb57 
…NTERVAL (project-chip#11486)
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 16, 2021
@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
4f344db 
…NTERVAL (project-chip#11486)
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 16, 2021
@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
c512a18 
…NTERVAL (project-chip#11486)
jmeg-sfy pushed a commit to jmeg-sfy/connectedhomeip that referenced this pull request Nov 18, 2021
@mkardous-silabs @jmeg-sfy
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
99cedb2 
…NTERVAL (project-chip#11486)
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@mkardous-silabs
added build argument to change CHIP_CONFIG_MRP_DEFAULT_ACTIVE_RETRY_I…
755df5c 
…NTERVAL (project-chip#11486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple

@jepenven-silabs jepenven-silabs

@rcasallas-silabs rcasallas-silabs

@andy31415 andy31415

@anush-apple anush-apple

@balducci-apple balducci-apple

@bzbarsky-apple bzbarsky-apple

@carol-apple carol-apple

@cecille cecille

@chrisdecenzo chrisdecenzo

@chulspro chulspro

@Damian-Nordic Damian-Nordic

@electrocucaracha electrocucaracha

@erjiaqing erjiaqing

@franck-apple franck-apple

@harimau-qirex harimau-qirex

@hawk248 hawk248

@holbrookt holbrookt

@jelderton jelderton

@jmartinez-silabs jmartinez-silabs

@kpschoedel kpschoedel

@LuDuda LuDuda

@lzgrablic02 lzgrablic02

@msandstedt msandstedt

@pan-apple pan-apple

@robszewczyk robszewczyk

@sagar-apple sagar-apple

@saurabhst saurabhst

@selissia selissia

@tecimovic tecimovic

@vivien-apple vivien-apple

@wbschiller wbschiller

@yufengwangca yufengwangca

@yunhanw-google yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkardous-silabs @woody-apple @jepenven-silabs @rcasallas-silabs