Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment the <tag> bits in window covering. #11711

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Uncomment the <tag> bits in window covering. #11711

merged 1 commit into from
Nov 12, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes #11056
Fixes #11057

Problem

Part of the XML commented out when it doesn't need to be.

Change overview

Uncomment it.

Testing

Reran codegen. No changes, no failures.

@bzbarsky-apple
Uncomment the <tag> bits in window covering.
f53a308 
project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes project-chip#11056
Fixes project-chip#11057
@boring-cyborg boring-cyborg bot added the app label Nov 12, 2021
@github-actions
Copy link

github-actions bot commented Nov 12, 2021 •
edited
Loading

PR #11711: Size comparison from b8f2e6b to f53a308

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b8f2e6b f53a308 change % change
efr32 lighting-app BRD4161A (read only) 747208 747208 0 0.0
(read/write) 115908 115908 0 0.0
.bss 114108 114108 0 0.0
.data 1800 1800 0 0.0
.text 747200 747200 0 0.0
BRD4161A+rpc (read only) 734748 734748 0 0.0
(read/write) 132536 132536 0 0.0
.bss 130612 130612 0 0.0
.data 1924 1924 0 0.0
.text 734740 734740 0 0.0
lock-app BRD4161A (read only) 724040 724040 0 0.0
(read/write) 113692 113692 0 0.0
.bss 111932 111932 0 0.0
.data 1756 1756 0 0.0
.text 724032 724032 0 0.0
window-app BRD4161A (read only) 724936 724936 0 0.0
(read/write) 114012 114012 0 0.0
.bss 112252 112252 0 0.0
.data 1760 1760 0 0.0
.text 724928 724928 0 0.0
esp32 all-clusters-app c3devkit (read only) 822644 822644 0 0.0
(read/write) 1222138 1222138 0 0.0
.dram0.bss 56000 56000 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 166800 166800 0 0.0
.flash.text 822644 822644 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 893683 893683 0 0.0
(read/write) 420320 420320 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 193852 193852 0 0.0
.flash.text 888299 888299 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700600 700600 0 0.0
.bss 77476 77476 0 0.0
.data 1908 1908 0 0.0
.text 615416 615416 0 0.0
lock-app k32w061+debug (read/write) 591820 591820 0 0.0
.bss 67996 67996 0 0.0
.data 1876 1876 0 0.0
.text 516148 516148 0 0.0
shell k32w061+debug (read/write) 657500 657500 0 0.0
.bss 78788 78788 0 0.0
.data 1844 1844 0 0.0
.text 571068 571068 0 0.0
linux all-clusters-app debug (read only) 1707201 1707201 0 0.0
(read/write) 126176 126176 0 0.0
.bss 57584 57584 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139669 139669 0 0.0
.text 1433778 1433778 0 0.0
bridge-app debug+rpc (read only) 1301269 1301269 0 0.0
(read/write) 77328 77328 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27992 27992 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111348 111348 0 0.0
.text 1093285 1093285 0 0.0
chip-tool debug (read only) 4576237 4576237 0 0.0
(read/write) 163688 163688 0 0.0
.bss 41096 41096 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 114864 114864 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 258666 258666 0 0.0
.text 4016805 4016805 0 0.0
lighting-app debug+rpc (read only) 1567945 1567945 0 0.0
(read/write) 110032 110032 0 0.0
.bss 47984 47984 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129265 129265 0 0.0
.text 1304258 1304258 0 0.0
ota-provider-app debug (read only) 1260745 1260745 0 0.0
(read/write) 75080 75080 0 0.0
.bss 44416 44416 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24808 24808 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112839 112839 0 0.0
.text 1051058 1051058 0 0.0
ota-requestor-app debug (read only) 1345529 1345529 0 0.0
(read/write) 78848 78848 0 0.0
.bss 46880 46880 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26056 26056 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123664 123664 0 0.0
.text 1122466 1122466 0 0.0
shell debug (read only) 788905 788905 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77839 77839 0 0.0
.text 609170 609170 0 0.0
tv-app debug (read only) 1845913 1845913 0 0.0
(read/write) 407768 407768 0 0.0
.bss 339656 339656 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59728 59728 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156365 156365 0 0.0
.text 1544738 1544738 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290096 2290096 0 0.0
.bss 179580 179580 0 0.0
.data 5216 5216 0 0.0
.heap 851648 851648 0 0.0
.text 1252696 1252696 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272912 2272912 0 0.0
.bss 172524 172524 0 0.0
.data 5576 5576 0 0.0
.heap 858344 858344 0 0.0
.text 1235512 1235512 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248544 2248544 0 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1211144 1211144 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863095 863095 0 0.0
bss 110932 110932 0 0.0
rodata 96920 96920 0 0.0
text 579628 579628 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 825487 825487 0 0.0
bss 107284 107284 0 0.0
rodata 88112 88112 0 0.0
text 553800 553800 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788154 788154 0 0.0
bss 112304 112304 0 0.0
rodata 92180 92180 0 0.0
text 509096 509096 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838331 0 0.0
bss 109956 109956 0 0.0
rodata 92988 92988 0 0.0
text 559928 559928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763626 0 0.0
bss 111368 111368 0 0.0
rodata 88292 88292 0 0.0
text 489488 489488 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844423 844423 0 0.0
bss 110096 110096 0 0.0
rodata 94696 94696 0 0.0
text 564092 564092 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838183 0 0.0
bss 109992 109992 0 0.0
rodata 92984 92984 0 0.0
text 559664 559664 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775483 775483 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520008 520008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690538 690538 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440616 440616 0 0.0
p6 all-clusters-app default (read/write) 2298176 2298176 0 0.0
.bss 112576 112576 0 0.0
.data 2520 2520 0 0.0
.heap 918248 918248 0 0.0
.text 1256440 1256440 0 0.0
lock-app default (read/write) 2212008 2212008 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170272 1170272 0 0.0
qpg lighting-app qpg6100+debug (read only) 492416 492416 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50624 50624 0 0.0
.data 1008 1008 0 0.0
.text 487096 487096 0 0.0
lock-app qpg6100+debug (read only) 467152 467152 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49560 49560 0 0.0
.data 964 964 0 0.0
.text 461832 461832 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665286 665286 0 0.0
bss 69304 69304 0 0.0
noinit 33216 33216 0 0.0
text 460104 460104 0 0.0

@woody-apple woody-apple merged commit 3db50b1 into project-chip:master Nov 12, 2021
@bzbarsky-apple bzbarsky-apple deleted the tags-back-in-window-covering branch November 12, 2021 17:14
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Uncomment the <tag> bits in window covering. (project-chip#11711)
3c82e7d 
project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes project-chip#11056
Fixes project-chip#11057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emargolis emargolis emargolis approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - pending
Projects
None yet
Milestone
No milestone
4 participants
@bzbarsky-apple @emargolis @yufengwangca @woody-apple