Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32:fix compilation errors for other esp examples on esp32c3 #11716

Merged
merged 1 commit into from
Nov 16, 2021
Merged

ESP32:fix compilation errors for other esp examples on esp32c3 #11716

merged 1 commit into from
Nov 16, 2021

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Nov 12, 2021

Problem

There are some compilation errors for ESP32C3.

Change overview

Fix those errors for ESP32C3 device.

Testing

Tested compiling for the examples manually

@restyled-io restyled-io bot mentioned this pull request Nov 12, 2021
Closed
@wqx6 wqx6 force-pushed the fix_compile_errors_esp32c3 branch 2 times, most recently from d262902 to 602446a Compare November 12, 2021 06:10
@github-actions
Copy link

github-actions bot commented Nov 12, 2021 •
edited
Loading

PR #11716: Size comparison from 3db50b1 to 602446a

Decreases (17 builds for efr32, k32w, nrfconnect, qpg, telink)
platform target config section 3db50b1 602446a change % change
efr32 lighting-app BRD4161A (read only) 747600 747584 -16 -0.0
.text 747592 747576 -16 -0.0
BRD4161A+rpc (read only) 735164 735132 -32 -0.0
.text 735156 735124 -32 -0.0
lock-app BRD4161A (read only) 724440 724424 -16 -0.0
.text 724432 724416 -16 -0.0
window-app BRD4161A (read only) 725352 725320 -32 -0.0
.text 725344 725312 -32 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 701008 700992 -16 -0.0
.text 615792 615776 -16 -0.0
lock-app k32w061+debug (read/write) 592240 592208 -32 -0.0
.text 516536 516504 -32 -0.0
shell k32w061+debug (read/write) 657908 657876 -32 -0.0
.text 571444 571412 -32 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863515 863483 -32 -0.0
text 579844 579816 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 825891 825859 -32 -0.0
text 554016 553988 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788558 788526 -32 -0.0
text 509312 509284 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838751 838719 -32 -0.0
text 560148 560120 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764046 764014 -32 -0.0
text 489708 489680 -28 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844827 844811 -16 -0.0
text 564308 564280 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838607 838575 -32 -0.0
text 559884 559856 -28 -0.0
qpg lighting-app qpg6100+debug (read only) 492636 492604 -32 -0.0
.text 487316 487284 -32 -0.0
lock-app qpg6100+debug (read only) 467372 467348 -24 -0.0
.text 462052 462028 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 665742 665726 -16 -0.0
text 460372 460354 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3db50b1 602446a change % change
efr32 lighting-app BRD4161A (read only) 747600 747584 -16 -0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 747592 747576 -16 -0.0
BRD4161A+rpc (read only) 735164 735132 -32 -0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 735156 735124 -32 -0.0
lock-app BRD4161A (read only) 724440 724424 -16 -0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 724432 724416 -16 -0.0
window-app BRD4161A (read only) 725352 725320 -32 -0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 725344 725312 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 822918 822918 0 0.0
(read/write) 1222330 1222330 0 0.0
.dram0.bss 56016 56016 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 166976 166976 0 0.0
.flash.text 822918 822918 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 893891 893891 0 0.0
(read/write) 420504 420504 0 0.0
.dram0.bss 61104 61104 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 194020 194020 0 0.0
.flash.text 888507 888507 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701008 700992 -16 -0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 615792 615776 -16 -0.0
lock-app k32w061+debug (read/write) 592240 592208 -32 -0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 516536 516504 -32 -0.0
shell k32w061+debug (read/write) 657908 657876 -32 -0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 571444 571412 -32 -0.0
linux all-clusters-app debug (read only) 1708081 1708081 0 0.0
(read/write) 126272 126272 0 0.0
.bss 57680 57680 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139829 139829 0 0.0
.text 1434498 1434498 0 0.0
bridge-app debug+rpc (read only) 1302149 1302149 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27992 27992 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111508 111508 0 0.0
.text 1094005 1094005 0 0.0
chip-tool debug (read only) 4580005 4580005 0 0.0
(read/write) 163880 163880 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 114976 114976 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 258922 258922 0 0.0
.text 4020101 4020101 0 0.0
lighting-app debug+rpc (read only) 1568857 1568857 0 0.0
(read/write) 110128 110128 0 0.0
.bss 48080 48080 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129457 129457 0 0.0
.text 1304978 1304978 0 0.0
ota-provider-app debug (read only) 1261625 1261625 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24808 24808 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1051778 1051778 0 0.0
ota-requestor-app debug (read only) 1346409 1346409 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26056 26056 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123824 123824 0 0.0
.text 1123186 1123186 0 0.0
shell debug (read only) 788905 788905 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77839 77839 0 0.0
.text 609170 609170 0 0.0
tv-app debug (read only) 1846841 1846841 0 0.0
(read/write) 407864 407864 0 0.0
.bss 339752 339752 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59728 59728 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156525 156525 0 0.0
.text 1545506 1545506 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290392 2290392 0 0.0
.bss 179612 179612 0 0.0
.data 5216 5216 0 0.0
.heap 851616 851616 0 0.0
.text 1252992 1252992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273200 2273200 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1235800 1235800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248832 2248832 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1211432 1211432 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863515 863483 -32 -0.0
bss 110964 110964 0 0.0
rodata 97084 97084 0 0.0
text 579844 579816 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 825891 825859 -32 -0.0
bss 107316 107316 0 0.0
rodata 88276 88276 0 0.0
text 554016 553988 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788558 788526 -32 -0.0
bss 112336 112336 0 0.0
rodata 92344 92344 0 0.0
text 509312 509284 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838751 838719 -32 -0.0
bss 109988 109988 0 0.0
rodata 93152 93152 0 0.0
text 560148 560120 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764046 764014 -32 -0.0
bss 111400 111400 0 0.0
rodata 88456 88456 0 0.0
text 489708 489680 -28 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844827 844811 -16 -0.0
bss 110128 110128 0 0.0
rodata 94860 94860 0 0.0
text 564308 564280 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838607 838575 -32 -0.0
bss 110024 110024 0 0.0
rodata 93152 93152 0 0.0
text 559884 559856 -28 -0.0
shell nrf52840dk_nrf52840 (read/write) 775483 775483 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520008 520008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690538 690538 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440616 440616 0 0.0
p6 all-clusters-app default (read/write) 2298576 2298576 0 0.0
.bss 112608 112608 0 0.0
.data 2520 2520 0 0.0
.heap 918216 918216 0 0.0
.text 1256840 1256840 0 0.0
lock-app default (read/write) 2212408 2212408 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1170672 1170672 0 0.0
qpg lighting-app qpg6100+debug (read only) 492636 492604 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 487316 487284 -32 -0.0
lock-app qpg6100+debug (read only) 467372 467348 -24 -0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 462052 462028 -24 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665742 665726 -16 -0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 460372 460354 -18 -0.0

@chshu
Copy link
Contributor

chshu commented Nov 12, 2021

@wqx6 Could you add some more instructions in each example README, to indicate the ESP32C3 support?

Similar instructions like: https://github.com/project-chip/connectedhomeip/blob/master/examples/all-clusters-app/esp32/README.md?plain=1#L82

@restyled-io restyled-io bot mentioned this pull request Nov 15, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11716: Size comparison from 5623978 to 603a4a2

Decreases (17 builds for efr32, k32w, nrfconnect, qpg, telink)
platform target config section 5623978 603a4a2 change % change
efr32 lighting-app BRD4161A (read only) 750088 750056 -32 -0.0
.text 750080 750048 -32 -0.0
BRD4161A+rpc (read only) 737636 737620 -16 -0.0
.text 737628 737612 -16 -0.0
lock-app BRD4161A (read only) 726752 726720 -32 -0.0
.text 726744 726712 -32 -0.0
window-app BRD4161A (read only) 727744 727712 -32 -0.0
.text 727736 727704 -32 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 702508 -32 -0.0
.text 617324 617292 -32 -0.0
lock-app k32w061+debug (read/write) 593548 593532 -16 -0.0
.text 517844 517828 -16 -0.0
shell k32w061+debug (read/write) 659232 659200 -32 -0.0
.text 572768 572736 -32 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865159 -16 -0.0
text 581516 581488 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827567 827535 -32 -0.0
text 555688 555660 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790202 -32 -0.0
text 510984 510956 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840199 840183 -16 -0.0
text 561616 561588 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765514 765482 -32 -0.0
text 491176 491148 -28 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 846295 -32 -0.0
text 565800 565772 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 839887 -16 -0.0
text 561236 561208 -28 -0.0
qpg lighting-app qpg6100+debug (read only) 494216 494184 -32 -0.0
.text 488896 488864 -32 -0.0
lock-app qpg6100+debug (read only) 468752 468720 -32 -0.0
.text 463432 463400 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 667838 -16 -0.0
text 462372 462354 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5623978 603a4a2 change % change
efr32 lighting-app BRD4161A (read only) 750088 750056 -32 -0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 750080 750048 -32 -0.0
BRD4161A+rpc (read only) 737636 737620 -16 -0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737628 737612 -16 -0.0
lock-app BRD4161A (read only) 726752 726720 -32 -0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726744 726712 -32 -0.0
window-app BRD4161A (read only) 727744 727712 -32 -0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727736 727704 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 826956 826956 0 0.0
(read/write) 1224466 1224466 0 0.0
.dram0.bss 57088 57088 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 168040 168040 0 0.0
.flash.text 826956 826956 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897631 897631 0 0.0
(read/write) 422624 422624 0 0.0
.dram0.bss 62184 62184 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 195060 195060 0 0.0
.flash.text 892247 892247 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 702508 -32 -0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 617324 617292 -32 -0.0
lock-app k32w061+debug (read/write) 593548 593532 -16 -0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517844 517828 -16 -0.0
shell k32w061+debug (read/write) 659232 659200 -32 -0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572768 572736 -32 -0.0
linux all-clusters-app debug (read only) 1722337 1722337 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140277 0 0.0
.text 1447842 1447842 0 0.0
bridge-app debug+rpc (read only) 1312741 1312741 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111860 0 0.0
.text 1103909 1103909 0 0.0
chip-tool debug (read only) 4921493 4921493 0 0.0
(read/write) 167208 167208 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268242 0 0.0
.text 4343605 4343605 0 0.0
lighting-app debug+rpc (read only) 1582281 1582281 0 0.0
(read/write) 110192 110192 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129841 0 0.0
.text 1317746 1317746 0 0.0
ota-provider-app debug (read only) 1267337 1267337 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057106 1057106 0 0.0
ota-requestor-app debug (read only) 1352009 1352009 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124208 0 0.0
.text 1128402 1128402 0 0.0
shell debug (read only) 789081 789081 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 609282 609282 0 0.0
tv-app debug (read only) 1858569 1858569 0 0.0
(read/write) 407896 407896 0 0.0
.bss 339752 339752 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157069 0 0.0
.text 1556418 1556418 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292200 0 0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1254800 1254800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2274688 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1237288 1237288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250128 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212728 1212728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865159 -16 -0.0
bss 110964 110964 0 0.0
rodata 97080 97080 0 0.0
text 581516 581488 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827567 827535 -32 -0.0
bss 107320 107320 0 0.0
rodata 88272 88272 0 0.0
text 555688 555660 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790202 -32 -0.0
bss 112340 112340 0 0.0
rodata 92340 92340 0 0.0
text 510984 510956 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840199 840183 -16 -0.0
bss 109988 109988 0 0.0
rodata 93144 93144 0 0.0
text 561616 561588 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765514 765482 -32 -0.0
bss 111400 111400 0 0.0
rodata 88452 88452 0 0.0
text 491176 491148 -28 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 846295 -32 -0.0
bss 110128 110128 0 0.0
rodata 94856 94856 0 0.0
text 565800 565772 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 839887 -16 -0.0
bss 110024 110024 0 0.0
rodata 93104 93104 0 0.0
text 561236 561208 -28 -0.0
shell nrf52840dk_nrf52840 (read/write) 775499 775499 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520020 520020 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690554 690554 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440628 440628 0 0.0
p6 all-clusters-app default (read/write) 2301232 2301232 0 0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1259496 1259496 0 0.0
lock-app default (read/write) 2214704 2214704 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1172968 1172968 0 0.0
qpg lighting-app qpg6100+debug (read only) 494216 494184 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488896 488864 -32 -0.0
lock-app qpg6100+debug (read only) 468752 468720 -32 -0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463432 463400 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 667838 -16 -0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 462372 462354 -18 -0.0

@andy31415 andy31415 dismissed bzbarsky-apple’s stale review November 15, 2021 19:20

Comments resolved and replied to, re-requesting separate review

@andy31415 andy31415 merged commit 40320ad into project-chip:master Nov 16, 2021
@dave-code-ruiz
Copy link

This PR generate error when i try to use target ESP32S3, AppConfig.h is not prepared to use this target CONFIG_IDF_TARGET_ESP32S3 , only can use CONFIG_IDF_TARGET_ESP32 or CONFIG_IDF_TARGET_ESP32C3.

Is it possible to develop ESP32S3 option similar this?

#define APP_TASK_NAME "LOCK-APP"
#if CONFIG_IDF_TARGET_ESP32
#define SYSTEM_STATE_LED GPIO_NUM_25
#define LOCK_STATE_LED GPIO_NUM_26

#define APP_LOCK_BUTTON GPIO_NUM_34
#define APP_FUNCTION_BUTTON GPIO_NUM_35
#elif CONFIG_IDF_TARGET_ESP32C3
#define SYSTEM_STATE_LED GPIO_NUM_8
#define LOCK_STATE_LED GPIO_NUM_9

#define APP_LOCK_BUTTON GPIO_NUM_18
#define APP_FUNCTION_BUTTON GPIO_NUM_19
#elif CONFIG_IDF_TARGET_ESP32S3
#define SYSTEM_STATE_LED GPIO_NUM_x
#define LOCK_STATE_LED GPIO_NUM_x

#define APP_LOCK_BUTTON GPIO_NUM_x
#define APP_FUNCTION_BUTTON GPIO_NUM_x
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@gjc13 gjc13 gjc13 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
examples openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wqx6 @chshu @dave-code-ruiz @andy31415 @gjc13 @saurabhst @woody-apple @bzbarsky-apple