Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a libfuzzer config to the build system. #11921

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add a libfuzzer config to the build system. #11921

merged 1 commit into from
Nov 18, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

No easy way to build with -fsanitize=fuzzer when building with clang.

Change overview

Add a way to tell gn to include that build option.

Testing

Compiled locally, verified that the compile works (though the link fails for me because I don't actually have the libfuzzer library locally).

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11921: Size comparison from 4efa5de to 2fd736e

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4efa5de 2fd736e change % change
efr32 lighting-app BRD4161A (read only) 748304 748304 0 0.0
(read/write) 115508 115508 0 0.0
.bss 113708 113708 0 0.0
.data 1800 1800 0 0.0
.text 748296 748296 0 0.0
BRD4161A+rpc (read only) 735836 735836 0 0.0
(read/write) 132136 132136 0 0.0
.bss 130212 130212 0 0.0
.data 1924 1924 0 0.0
.text 735828 735828 0 0.0
lock-app BRD4161A (read only) 725376 725376 0 0.0
(read/write) 113292 113292 0 0.0
.bss 111532 111532 0 0.0
.data 1756 1756 0 0.0
.text 725368 725368 0 0.0
window-app BRD4161A (read only) 726336 726336 0 0.0
(read/write) 113612 113612 0 0.0
.bss 111852 111852 0 0.0
.data 1760 1760 0 0.0
.text 726328 726328 0 0.0
esp32 all-clusters-app c3devkit (read only) 827478 827478 0 0.0
(read/write) 1220122 1220122 0 0.0
.dram0.bss 56656 56656 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164128 164128 0 0.0
.flash.text 827478 827478 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898387 898387 0 0.0
(read/write) 419444 419444 0 0.0
.dram0.bss 62008 62008 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192100 192100 0 0.0
.flash.text 893003 893003 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705936 705936 0 0.0
.bss 77132 77132 0 0.0
.data 1912 1912 0 0.0
.text 621092 621092 0 0.0
lock-app k32w061+debug (read/write) 597380 597380 0 0.0
.bss 67644 67644 0 0.0
.data 1880 1880 0 0.0
.text 522056 522056 0 0.0
shell k32w061+debug (read/write) 662612 662612 0 0.0
.bss 78708 78708 0 0.0
.data 1848 1848 0 0.0
.text 576256 576256 0 0.0
linux all-clusters-app debug (read only) 1715969 1715969 0 0.0
(read/write) 127008 127008 0 0.0
.bss 57648 57648 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63040 63040 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135669 135669 0 0.0
.text 1446274 1446274 0 0.0
bridge-app debug+rpc (read only) 1311117 1311117 0 0.0
(read/write) 77232 77232 0 0.0
.bss 42352 42352 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28312 28312 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111044 111044 0 0.0
.text 1102597 1102597 0 0.0
chip-tool debug (read only) 4968173 4968173 0 0.0
(read/write) 167048 167048 0 0.0
.bss 40712 40712 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118552 118552 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267594 267594 0 0.0
.text 4390069 4390069 0 0.0
lighting-app debug+rpc (read only) 1580249 1580249 0 0.0
(read/write) 110448 110448 0 0.0
.bss 48016 48016 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55872 55872 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128689 128689 0 0.0
.text 1316482 1316482 0 0.0
ota-provider-app debug (read only) 1259777 1259777 0 0.0
(read/write) 75880 75880 0 0.0
.bss 44960 44960 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25032 25032 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113215 113215 0 0.0
.text 1048898 1048898 0 0.0
ota-requestor-app debug (read only) 1343321 1343321 0 0.0
(read/write) 79584 79584 0 0.0
.bss 47424 47424 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26216 26216 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1119090 1119090 0 0.0
shell debug (read only) 796361 796361 0 0.0
(read/write) 66280 66280 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37712 37712 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78447 78447 0 0.0
.text 613826 613826 0 0.0
tv-app debug (read only) 1859089 1859089 0 0.0
(read/write) 318552 318552 0 0.0
.bss 250088 250088 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60008 60008 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156933 156933 0 0.0
.text 1557026 1557026 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287448 2287448 0 0.0
.bss 179252 179252 0 0.0
.data 5216 5216 0 0.0
.heap 851976 851976 0 0.0
.text 1250048 1250048 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273376 2273376 0 0.0
.bss 172116 172116 0 0.0
.data 5576 5576 0 0.0
.heap 858752 858752 0 0.0
.text 1235976 1235976 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249216 2249216 0 0.0
.bss 171004 171004 0 0.0
.data 5568 5568 0 0.0
.heap 859872 859872 0 0.0
.text 1211816 1211816 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050704 2050704 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1013304 1013304 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863615 863615 0 0.0
bss 110528 110528 0 0.0
rodata 95808 95808 0 0.0
text 581668 581668 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826011 826011 0 0.0
bss 106884 106884 0 0.0
rodata 86988 86988 0 0.0
text 555836 555836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788658 788658 0 0.0
bss 111904 111904 0 0.0
rodata 91068 91068 0 0.0
text 511136 511136 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839047 839047 0 0.0
bss 109552 109552 0 0.0
rodata 92280 92280 0 0.0
text 561764 561764 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764334 764334 0 0.0
bss 110964 110964 0 0.0
rodata 87584 87584 0 0.0
text 491324 491324 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845155 845155 0 0.0
bss 109692 109692 0 0.0
rodata 93988 93988 0 0.0
text 565944 565944 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838747 838747 0 0.0
bss 109588 109588 0 0.0
rodata 92236 92236 0 0.0
text 561384 561384 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777691 777691 0 0.0
bss 109004 109004 0 0.0
rodata 73088 73088 0 0.0
text 521000 521000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692746 692746 0 0.0
bss 109988 109988 0 0.0
rodata 67732 67732 0 0.0
text 441608 441608 0 0.0
p6 all-clusters-app default (read/write) 2296152 2296152 0 0.0
.bss 112240 112240 0 0.0
.data 2520 2520 0 0.0
.heap 918584 918584 0 0.0
.text 1254416 1254416 0 0.0
lock-app default (read/write) 2213624 2213624 0 0.0
.bss 100864 100864 0 0.0
.data 2400 2400 0 0.0
.heap 930080 930080 0 0.0
.text 1171888 1171888 0 0.0
qpg lighting-app qpg6100+debug (read only) 492784 492784 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50152 50152 0 0.0
.data 1008 1008 0 0.0
.text 487464 487464 0 0.0
lock-app qpg6100+debug (read only) 467764 467764 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49096 49096 0 0.0
.data 964 964 0 0.0
.text 462444 462444 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 766966 766966 0 0.0
bss 79040 79040 0 0.0
noinit 37160 37160 0 0.0
text 532202 532202 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

@carol-apple @jepenven-silabs @jmartinez-silabs @saurabhst @LuDuda @Damian-Nordic Please take a look?

@Damian-Nordic Damian-Nordic merged commit 3796b51 into project-chip:master Nov 18, 2021
@bzbarsky-apple bzbarsky-apple deleted the add-libfuzzing-config branch November 18, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @andy31415 @saurabhst @yufengwangca @Damian-Nordic