Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K32W0] Fix shell app #12205

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Nov 24, 2021

Problem

  • shell test case was not working on NXP platform due to missing OT/Matter functionality

Change overview

  • enable OT/Matter defines required for DNS functionality

Testing

  • manual testing

This PR is a duplicate of #12153 but targeted to the master branch.

* enable OT/Matter defines required for DNS functionality

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
@github-actions
Copy link

github-actions bot commented Nov 24, 2021

PR #12205: Size comparison from b87d1fa to 0bfee46

Increases above 0.2%:

platform target config section b87d1fa 0bfee46 change % change
k32w lighting-app k32w061+se05x+release (read/write) 711816 718396 6580 0.9
.data 1936 1952 16 0.8
.text 625948 632400 6452 1.0
lock-app k32w061+debug (read/write) 602028 608688 6660 1.1
.data 1904 1920 16 0.8
.text 525752 532284 6532 1.2
shell k32w061+debug (read/write) 667520 674096 6576 1.0
.data 1872 1888 16 0.9
.text 580108 586556 6448 1.1
Increases (3 builds for k32w)
platform target config section b87d1fa 0bfee46 change % change
k32w lighting-app k32w061+se05x+release (read/write) 711816 718396 6580 0.9
.bss 78132 78244 112 0.1
.data 1936 1952 16 0.8
.text 625948 632400 6452 1.0
lock-app k32w061+debug (read/write) 602028 608688 6660 1.1
.bss 68572 68684 112 0.2
.data 1904 1920 16 0.8
.text 525752 532284 6532 1.2
shell k32w061+debug (read/write) 667520 674096 6576 1.0
.bss 79740 79852 112 0.1
.data 1872 1888 16 0.9
.text 580108 586556 6448 1.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b87d1fa 0bfee46 change % change
efr32 lighting-app BRD4161A (read only) 757072 757072 0 0.0
(read/write) 119788 119788 0 0.0
.bss 117972 117972 0 0.0
.data 1816 1816 0 0.0
.text 757064 757064 0 0.0
BRD4161A+rpc (read only) 744524 744524 0 0.0
(read/write) 136416 136416 0 0.0
.bss 134476 134476 0 0.0
.data 1940 1940 0 0.0
.text 744516 744516 0 0.0
lock-app BRD4161A (read only) 732936 732936 0 0.0
(read/write) 117508 117508 0 0.0
.bss 115732 115732 0 0.0
.data 1772 1772 0 0.0
.text 732928 732928 0 0.0
window-app BRD4161A (read only) 736368 736368 0 0.0
(read/write) 117868 117868 0 0.0
.bss 116084 116084 0 0.0
.data 1780 1780 0 0.0
.text 736360 736360 0 0.0
esp32 all-clusters-app c3devkit (read only) 835272 835272 0 0.0
(read/write) 1222362 1222362 0 0.0
.dram0.bss 57824 57824 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165184 165184 0 0.0
.flash.text 835272 835272 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 906691 906691 0 0.0
(read/write) 421676 421676 0 0.0
.dram0.bss 63216 63216 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193108 193108 0 0.0
.flash.text 901307 901307 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711816 718396 6580 0.9
.bss 78132 78244 112 0.1
.data 1936 1952 16 0.8
.text 625948 632400 6452 1.0
lock-app k32w061+debug (read/write) 602028 608688 6660 1.1
.bss 68572 68684 112 0.2
.data 1904 1920 16 0.8
.text 525752 532284 6532 1.2
shell k32w061+debug (read/write) 667520 674096 6576 1.0
.bss 79740 79852 112 0.1
.data 1872 1888 16 0.9
.text 580108 586556 6448 1.1
linux all-clusters-app debug (read only) 1765289 1765289 0 0.0
(read/write) 129432 129432 0 0.0
.bss 58576 58576 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64384 64384 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138357 138357 0 0.0
.text 1488946 1488946 0 0.0
bridge-app debug+rpc (read only) 1340837 1340837 0 0.0
(read/write) 77376 77376 0 0.0
.bss 41488 41488 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29184 29184 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 112924 112924 0 0.0
.text 1128181 1128181 0 0.0
chip-tool debug (read only) 5957109 5957109 0 0.0
(read/write) 197104 197104 0 0.0
.bss 39840 39840 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 149320 149320 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283848 283848 0 0.0
.text 5289941 5289941 0 0.0
lighting-app debug+rpc (read only) 1614113 1614113 0 0.0
(read/write) 110656 110656 0 0.0
.bss 47184 47184 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56784 56784 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131281 131281 0 0.0
.text 1345474 1345474 0 0.0
ota-provider-app debug (read only) 1305001 1305001 0 0.0
(read/write) 75864 75864 0 0.0
.bss 44064 44064 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25736 25736 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114704 114704 0 0.0
.text 1090306 1090306 0 0.0
ota-requestor-app debug (read only) 1401537 1401537 0 0.0
(read/write) 79760 79760 0 0.0
.bss 46528 46528 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27096 27096 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126144 126144 0 0.0
.text 1172610 1172610 0 0.0
shell debug (read only) 818721 818721 0 0.0
(read/write) 66520 66520 0 0.0
.bss 23240 23240 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38392 38392 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78991 78991 0 0.0
.text 633378 633378 0 0.0
tv-app debug (read only) 1910681 1910681 0 0.0
(read/write) 319624 319624 0 0.0
.bss 249928 249928 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61136 61136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159208 159208 0 0.0
.text 1603634 1603634 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293808 2293808 0 0.0
.bss 180380 180380 0 0.0
.data 5240 5240 0 0.0
.heap 850824 850824 0 0.0
.text 1256408 1256408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278008 2278008 0 0.0
.bss 172284 172284 0 0.0
.data 5600 5600 0 0.0
.heap 858560 858560 0 0.0
.text 1240608 1240608 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252392 2252392 0 0.0
.bss 171100 171100 0 0.0
.data 5584 5584 0 0.0
.heap 859760 859760 0 0.0
.text 1214992 1214992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050648 2050648 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013248 1013248 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870919 870919 0 0.0
bss 112628 112628 0 0.0
rodata 96496 96496 0 0.0
text 586156 586156 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 833287 833287 0 0.0
bss 108980 108980 0 0.0
rodata 87680 87680 0 0.0
text 560324 560324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795962 795962 0 0.0
bss 114000 114000 0 0.0
rodata 91756 91756 0 0.0
text 515616 515616 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 843011 843011 0 0.0
bss 109660 109660 0 0.0
rodata 92500 92500 0 0.0
text 565400 565400 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 768282 768282 0 0.0
bss 111072 111072 0 0.0
rodata 87788 87788 0 0.0
text 494952 494952 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 849143 849143 0 0.0
bss 109800 109800 0 0.0
rodata 94208 94208 0 0.0
text 569580 569580 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 842703 842703 0 0.0
bss 109696 109696 0 0.0
rodata 92456 92456 0 0.0
text 565020 565020 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778311 778311 0 0.0
bss 109168 109168 0 0.0
rodata 72996 72996 0 0.0
text 521532 521532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693350 693350 0 0.0
bss 110152 110152 0 0.0
rodata 67640 67640 0 0.0
text 442140 442140 0 0.0
p6 all-clusters-app default (read/write) 2309128 2309128 0 0.0
.bss 113368 113368 0 0.0
.data 2544 2544 0 0.0
.heap 917432 917432 0 0.0
.text 1267392 1267392 0 0.0
lock-app default (read/write) 2221128 2221128 0 0.0
.bss 100960 100960 0 0.0
.data 2416 2416 0 0.0
.heap 929968 929968 0 0.0
.text 1179392 1179392 0 0.0
qpg lighting-app qpg6100+debug (read only) 498664 498664 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50368 50368 0 0.0
.data 1020 1020 0 0.0
.text 493344 493344 0 0.0
lock-app qpg6100+debug (read only) 472568 472568 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49240 49240 0 0.0
.data 976 976 0 0.0
.text 467248 467248 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 772310 772310 0 0.0
bss 79204 79204 0 0.0
noinit 37160 37160 0 0.0
text 536388 536388 0 0.0

@woody-apple woody-apple merged commit a8b5015 into project-chip:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants