Update Door Lock Cluster definitions #12289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
woody-apple
approved these changes
Dec 1, 2021
|
Fast tracking given this has been in review for a while, and has had enough time for comment. |
|
/rebase |
|
PR #12289: Size comparison from dc10c82 to fcb676c Increases (5 builds for esp32, linux, mbed, p6)
Decreases (6 builds for esp32, linux, mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
/rebase |
- It was moved into matter data model directory
Morozov-5F
force-pushed
the
feature/update-door-lock-cluster-definitions
branch
from
fcb676c to
ae791d4
Compare
|
PR #12289: Size comparison from b6adaf7 to ae791d4 Increases (5 builds for esp32, linux, mbed, p6)
Decreases (6 builds for esp32, linux, mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #12289: Size comparison from 70af2c4 to b61bb8c Increases (5 builds for esp32, linux, mbed, p6)
Decreases (6 builds for esp32, linux, mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
Fast tracking this given this has been in review for > 3 days |
billwatersiii
pushed a commit
to billwatersiii/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Add new cluster definition for a door lock * Remove door lock cluster definition from silabs XML - It was moved into matter data model directory * Update zap files for all the examples to reflect door lock changes * Tweak the door lock cluster so it uses new definitions * Fix java ZAP templates to support nullables and bitmaps * Fix style issues * Use proper types in the attribute definitions of the Door Lock Cluster * Update auto-generated files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update Door Lock Cluster definitions.
Change overview
NOTE: I did not include auto-generated files on purpose because they are constantly changing in the upstream. I would prefer to upload them once the main code review is complete but I can upload then whenever they needed.
Testing