-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doxygen Docker Image #12337
Merged
woody-apple
merged 1 commit into
project-chip:master
from
electrocucaracha:improve_doxygen
Nov 30, 2021
Merged
Improve doxygen Docker Image #12337
woody-apple
merged 1 commit into
project-chip:master
from
electrocucaracha:improve_doxygen
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrocucaracha
requested review from
bzbarsky-apple,
andy31415 and
woody-apple
and removed request for
bzbarsky-apple
November 29, 2021 21:26
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk and
sagar-apple
November 29, 2021 21:27
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vivien-apple,
wbschiller and
yufengwangca
November 29, 2021 21:27
PR #12337: Size comparison from 489de97 to f18a42b Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 30, 2021
Fast tracking, given this is updating the docker image. |
PR #12337: Size comparison from 677d87e to ebfa8c5 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
electrocucaracha
force-pushed
the
improve_doxygen
branch
from
November 30, 2021 14:16
ebfa8c5
to
5944cb8
Compare
Signed-off-by: Victor Morales <v.morales@samsung.com>
electrocucaracha
force-pushed
the
improve_doxygen
branch
from
November 30, 2021 14:28
5944cb8
to
9e4e899
Compare
PR #12337: Size comparison from 7e99454 to 9e4e899 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Doxygen GitHub action is not using the connectedhomeip/chip-build-doxygen image and also executes a script which only requires two external tools (doxygen and graphviz).
Change overview
This change fixes the source code to pass the doxygen execution and includes a lighter Docker image (from 2.83GB to 41.9MB) for Doxygen CI execution.
Testing
These changes was tested using the
act -j doxygen
command