Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize report delivery timing for subscribe #12398

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Optimize report delivery timing for subscribe #12398

merged 1 commit into from
Dec 1, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 1, 2021 •
edited
Loading

Problem

--Between subscribe min and max interval, only send the report when the handler is dirty
--At subscribe max interval, mHoldSync is unset, handler would send the report

Change overview

What's in this PR

Testing

Existing test covers

@boring-cyborg boring-cyborg bot added the app label Dec 1, 2021
@yunhanw-google yunhanw-google force-pushed the feature/fix_report_on_hold branch 3 times, most recently from e6f663d to ca2ccb0 Compare December 1, 2021 18:05
@yunhanw-google
Optimize report delivery timing for subscribe
feed447 
--Between min and max, only send the report when the handler is dirty
--At max, mHoldSync is unset, server would send the report
@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #12398: Size comparison from 5e2a0a5 to feed447

Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e2a0a5 feed447 change % change
efr32 lighting-app BRD4161A (read only) 726664 726816 152 0.0
.text 726656 726808 152 0.0
BRD4161A+rpc (read only) 755296 755448 152 0.0
.text 755288 755440 152 0.0
lock-app BRD4161A (read only) 700524 700676 152 0.0
.text 700516 700668 152 0.0
window-app BRD4161A (read only) 703620 703772 152 0.0
.text 703612 703764 152 0.0
esp32 all-clusters-app c3devkit (read only) 837356 837418 62 0.0
(read/write) 1224050 1224090 40 0.0
.flash.rodata 166248 166288 40 0.0
.flash.text 837356 837418 62 0.0
m5stack (read only) 908839 908935 96 0.0
(read/write) 423308 423340 32 0.0
.flash.rodata 194100 194132 32 0.0
.flash.text 903455 903551 96 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724524 724624 100 0.0
.text 638112 638212 100 0.0
lock-app k32w061+debug (read/write) 613524 613624 100 0.0
.text 536708 536808 100 0.0
shell k32w061+debug (read/write) 679304 679408 104 0.0
.text 590932 591036 104 0.0
linux all-clusters-app debug (read only) 1781513 1781689 176 0.0
.rodata 139797 139829 32 0.0
.text 1502098 1502242 144 0.0
bridge-app debug+rpc (read only) 1352565 1352741 176 0.0
.rodata 113820 113852 32 0.0
.text 1138533 1138677 144 0.0
chip-tool debug (read only) 6419749 6419925 176 0.0
.rodata 295656 295688 32 0.0
.text 5721125 5721269 144 0.0
lighting-app debug+rpc (read only) 1635673 1635881 208 0.0
.rodata 132785 132849 64 0.0
.text 1364930 1365074 144 0.0
ota-provider-app debug (read only) 1313009 1313185 176 0.0
.rodata 115024 115056 32 0.0
.text 1097538 1097682 144 0.0
ota-requestor-app debug (read only) 1412993 1413153 160 0.0
.rodata 126848 126880 32 0.0
.text 1182258 1182386 128 0.0
tv-app debug (read only) 1927281 1927441 160 0.0
.rodata 161448 161480 32 0.0
.text 1617298 1617426 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2296632 2296736 104 0.0
.text 1259232 1259336 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2281384 2281424 40 0.0
.text 1243984 1244024 40 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2254416 2254520 104 0.0
.text 1217016 1217120 104 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876807 876907 100 0.0
rodata 97368 97404 36 0.0
text 590764 590828 64 0.0
nrf52840dk_nrf52840+rpc (read/write) 839287 839387 100 0.0
rodata 88728 88764 36 0.0
text 564864 564928 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801926 84 0.0
rodata 92628 92664 36 0.0
text 520220 520280 60 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847635 847735 100 0.0
rodata 93108 93144 36 0.0
text 569012 569076 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772990 84 0.0
rodata 88396 88432 36 0.0
text 498560 498620 60 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853679 853779 100 0.0
rodata 94840 94876 36 0.0
text 573080 573140 60 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846743 846843 100 0.0
rodata 92976 93012 36 0.0
text 568140 568200 60 0.0
p6 all-clusters-app default (read/write) 2318040 2318192 152 0.0
.text 1276304 1276456 152 0.0
light-app default (read/write) 2253768 2253920 152 0.0
.text 1212032 1212184 152 0.0
lock-app default (read/write) 2229128 2229280 152 0.0
.text 1187392 1187544 152 0.0
qpg lighting-app qpg6100+debug (read only) 496884 496988 104 0.0
.text 491564 491668 104 0.0
lock-app qpg6100+debug (read only) 469480 469584 104 0.0
.text 464160 464264 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778790 104 0.0
text 541466 541528 62 0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5e2a0a5 feed447 change % change
efr32 lighting-app BRD4161A (read only) 726664 726816 152 0.0
(read/write) 119372 119372 0 0.0
.bss 117564 117564 0 0.0
.data 1808 1808 0 0.0
.text 726656 726808 152 0.0
BRD4161A+rpc (read only) 755296 755448 152 0.0
(read/write) 137684 137684 0 0.0
.bss 135764 135764 0 0.0
.data 1916 1916 0 0.0
.text 755288 755440 152 0.0
lock-app BRD4161A (read only) 700524 700676 152 0.0
(read/write) 117080 117080 0 0.0
.bss 115316 115316 0 0.0
.data 1764 1764 0 0.0
.text 700516 700668 152 0.0
window-app BRD4161A (read only) 703620 703772 152 0.0
(read/write) 117512 117512 0 0.0
.bss 115740 115740 0 0.0
.data 1772 1772 0 0.0
.text 703612 703764 152 0.0
esp32 all-clusters-app c3devkit (read only) 837356 837418 62 0.0
(read/write) 1224050 1224090 40 0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166248 166288 40 0.0
.flash.text 837356 837418 62 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908839 908935 96 0.0
(read/write) 423308 423340 32 0.0
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194100 194132 32 0.0
.flash.text 903455 903551 96 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724524 724624 100 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638112 638212 100 0.0
lock-app k32w061+debug (read/write) 613524 613624 100 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536708 536808 100 0.0
shell k32w061+debug (read/write) 679304 679408 104 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590932 591036 104 0.0
linux all-clusters-app debug (read only) 1781513 1781689 176 0.0
(read/write) 125192 125192 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65728 65728 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139797 139829 32 0.0
.text 1502098 1502242 144 0.0
bridge-app debug+rpc (read only) 1352565 1352741 176 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113820 113852 32 0.0
.text 1138533 1138677 144 0.0
chip-tool debug (read only) 6419749 6419925 176 0.0
(read/write) 197904 197904 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157880 157880 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 295656 295688 32 0.0
.text 5721125 5721269 144 0.0
lighting-app debug+rpc (read only) 1635673 1635881 208 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57040 57040 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132785 132849 64 0.0
.text 1364930 1365074 144 0.0
ota-provider-app debug (read only) 1313009 1313185 176 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115024 115056 32 0.0
.text 1097538 1097682 144 0.0
ota-requestor-app debug (read only) 1412993 1413153 160 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 126848 126880 32 0.0
.text 1182258 1182386 128 0.0
shell debug (read only) 808969 808969 0 0.0
(read/write) 60104 60104 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38528 38528 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79794 79794 0 0.0
.text 623474 623474 0 0.0
tv-app debug (read only) 1927281 1927441 160 0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161448 161480 32 0.0
.text 1617298 1617426 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296632 2296736 104 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259232 1259336 104 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281384 2281424 40 0.0
.bss 172632 172632 0 0.0
.data 5480 5480 0 0.0
.heap 858336 858336 0 0.0
.text 1243984 1244024 40 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254416 2254520 104 0.0
.bss 171448 171448 0 0.0
.data 5472 5472 0 0.0
.heap 859528 859528 0 0.0
.text 1217016 1217120 104 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140000 1140000 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103384 103384 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2045928 2045928 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008528 1008528 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876807 876907 100 0.0
bss 113136 113136 0 0.0
rodata 97368 97404 36 0.0
text 590764 590828 64 0.0
nrf52840dk_nrf52840+rpc (read/write) 839287 839387 100 0.0
bss 109484 109484 0 0.0
rodata 88728 88764 36 0.0
text 564864 564928 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801926 84 0.0
bss 114512 114512 0 0.0
rodata 92628 92664 36 0.0
text 520220 520280 60 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847635 847735 100 0.0
bss 110176 110176 0 0.0
rodata 93108 93144 36 0.0
text 569012 569076 64 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772990 84 0.0
bss 111584 111584 0 0.0
rodata 88396 88432 36 0.0
text 498560 498620 60 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853679 853779 100 0.0
bss 110312 110312 0 0.0
rodata 94840 94876 36 0.0
text 573080 573140 60 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846743 846843 100 0.0
bss 110188 110188 0 0.0
rodata 92976 93012 36 0.0
text 568140 568200 60 0.0
shell nrf52840dk_nrf52840 (read/write) 779227 779227 0 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521888 521888 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694274 694274 0 0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442496 442496 0 0.0
p6 all-clusters-app default (read/write) 2318040 2318192 152 0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276304 1276456 152 0.0
light-app default (read/write) 2253768 2253920 152 0.0
.bss 97752 97752 0 0.0
.data 2320 2320 0 0.0
.heap 933272 933272 0 0.0
.text 1212032 1212184 152 0.0
lock-app default (read/write) 2229128 2229280 152 0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187392 1187544 152 0.0
qpg lighting-app qpg6100+debug (read only) 496884 496988 104 0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491564 491668 104 0.0
lock-app qpg6100+debug (read only) 469480 469584 104 0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464160 464264 104 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778790 104 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541466 541528 62 0.0

@yunhanw-google yunhanw-google merged commit 2072f8e into project-chip:master Dec 1, 2021
@yunhanw-google yunhanw-google mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @yufengwangca @woody-apple @jmartinez-silabs