Implement the client side of timed write. #12567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
|
PR #12567: Size comparison from 21757de to 83d598f Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
fast track: created and approved by domain owner. |
Fixes that had to be made alongside the main change: 1) Fix chip-tool to use the templated WriteAttribute for its command-line writes so we can actually pass in the timeout optional parameter for testing. 2) Factor some code for dealing with timed interactions out of CommandSender into TimedRequest so WriteClient can share it. 3) Fix the OnError signature for WriteClient::Callback to take a StatusIB, so we can properly communicate errors back and actually test for them in YAML.
bzbarsky-apple
force-pushed
the
timed-write-client
branch
from
83d598f to
f9ee0d9
Compare
|
PR #12567: Size comparison from f350919 to f9ee0d9 Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that had to be made alongside the main change:
Fix chip-tool to use the templated WriteAttribute for its
command-line writes so we can actually pass in the timeout optional
parameter for testing.
Factor some code for dealing with timed interactions out of
CommandSender into TimedRequest so WriteClient can share it.
Fix the OnError signature for WriteClient::Callback to take a
StatusIB, so we can properly communicate errors back and actually
test for them in YAML.
Problem
No timed write support.
Change overview
See above.
Testing
New yaml tests testing the functionality.