Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bdx] Extract functions for building and parsing URI and add unit tests #12784

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Functions for building and parsing BDX URI are define in examples or app/clusters code. Hence there are not unit tests for them.

Change overview

Extract and simplify the functions for building and parsing BDX URI.
Add unit tests.

Testing

Unit tests.

src/lib/support/tests/TestSpan.cpp Show resolved Hide resolved
src/protocols/bdx/BdxUri.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12784: Size comparison from 8adecf7 to 1dadd43

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8adecf7 1dadd43 change % change
efr32 lighting-app BRD4161A (read only) 804972 804972 0 0.0
(read/write) 123004 123004 0 0.0
.bss 121184 121184 0 0.0
.data 1820 1820 0 0.0
.text 804964 804964 0 0.0
BRD4161A+rpc (read only) 792608 792608 0 0.0
(read/write) 139688 139688 0 0.0
.bss 137760 137760 0 0.0
.data 1928 1928 0 0.0
.text 792600 792600 0 0.0
window-app BRD4161A (read only) 781716 781716 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 781708 781708 0 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859206 0 0.0
(read/write) 1306722 1306722 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171920 171920 0 0.0
.flash.text 859206 859206 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962539 962539 0 0.0
(read/write) 450988 450988 0 0.0
.dram0.bss 75008 75008 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210144 210144 0 0.0
.flash.text 957155 957155 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 725048 725048 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 636148 636148 0 0.0
lock-app k32w061+debug (read/write) 616208 616208 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 536676 536676 0 0.0
shell k32w061+debug (read/write) 679448 679448 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 590244 590244 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6788732 6788732 0 0.0
(read/write) 312481 312481 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207768 207768 0 0.0
.dynamic 560 560 0 0.0
.got 48400 48400 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342476 342476 0 0.0
.text 5784260 5784260 0 0.0
thermostat-no-ble arm64 (read only) 1931988 1931988 0 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601440 1601440 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320136 2320136 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1282712 1282712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2305992 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1268592 1268592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903659 903659 0 0.0
bss 116184 116184 0 0.0
rodata 101140 101140 0 0.0
text 610788 610788 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866699 866699 0 0.0
bss 112532 112532 0 0.0
rodata 92436 92436 0 0.0
text 585516 585516 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829666 829666 0 0.0
bss 117560 117560 0 0.0
rodata 96396 96396 0 0.0
text 541216 541216 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875935 875935 0 0.0
bss 113448 113448 0 0.0
rodata 97256 97256 0 0.0
text 589844 589844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 802186 802186 0 0.0
bss 114856 114856 0 0.0
rodata 92548 92548 0 0.0
text 520368 520368 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880867 880867 0 0.0
bss 113360 113360 0 0.0
rodata 98612 98612 0 0.0
text 593436 593436 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 874027 874027 0 0.0
bss 113236 113236 0 0.0
rodata 96748 96748 0 0.0
text 588596 588596 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782003 782003 0 0.0
bss 109560 109560 0 0.0
rodata 74256 74256 0 0.0
text 523676 523676 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697082 697082 0 0.0
bss 110540 110540 0 0.0
rodata 68900 68900 0 0.0
text 444320 444320 0 0.0
p6 all-clusters-app default (read/write) 2356168 2356168 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1314432 1314432 0 0.0
light-app default (read/write) 2290448 2290448 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1248712 1248712 0 0.0
lock-app default (read/write) 2266328 2266328 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1224592 1224592 0 0.0
qpg lighting-app qpg6100+debug (read only) 518344 518344 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82632 82632 0 0.0
.data 956 956 0 0.0
.text 513024 513024 0 0.0
lock-app qpg6100+debug (read only) 492336 492336 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81768 81768 0 0.0
.data 912 912 0 0.0
.text 487016 487016 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807494 807494 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 563540 563540 0 0.0

@woody-apple woody-apple merged commit d6dfe03 into project-chip:master Dec 10, 2021
@Damian-Nordic Damian-Nordic deleted the bdx-uri branch December 10, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants