Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix CI test failure #12849

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[hotfix] Fix CI test failure #12849

merged 1 commit into from
Dec 9, 2021

Conversation

mrjerryjohns
Copy link
Contributor

Inadvertently altered a test condition in a previous check-in.

@mrjerryjohns
Fix Test Script
75e9f40 
Inadvertently altered a test condition in a previous check-in.
@mrjerryjohns mrjerryjohns changed the title [hotfix] Fix Test Script [hotfix] Fix CI test failure Dec 9, 2021
mlepage-google
mlepage-google approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mlepage-google mlepage-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I see this cirque test failure in my PR's CI.

@mlepage-google mlepage-google added the hotfix urgent fix needed, can bypass review label Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12849: Size comparison from d9e7e54 to 75e9f40

Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section d9e7e54 75e9f40 change % change
efr32 lighting-app BRD4161A (read only) 807372 807372 0 0.0
(read/write) 123008 123008 0 0.0
.bss 121160 121160 0 0.0
.data 1848 1848 0 0.0
.text 807364 807364 0 0.0
BRD4161A+rpc (read only) 795008 795008 0 0.0
(read/write) 139696 139696 0 0.0
.bss 137736 137736 0 0.0
.data 1956 1956 0 0.0
.text 795000 795000 0 0.0
window-app BRD4161A (read only) 784348 784348 0 0.0
(read/write) 121140 121140 0 0.0
.bss 119328 119328 0 0.0
.data 1812 1812 0 0.0
.text 784340 784340 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668468 668468 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587044 587044 0 0.0
lock-app k32w061+debug (read/write) 618428 618428 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538884 538884 0 0.0
shell k32w061+debug (read/write) 623520 623520 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541776 541776 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6792492 6792492 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749668 5749668 0 0.0
thermostat-no-ble arm64 (read only) 1943060 1943060 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610608 1610608 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323312 2323312 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1285888 1285888 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307944 2307944 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270544 1270544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281056 2281056 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243656 1243656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
p6 all-clusters-app default (read/write) 2360072 2360072 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318336 1318336 0 0.0
light-app default (read/write) 2292872 2292872 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251136 1251136 0 0.0
lock-app default (read/write) 2268936 2268936 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227200 1227200 0 0.0
qpg lighting-app qpg6100+debug (read only) 520260 520260 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 514940 514940 0 0.0
lock-app qpg6100+debug (read only) 494636 494636 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489316 489316 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809658 809658 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565164 565164 0 0.0

@mlepage-google
Copy link
Contributor

Cirque fails with
[PythonMatterControllerTEST] CRITICAL Testfail: Timeout
Is that just a test infra timeout, or something actually timing out (e.g. because something isn't responding, due to a bug)?

@andy31415
Copy link
Contributor

Discussed with Yunhan about cirque passing - apparently both this and #12829 are needed to fix cirque.

@andy31415 andy31415 merged commit 2fb8ee6 into project-chip:master Dec 9, 2021
@andy31415 andy31415 mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@mlepage-google mlepage-google mlepage-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrjerryjohns @mlepage-google @andy31415 @yunhanw-google @yufengwangca