-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network Commissioning] Update NetworkCommissioning Cluster define #12875
Merged
andy31415
merged 10 commits into
project-chip:master
from
erjiaqing:nwprov-final/structs
Dec 13, 2021
Merged
[Network Commissioning] Update NetworkCommissioning Cluster define #12875
andy31415
merged 10 commits into
project-chip:master
from
erjiaqing:nwprov-final/structs
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjiaqing
force-pushed
the
nwprov-final/structs
branch
from
December 10, 2021 09:12
2d2b66a
to
e715e89
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda and
msandstedt
December 10, 2021 09:13
erjiaqing
force-pushed
the
nwprov-final/structs
branch
from
December 13, 2021 02:21
0af7788
to
44c25ac
Compare
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
github
labels
Dec 13, 2021
This PR is focusing on basic renaming, and not the full functions, a refactor of network commissioning cluster is at #12931 |
erjiaqing
force-pushed
the
nwprov-final/structs
branch
2 times, most recently
from
December 13, 2021 05:53
99cf6a4
to
cae26ba
Compare
erjiaqing
force-pushed
the
nwprov-final/structs
branch
from
December 13, 2021 06:31
cae26ba
to
98839a2
Compare
erjiaqing
force-pushed
the
nwprov-final/structs
branch
from
December 13, 2021 06:43
98839a2
to
bf7243f
Compare
PR #12875: Size comparison from f85d6ed to bf7243f Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 13, 2021
PR #12875: Size comparison from 73776ef to 6007689 Increases above 0.2%:
Increases (8 builds for k32w, linux, qpg, telink)
Decreases (8 builds for k32w, linux, qpg, telink)
Full report (9 builds for k32w, linux, qpg, telink)
|
PR #12875: Size comparison from 73776ef to 6eb1b13 Increases above 0.2%:
Increases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
app
controller
documentation
Improvements or additions to documentation
examples
github
review - approved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing