Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy unused declarations #13039

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Cleanup legacy unused declarations #13039

merged 1 commit into from
Dec 15, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Those code is not used at all, seems inherited from Weave

Change overview

Cleanup legacy unused declarations

Testing

How was this tested? (at least one bullet point required)

  • Cleanup only

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13039: Size comparison from 8f15eea to b61d545

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f15eea b61d545 change % change
efr32 lighting-app BRD4161A (read only) 836648 836648 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 836640 836640 0 0.0
BRD4161A+rpc (read only) 824236 824236 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 824228 824228 0 0.0
window-app BRD4161A (read only) 813872 813872 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813864 813864 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688692 688692 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601648 601648 0 0.0
lock-app k32w061+debug (read/write) 638616 638616 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553460 553460 0 0.0
shell k32w061+debug (read/write) 644020 644020 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556576 556576 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6978884 6978884 0 0.0
(read/write) 324593 324593 0 0.0
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 55512 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376292 376292 0 0.0
.text 5916548 5916548 0 0.0
thermostat-no-ble arm64 (read only) 2007996 2007996 0 0.0
(read/write) 145281 145281 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1668448 1668448 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336048 2336048 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1298624 1298624 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331592 2331592 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1294192 1294192 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304648 2304648 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1267248 1267248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924271 924271 0 0.0
bss 119852 119852 0 0.0
rodata 103616 103616 0 0.0
text 625200 625200 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 887311 887311 0 0.0
bss 116200 116200 0 0.0
rodata 94912 94912 0 0.0
text 599940 599940 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850286 850286 0 0.0
bss 121224 121224 0 0.0
rodata 98872 98872 0 0.0
text 555640 555640 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 899011 899011 0 0.0
bss 119028 119028 0 0.0
rodata 99732 99732 0 0.0
text 604844 604844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825270 825270 0 0.0
bss 120440 120440 0 0.0
rodata 95024 95024 0 0.0
text 535372 535372 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903967 903967 0 0.0
bss 118940 118940 0 0.0
rodata 101088 101088 0 0.0
text 608444 608444 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 897207 897207 0 0.0
bss 118820 118820 0 0.0
rodata 99224 99224 0 0.0
text 603644 603644 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2390680 2390680 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1348944 1348944 0 0.0
light-app default (read/write) 2330968 2330968 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1289232 1289232 0 0.0
lock-app default (read/write) 2307032 2307032 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1265296 1265296 0 0.0
qpg lighting-app qpg6105+debug (read only) 533384 533384 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 528064 528064 0 0.0
lock-app qpg6105+debug (read only) 507752 507752 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502432 502432 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833650 833650 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581342 581342 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13039: Size comparison from 89aff25 to ef8a5da

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 89aff25 ef8a5dac change % change
efr32 lighting-app BRD4161A (read only) 840592 840592 0 0.0
(read/write) 128640 128640 0 0.0
.bss 126760 126760 0 0.0
.data 1876 1876 0 0.0
.text 840584 840584 0 0.0
BRD4161A+rpc (read only) 828196 828196 0 0.0
(read/write) 145312 145312 0 0.0
.bss 143336 143336 0 0.0
.data 1976 1976 0 0.0
.text 828188 828188 0 0.0
window-app BRD4161A (read only) 813968 813968 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813960 813960 0 0.0
esp32 all-clusters-app c3devkit (read only) 880138 880138 0 0.0
(read/write) 1314250 1314250 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 175912 175912 0 0.0
.flash.text 880138 880138 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 967871 967871 0 0.0
(read/write) 455512 455512 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 212116 212116 0 0.0
.flash.text 962487 962487 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 691148 691148 0 0.0
.bss 79344 79344 0 0.0
.data 1908 1908 0 0.0
.text 604096 604096 0 0.0
lock-app k32w061+debug (read/write) 638712 638712 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553556 553556 0 0.0
shell k32w061+debug (read/write) 644100 644100 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556656 556656 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6979836 6979836 0 0.0
(read/write) 324609 324609 0 0.0
.bss 55905 55905 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55520 55520 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376348 376348 0 0.0
.text 5917428 5917428 0 0.0
thermostat-no-ble arm64 (read only) 2008724 2008724 0 0.0
(read/write) 145297 145297 0 0.0
.bss 65649 65649 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128068 128068 0 0.0
.text 1669120 1669120 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338816 2338816 0 0.0
.bss 190332 190332 0 0.0
.data 5256 5256 0 0.0
.heap 840856 840856 0 0.0
.text 1301392 1301392 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334320 2334320 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1296920 1296920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307416 2307416 0 0.0
.bss 181232 181232 0 0.0
.data 5536 5536 0 0.0
.heap 849680 849680 0 0.0
.text 1270016 1270016 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 927055 927055 0 0.0
bss 119852 119852 0 0.0
rodata 104424 104424 0 0.0
text 627160 627160 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 890095 890095 0 0.0
bss 116204 116204 0 0.0
rodata 95720 95720 0 0.0
text 601900 601900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853062 853062 0 0.0
bss 121228 121228 0 0.0
rodata 99680 99680 0 0.0
text 557600 557600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 899107 899107 0 0.0
bss 119032 119032 0 0.0
rodata 99732 99732 0 0.0
text 604928 604928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825366 825366 0 0.0
bss 120440 120440 0 0.0
rodata 95024 95024 0 0.0
text 535460 535460 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 904047 904047 0 0.0
bss 118944 118944 0 0.0
rodata 101088 101088 0 0.0
text 608532 608532 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 897287 897287 0 0.0
bss 118824 118824 0 0.0
rodata 99224 99224 0 0.0
text 603728 603728 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2394600 2394600 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1352864 1352864 0 0.0
light-app default (read/write) 2334912 2334912 0 0.0
.bss 107448 107448 0 0.0
.data 2384 2384 0 0.0
.heap 923512 923512 0 0.0
.text 1293176 1293176 0 0.0
lock-app default (read/write) 2307128 2307128 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1265392 1265392 0 0.0
qpg lighting-app qpg6105+debug (read only) 536144 536144 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 1004 1004 0 0.0
.text 530824 530824 0 0.0
lock-app qpg6105+debug (read only) 507832 507832 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502512 502512 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836574 836574 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 583428 583428 0 0.0

@yufengwangca yufengwangca merged commit 4d58cb4 into project-chip:master Dec 15, 2021
@yufengwangca yufengwangca deleted the pr/interface/cleanup branch December 16, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @msandstedt @kpschoedel