Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cats to subject descriptor #13384

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Add cats to subject descriptor #13384

merged 1 commit into from
Jan 7, 2022

Conversation

mlepage-google
Copy link
Contributor

Meow.

Problem

CASE authenticated tags not yet set in subject descriptor.

#10243

Change overview

Set CASE authenticated tags in subject descriptor.

Testing

  • Built (all-clusters-app, REPL) on Linux, ran
  • Forced set of CAT in session, and forced matching ACL entry in cluster
  • Checked log statements to ensure read was allowed/denied accordingly

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

PR #13384: Size comparison from 585cdcb to e188cfb

Increases (6 builds for k32w, linux, qpg, telink)
platform target config section 585cdcb e188cfb change % change
k32w lock k32w061+release (read/write) 659584 659600 16 0.0
.text 574844 574860 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7039468 7039484 16 0.0
.text 5961492 5961508 16 0.0
thermostat-no-ble arm64 (read only) 2033468 2033484 16 0.0
.text 1690800 1690816 16 0.0
qpg lighting-app qpg6105+debug (read only) 533160 533176 16 0.0
.text 527840 527856 16 0.0
lock-app qpg6105+debug (read only) 504936 504952 16 0.0
.text 499616 499632 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834466 834474 8 0.0
text 582710 582724 14 0.0
Full report (8 builds for k32w, linux, qpg, telink)
platform target config section 585cdcb e188cfb change % change
k32w light k32w061+release (read/write) 655308 655308 0 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570884 570884 0 0.0
lock k32w061+release (read/write) 659584 659600 16 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574844 574860 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7039468 7039484 16 0.0
(read/write) 325985 325985 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209296 209296 0 0.0
.dynamic 560 560 0 0.0
.got 57040 57040 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384404 384404 0 0.0
.text 5961492 5961508 16 0.0
thermostat-no-ble arm64 (read only) 2033468 2033484 16 0.0
(read/write) 145105 145105 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72624 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 128988 0 0.0
.text 1690800 1690816 16 0.0
qpg lighting-app qpg6105+debug (read only) 533160 533176 16 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527840 527856 16 0.0
lock-app qpg6105+debug (read only) 504936 504952 16 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499616 499632 16 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834466 834474 8 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582710 582724 14 0.0

@andy31415
Copy link
Contributor

/rebase

@andy31415
Copy link
Contributor

🐱

@andy31415
Copy link
Contributor

fast track: trivial change and 🐱

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

PR #13384: Size comparison from c25c4b3 to 45f7e8c

Increases (24 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c25c4b3 45f7e8c change % change
efr32 lighting-app BRD4161A (read only) 829196 829212 16 0.0
.text 829188 829204 16 0.0
BRD4161A+rpc (read only) 816840 816856 16 0.0
.text 816832 816848 16 0.0
window-app BRD4161A (read only) 802660 802676 16 0.0
.text 802652 802668 16 0.0
esp32 all-clusters-app c3devkit (read only) 891834 891856 22 0.0
.flash.text 891834 891856 22 0.0
m5stack (read only) 951779 951787 8 0.0
.flash.text 946395 946403 8 0.0
k32w lock k32w061+release (read/write) 659584 659600 16 0.0
.text 574844 574860 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7039660 7039676 16 0.0
.text 5961684 5961700 16 0.0
thermostat-no-ble arm64 (read only) 2033708 2033724 16 0.0
.text 1691040 1691056 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348496 2348560 64 0.0
.text 1311072 1311136 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937083 937099 16 0.0
text 633292 633308 16 0.0
nrf52840dk_nrf52840+rpc (read/write) 923479 923495 16 0.0
text 628604 628620 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848062 848078 16 0.0
text 550228 550240 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909227 909243 16 0.0
text 611160 611172 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820386 820402 16 0.0
text 528132 528148 16 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910491 910507 16 0.0
text 612372 612388 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907307 907323 16 0.0
text 609908 609920 12 0.0
shell nrf52840dk_nrf52840 (read/write) 797919 797935 16 0.0
text 533496 533508 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710734 710750 16 0.0
text 451172 451188 16 0.0
p6 all-clusters-app default (read/write) 2401624 2401640 16 0.0
.text 1359888 1359904 16 0.0
light-app default (read/write) 2323648 2323664 16 0.0
.text 1281912 1281928 16 0.0
lock-app default (read/write) 2295872 2295888 16 0.0
.text 1254136 1254152 16 0.0
qpg lighting-app qpg6105+debug (read only) 533160 533176 16 0.0
.text 527840 527856 16 0.0
lock-app qpg6105+debug (read only) 504936 504952 16 0.0
.text 499616 499632 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 834466 834474 8 0.0
text 582710 582724 14 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c25c4b3 45f7e8c change % change
efr32 lighting-app BRD4161A (read only) 829196 829212 16 0.0
(read/write) 126996 126996 0 0.0
.bss 125120 125120 0 0.0
.data 1876 1876 0 0.0
.text 829188 829204 16 0.0
BRD4161A+rpc (read only) 816840 816856 16 0.0
(read/write) 143656 143656 0 0.0
.bss 141680 141680 0 0.0
.data 1976 1976 0 0.0
.text 816832 816848 16 0.0
window-app BRD4161A (read only) 802660 802676 16 0.0
(read/write) 125936 125936 0 0.0
.bss 124104 124104 0 0.0
.data 1832 1832 0 0.0
.text 802652 802668 16 0.0
esp32 all-clusters-app c3devkit (read only) 891834 891856 22 0.0
(read/write) 1314010 1314010 0 0.0
.dram0.bss 69464 69464 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177248 177248 0 0.0
.flash.text 891834 891856 22 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 951779 951787 8 0.0
(read/write) 445592 445592 0 0.0
.dram0.bss 73960 73960 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206560 206560 0 0.0
.flash.text 946395 946403 8 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655308 655308 0 0.0
.bss 76776 76776 0 0.0
.data 1848 1848 0 0.0
.text 570884 570884 0 0.0
lock k32w061+release (read/write) 659584 659600 16 0.0
.bss 77072 77072 0 0.0
.data 1868 1868 0 0.0
.text 574844 574860 16 0.0
linux chip-tool-ipv6only arm64 (read only) 7039660 7039676 16 0.0
(read/write) 325985 325985 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209296 209296 0 0.0
.dynamic 560 560 0 0.0
.got 57040 57040 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 384404 384404 0 0.0
.text 5961684 5961700 16 0.0
thermostat-no-ble arm64 (read only) 2033708 2033724 16 0.0
(read/write) 145105 145105 0 0.0
.bss 64657 64657 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72624 0 0.0
.dynamic 560 560 0 0.0
.got 4008 4008 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 128988 0 0.0
.text 1691040 1691056 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348496 2348560 64 0.0
.bss 188724 188724 0 0.0
.data 5312 5312 0 0.0
.text 1311072 1311136 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330688 2330688 0 0.0
.bss 180544 180544 0 0.0
.data 5552 5552 0 0.0
.text 1293288 1293288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303840 2303840 0 0.0
.bss 179592 179592 0 0.0
.data 5544 5544 0 0.0
.text 1266440 1266440 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937083 937099 16 0.0
bss 118112 118112 0 0.0
rodata 108120 108120 0 0.0
text 633292 633308 16 0.0
nrf52840dk_nrf52840+rpc (read/write) 923479 923495 16 0.0
bss 115156 115156 0 0.0
rodata 101548 101548 0 0.0
text 628604 628620 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848062 848078 16 0.0
bss 116004 116004 0 0.0
rodata 101296 101296 0 0.0
text 550228 550240 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 909227 909243 16 0.0
bss 117300 117300 0 0.0
rodata 103392 103392 0 0.0
text 611160 611172 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820386 820402 16 0.0
bss 115220 115220 0 0.0
rodata 96620 96620 0 0.0
text 528132 528148 16 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910491 910507 16 0.0
bss 117060 117060 0 0.0
rodata 103608 103608 0 0.0
text 612372 612388 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 907307 907323 16 0.0
bss 117088 117088 0 0.0
rodata 102864 102864 0 0.0
text 609908 609920 12 0.0
shell nrf52840dk_nrf52840 (read/write) 797919 797935 16 0.0
bss 109768 109768 0 0.0
rodata 78148 78148 0 0.0
text 533496 533508 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710734 710750 16 0.0
bss 107656 107656 0 0.0
rodata 72448 72448 0 0.0
text 451172 451188 16 0.0
p6 all-clusters-app default (read/write) 2401624 2401640 16 0.0
.bss 116804 116804 0 0.0
.data 2592 2592 0 0.0
.text 1359888 1359904 16 0.0
light-app default (read/write) 2323648 2323664 16 0.0
.bss 105672 105672 0 0.0
.data 2384 2384 0 0.0
.text 1281912 1281928 16 0.0
lock-app default (read/write) 2295872 2295888 16 0.0
.bss 104552 104552 0 0.0
.data 2336 2336 0 0.0
.text 1254136 1254152 16 0.0
qpg lighting-app qpg6105+debug (read only) 533160 533176 16 0.0
(read/write) 146936 146936 0 0.0
.bss 86624 86624 0 0.0
.data 1004 1004 0 0.0
.text 527840 527856 16 0.0
lock-app qpg6105+debug (read only) 504936 504952 16 0.0
(read/write) 146940 146940 0 0.0
.bss 85760 85760 0 0.0
.data 952 952 0 0.0
.text 499616 499632 16 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834466 834474 8 0.0
bss 86924 86924 0 0.0
noinit 37160 37160 0 0.0
text 582710 582724 14 0.0

@andy31415 andy31415 merged commit d6db458 into project-chip:master Jan 7, 2022
@mlepage-google mlepage-google deleted the subject-descriptor-cats branch January 12, 2022 15:52
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@mlepage-google @step0035
Add cats to subject descriptor (project-chip#13384)
ea846c1 
Meow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emargolis emargolis emargolis approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlepage-google @andy31415 @emargolis