CommissioneeDeviceProxy fix. #13482
Merged
CommissioneeDeviceProxy fix. #13482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a review comment fix, but the logic is not correct due to an early exit on the load function. This didn't show up when testing because the python tool caches the proxy and doesn't need to re-look up the pairing.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #13482: Size comparison from aaa7ad0 to 26dc92b Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 12, 2022
|
fast track: fix of a fix, very small delta. |
|
@cecille It would have been nice to add a comment explaining the ordering dependency, which is non-obvious from reading the caller. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
Added a review comment fix, but the logic is not correct due to an early exit on the load function. This didn't show up when testing because the python tool caches the proxy and doesn't need to re-look up the pairing.
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Added a review comment fix, but the logic is not correct due to an early exit on the load function. This didn't show up when testing because the python tool caches the proxy and doesn't need to re-look up the pairing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Added a review comment fix, but the logic is not correct due to an
early exit on the load function. This didn't show up when testing
because the python tool caches the proxy and doesn't need to re-look
up the pairing.
Change overview
move state change back to earlier in the function so the load parameters call doesn't bail early.
Testing
Tested by Kevin C using java impl - pase then command