Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. #13521

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. #13521

merged 1 commit into from
Jan 13, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

It's only written, never read.

The emberAfReadSequentialAttributesAddToResponse function that was one
of the writers is unused, so removing that too.

Problem

Dead code.

Change overview

Remove dead code.

Testing

No behavior changes.

@boring-cyborg boring-cyborg bot added the app label Jan 13, 2022
@restyled-io restyled-io bot mentioned this pull request Jan 13, 2022
Closed
@bzbarsky-apple
Remove unused manufacturerCode field of EmberAfAttributeSearchRecord.
8813435 
It's only written, never read.

The emberAfReadSequentialAttributesAddToResponse function that was one
of the writers is unused, so removing that too.
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13521: Size comparison from 8093b77 to 8813435

Increases (1 build for esp32)
platform target config section 8093b77 8813435 change % change
esp32 all-clusters-app m5stack (read only) 957159 957207 48 0.0
.flash.text 951775 951823 48 0.0
Decreases (24 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8093b77 8813435 change % change
efr32 lighting-app BRD4161A (read only) 831200 831168 -32 -0.0
.text 831192 831160 -32 -0.0
BRD4161A+rpc (read only) 818604 818556 -48 -0.0
.text 818596 818548 -48 -0.0
window-app BRD4161A (read only) 805096 805048 -48 -0.0
.text 805088 805040 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 908440 908420 -20 -0.0
.flash.text 908440 908420 -20 -0.0
k32w light k32w061+release (read/write) 656952 656920 -32 -0.0
.text 572476 572444 -32 -0.0
lock k32w061+release (read/write) 661252 661204 -48 -0.0
.text 576460 576412 -48 -0.0
linux chip-tool-ipv6only arm64 (read only) 7215212 7215132 -80 -0.0
.text 6089508 6089428 -80 -0.0
thermostat-no-ble arm64 (read only) 2039628 2039564 -64 -0.0
.text 1695312 1695248 -64 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2346192 2346128 -64 -0.0
.text 1308768 1308704 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304384 2304320 -64 -0.0
.text 1266984 1266920 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939923 939891 -32 -0.0
text 634532 634496 -36 -0.0
nrf52840dk_nrf52840+rpc (read/write) 925387 925355 -32 -0.0
text 629884 629848 -36 -0.0
nrf52840dongle_nrf52840 (read/write) 990599 990567 -32 -0.0
text 666728 666692 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849778 849746 -32 -0.0
text 551452 551412 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912195 912163 -32 -0.0
text 612524 612488 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822230 822198 -32 -0.0
text 529484 529444 -40 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 913487 913455 -32 -0.0
text 613784 613748 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910275 910259 -16 -0.0
text 611272 611244 -28 -0.0
p6 all-clusters-app default (read/write) 2400272 2400240 -32 -0.0
.text 1358536 1358504 -32 -0.0
light-app default (read/write) 2325968 2325936 -32 -0.0
.text 1284232 1284200 -32 -0.0
lock-app default (read/write) 2298200 2298152 -48 -0.0
.text 1256464 1256416 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 535004 534956 -48 -0.0
.text 529684 529636 -48 -0.0
lock-app qpg6105+debug (read only) 506908 506876 -32 -0.0
.text 501588 501556 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 836510 836494 -16 -0.0
text 584166 584146 -20 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8093b77 8813435 change % change
efr32 lighting-app BRD4161A (read only) 831200 831168 -32 -0.0
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 831192 831160 -32 -0.0
BRD4161A+rpc (read only) 818604 818556 -48 -0.0
(read/write) 143960 143960 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 818596 818548 -48 -0.0
window-app BRD4161A (read only) 805096 805048 -48 -0.0
(read/write) 126008 126008 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 805088 805040 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 908440 908420 -20 -0.0
(read/write) 1316058 1316058 0 0.0
.dram0.bss 70176 70176 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178112 178112 0 0.0
.flash.text 908440 908420 -20 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 957159 957207 48 0.0
(read/write) 448216 448216 0 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207384 207384 0 0.0
.flash.text 951775 951823 48 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656952 656920 -32 -0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572476 572444 -32 -0.0
lock k32w061+release (read/write) 661252 661204 -48 -0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576460 576412 -48 -0.0
linux chip-tool-ipv6only arm64 (read only) 7215212 7215132 -80 -0.0
(read/write) 345921 345921 0 0.0
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 227824 227824 0 0.0
.dynamic 560 560 0 0.0
.got 58440 58440 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392436 392436 0 0.0
.text 6089508 6089428 -80 -0.0
thermostat-no-ble arm64 (read only) 2039628 2039564 -64 -0.0
(read/write) 145617 145617 0 0.0
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129756 129756 0 0.0
.text 1695312 1695248 -64 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346192 2346128 -64 -0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1308768 1308704 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331160 2331160 0 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293760 1293760 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304384 2304320 -64 -0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266984 1266920 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054392 2054392 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016992 1016992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939923 939891 -32 -0.0
bss 119284 119284 0 0.0
rodata 108544 108544 0 0.0
text 634532 634496 -36 -0.0
nrf52840dk_nrf52840+rpc (read/write) 925387 925355 -32 -0.0
bss 116328 116328 0 0.0
rodata 100992 100992 0 0.0
text 629884 629848 -36 -0.0
nrf52840dongle_nrf52840 (read/write) 990599 990567 -32 -0.0
bss 122128 122128 0 0.0
rodata 113296 113296 0 0.0
text 666728 666692 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849778 849746 -32 -0.0
bss 116072 116072 0 0.0
rodata 101716 101716 0 0.0
text 551452 551412 -40 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 912195 912163 -32 -0.0
bss 118472 118472 0 0.0
rodata 103816 103816 0 0.0
text 612524 612488 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822230 822198 -32 -0.0
bss 115288 115288 0 0.0
rodata 97040 97040 0 0.0
text 529484 529444 -40 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913487 913455 -32 -0.0
bss 118232 118232 0 0.0
rodata 104028 104028 0 0.0
text 613784 613748 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910275 910259 -16 -0.0
bss 118260 118260 0 0.0
rodata 103288 103288 0 0.0
text 611272 611244 -28 -0.0
shell nrf52840dk_nrf52840 (read/write) 798627 798627 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533968 533968 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711446 711446 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451648 451648 0 0.0
p6 all-clusters-app default (read/write) 2400272 2400240 -32 -0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1358536 1358504 -32 -0.0
light-app default (read/write) 2325968 2325936 -32 -0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1284232 1284200 -32 -0.0
lock-app default (read/write) 2298200 2298152 -48 -0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1256464 1256416 -48 -0.0
qpg lighting-app qpg6105+debug (read only) 535004 534956 -48 -0.0
(read/write) 146940 146940 0 0.0
.bss 89024 89024 0 0.0
.data 1008 1008 0 0.0
.text 529684 529636 -48 -0.0
lock-app qpg6105+debug (read only) 506908 506876 -32 -0.0
(read/write) 146936 146936 0 0.0
.bss 88160 88160 0 0.0
.data 956 956 0 0.0
.text 501588 501556 -32 -0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836510 836494 -16 -0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 584166 584146 -20 -0.0

@woody-apple woody-apple merged commit c4dd942 into project-chip:master Jan 13, 2022
@bzbarsky-apple bzbarsky-apple deleted the nix-mfg-code-search-record branch January 13, 2022 17:27
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@bzbarsky-apple @selissia
Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. (…
cc9ab3f 
…project-chip#13521)

It's only written, never read.

The emberAfReadSequentialAttributesAddToResponse function that was one
of the writers is unused, so removing that too.
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@bzbarsky-apple @step0035
Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. (…
55f43be 
…project-chip#13521)

It's only written, never read.

The emberAfReadSequentialAttributesAddToResponse function that was one
of the writers is unused, so removing that too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@woody-apple woody-apple woody-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @msandstedt @woody-apple @Damian-Nordic