Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op Certs Generation: Support CASE Authenticated Tags and other Attributes #13737

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Op Certs Generation: Support CASE Authenticated Tags and other Attributes #13737

merged 1 commit into from
Jan 26, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Currently implemented code only supports NodeId and FabricId DN attributes.

Ticket: #6435

Change overview

  • Added support for the subject and issuer DNs in the X509CertRequestParams structure.
  • Factored out ChipDN encoding and decoding into separate functions.
  • Other updates and cleanups.

Testing

Unit tests and top level tests that use OpCert generation.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR #13737: Size comparison from 7f766c6 to 32a5091

Increases (23 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7f766c6 32a5091 change % change
esp32 all-clusters-app c3devkit (read only) 912642 912804 162 0.0
.flash.text 912642 912804 162 0.0
m5stack (read only) 961407 961515 108 0.0
.flash.text 956023 956131 108 0.0
k32w light k32w061+release (read/write) 659076 659188 112 0.0
.text 574280 574392 112 0.0
lock k32w061+release (read/write) 661856 661968 112 0.0
.text 576744 576856 112 0.0
linux chip-tool-ipv6only arm64 (read only) 8141292 8141708 416 0.0
.text 6920340 6920756 416 0.0
thermostat-no-ble arm64 (read only) 2044092 2044844 752 0.0
(read/write) 145905 145937 32 0.0
.data.rel.ro 72952 72976 24 0.0
.text 1699808 1700528 720 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2350368 2350432 64 0.0
.text 1312944 1313008 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2334568 2334696 128 0.0
.text 1297168 1297296 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304920 2305048 128 0.0
.text 1267520 1267648 128 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943427 943539 112 0.0
text 637448 637560 112 0.0
nrf52840dk_nrf52840+rpc (read/write) 928895 929007 112 0.0
text 632840 632952 112 0.0
nrf52840dongle_nrf52840 (read/write) 994107 994219 112 0.0
text 669644 669756 112 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853254 853366 112 0.0
text 554368 554480 112 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912787 912899 112 0.0
text 612896 613008 112 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822842 822954 112 0.0
text 529852 529964 112 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915639 915751 112 0.0
text 615544 615656 112 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910723 910835 112 0.0
text 611472 611584 112 0.0
p6 all-clusters-app default (read/write) 2405904 2406080 176 0.0
.text 1364168 1364344 176 0.0
light-app default (read/write) 2330024 2330200 176 0.0
.text 1288288 1288464 176 0.0
lock-app default (read/write) 2299048 2299224 176 0.0
.text 1257312 1257488 176 0.0
qpg lighting-app qpg6105+debug (read only) 565128 565240 112 0.0
.text 559808 559920 112 0.0
lock-app qpg6105+debug (read only) 515540 515652 112 0.0
.text 510220 510332 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 840802 840962 160 0.0
text 587822 587982 160 0.0
Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7f766c6 32a5091 change % change
esp32 all-clusters-app c3devkit (read only) 912642 912804 162 0.0
(read/write) 1316642 1316642 0 0.0
.dram0.bss 70568 70568 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 178344 178344 0 0.0
.flash.text 912642 912804 162 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 961407 961515 108 0.0
(read/write) 448792 448792 0 0.0
.dram0.bss 75024 75024 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 207616 207616 0 0.0
.flash.text 956023 956131 108 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659076 659188 112 0.0
.bss 77136 77136 0 0.0
.data 1860 1860 0 0.0
.text 574280 574392 112 0.0
lock k32w061+release (read/write) 661856 661968 112 0.0
.bss 77432 77432 0 0.0
.data 1880 1880 0 0.0
.text 576744 576856 112 0.0
linux chip-tool-ipv6only arm64 (read only) 8141292 8141708 416 0.0
(read/write) 374497 374497 0 0.0
.bss 55345 55345 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 248800 248800 0 0.0
.dynamic 560 560 0 0.0
.got 65512 65512 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 422692 422692 0 0.0
.text 6920340 6920756 416 0.0
thermostat-no-ble arm64 (read only) 2044092 2044844 752 0.0
(read/write) 145905 145937 32 0.0
.bss 65089 65089 0 0.0
.data 896 896 0 0.0
.data.rel.ro 72952 72976 24 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129916 129916 0 0.0
.text 1699808 1700528 720 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350368 2350432 64 0.0
.bss 189260 189260 0 0.0
.data 5288 5288 0 0.0
.text 1312944 1313008 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334696 128 0.0
.bss 180760 180760 0 0.0
.data 5576 5576 0 0.0
.text 1297168 1297296 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304920 2305048 128 0.0
.bss 179768 179768 0 0.0
.data 5552 5552 0 0.0
.text 1267520 1267648 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943427 943539 112 0.0
bss 119628 119628 0 0.0
rodata 108760 108760 0 0.0
text 637448 637560 112 0.0
nrf52840dk_nrf52840+rpc (read/write) 928895 929007 112 0.0
bss 116672 116672 0 0.0
rodata 101212 101212 0 0.0
text 632840 632952 112 0.0
nrf52840dongle_nrf52840 (read/write) 994107 994219 112 0.0
bss 122472 122472 0 0.0
rodata 113516 113516 0 0.0
text 669644 669756 112 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853254 853366 112 0.0
bss 116416 116416 0 0.0
rodata 101936 101936 0 0.0
text 554368 554480 112 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912787 912899 112 0.0
bss 118784 118784 0 0.0
rodata 103728 103728 0 0.0
text 612896 613008 112 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822842 822954 112 0.0
bss 115600 115600 0 0.0
rodata 96956 96956 0 0.0
text 529852 529964 112 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915639 915751 112 0.0
bss 118548 118548 0 0.0
rodata 104092 104092 0 0.0
text 615544 615656 112 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910723 910835 112 0.0
bss 118572 118572 0 0.0
rodata 103200 103200 0 0.0
text 611472 611584 112 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2405904 2406080 176 0.0
.bss 117596 117596 0 0.0
.data 2568 2568 0 0.0
.text 1364168 1364344 176 0.0
light-app default (read/write) 2330024 2330200 176 0.0
.bss 106128 106128 0 0.0
.data 2400 2400 0 0.0
.text 1288288 1288464 176 0.0
lock-app default (read/write) 2299048 2299224 176 0.0
.bss 104976 104976 0 0.0
.data 2352 2352 0 0.0
.text 1257312 1257488 176 0.0
qpg lighting-app qpg6105+debug (read only) 565128 565240 112 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1056 1056 0 0.0
.text 559808 559920 112 0.0
lock-app qpg6105+debug (read only) 515540 515652 112 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 980 980 0 0.0
.text 510220 510332 112 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840802 840962 160 0.0
bss 87316 87316 0 0.0
noinit 37160 37160 0 0.0
text 587822 587982 160 0.0

@emargolis emargolis force-pushed the emargolis/feature/generate-x509-cert branch from 32a5091 to ad83f5c Compare January 20, 2022 22:51
@emargolis emargolis force-pushed the emargolis/feature/generate-x509-cert branch from ad83f5c to 2652468 Compare January 20, 2022 23:09
@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13737: Size comparison from d9b77e9 to 2652468

Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d9b77e9 2652468 change % change
efr32 lighting-app BRD4161A (read only) 833628 833804 176 0.0
.text 833620 833796 176 0.0
BRD4161A+rpc (read only) 821024 821200 176 0.0
.text 821016 821192 176 0.0
window-app BRD4161A (read only) 804212 804372 160 0.0
.text 804204 804364 160 0.0
k32w light k32w061+release (read/write) 658924 659036 112 0.0
.text 574676 574788 112 0.0
lock k32w061+release (read/write) 659704 659816 112 0.0
.text 575196 575308 112 0.0
linux chip-tool-ipv6only arm64 (read only) 8428284 8428700 416 0.0
.text 7160228 7160644 416 0.0
thermostat-no-ble arm64 (read only) 2043324 2044060 736 0.0
(read/write) 145425 145441 16 0.0
.data.rel.ro 72752 72776 24 0.0
.text 1699136 1699856 720 0.0
p6 all-clusters-app default (read/write) 2407720 2407896 176 0.0
.text 1365984 1366160 176 0.0
light-app default (read/write) 2328696 2328872 176 0.0
.text 1286960 1287136 176 0.0
lock-app default (read/write) 2297704 2297880 176 0.0
.text 1255968 1256144 176 0.0
qpg lighting-app qpg6105+debug (read only) 565840 565952 112 0.0
.text 560520 560632 112 0.0
lock-app qpg6105+debug (read only) 514328 514440 112 0.0
.text 509008 509120 112 0.0
telink lighting-app tlsr9518adk80d (read/write) 839890 840050 160 0.0
text 586972 587132 160 0.0
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d9b77e9 2652468 change % change
efr32 lighting-app BRD4161A (read only) 833628 833804 176 0.0
(read/write) 127216 127216 0 0.0
.bss 125320 125320 0 0.0
.data 1896 1896 0 0.0
.text 833620 833796 176 0.0
BRD4161A+rpc (read only) 821024 821200 176 0.0
(read/write) 143880 143880 0 0.0
.bss 141880 141880 0 0.0
.data 1996 1996 0 0.0
.text 821016 821192 176 0.0
window-app BRD4161A (read only) 804212 804372 160 0.0
(read/write) 125792 125792 0 0.0
.bss 123944 123944 0 0.0
.data 1848 1848 0 0.0
.text 804204 804364 160 0.0
k32w light k32w061+release (read/write) 658924 659036 112 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574788 112 0.0
lock k32w061+release (read/write) 659704 659816 112 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575308 112 0.0
linux chip-tool-ipv6only arm64 (read only) 8428284 8428700 416 0.0
(read/write) 388769 388769 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 259416 259416 0 0.0
.dynamic 560 560 0 0.0
.got 68424 68424 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 434308 434308 0 0.0
.text 7160228 7160644 416 0.0
thermostat-no-ble arm64 (read only) 2043324 2044060 736 0.0
(read/write) 145425 145441 16 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72776 24 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699856 720 0.0
p6 all-clusters-app default (read/write) 2407720 2407896 176 0.0
.bss 117772 117772 0 0.0
.data 2584 2584 0 0.0
.text 1365984 1366160 176 0.0
light-app default (read/write) 2328696 2328872 176 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1287136 176 0.0
lock-app default (read/write) 2297704 2297880 176 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1256144 176 0.0
qpg lighting-app qpg6105+debug (read only) 565840 565952 112 0.0
(read/write) 146936 146936 0 0.0
.bss 89664 89664 0 0.0
.data 1060 1060 0 0.0
.text 560520 560632 112 0.0
lock-app qpg6105+debug (read only) 514328 514440 112 0.0
(read/write) 146940 146940 0 0.0
.bss 88232 88232 0 0.0
.data 984 984 0 0.0
.text 509008 509120 112 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839890 840050 160 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586972 587132 160 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 21, 2022
View reviewed changes
src/credentials/CHIPCert.cpp Outdated Show resolved Hide resolved
src/credentials/CHIPCert.h Show resolved Hide resolved
src/credentials/CHIPCert.cpp Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPOperationalCredentialsDelegate.mm Show resolved Hide resolved
@emargolis
Copy link
Contributor Author

PTAL

@emargolis emargolis force-pushed the emargolis/feature/generate-x509-cert branch from 23afea0 to ba5faad Compare January 25, 2022 06:55
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13737: Size comparison from d21dbff to ba5faad

Increases (25 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section d21dbff ba5faad change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573838 124 0.0
.app_xip_area 479016 479140 124 0.0
efr32 lighting-app BRD4161A (read only) 835484 835660 176 0.0
.text 835476 835652 176 0.0
BRD4161A+rpc (read only) 822864 823056 192 0.0
.text 822856 823048 192 0.0
window-app BRD4161A (read only) 806324 806500 176 0.0
.text 806316 806492 176 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919382 180 0.0
.flash.text 919202 919382 180 0.0
m5stack (read only) 967535 967671 136 0.0
.flash.text 962151 962287 136 0.0
k32w light k32w061+release (read/write) 660864 660992 128 0.0
.text 575972 576100 128 0.0
lock k32w061+release (read/write) 661796 661924 128 0.0
.text 576616 576744 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348784 2348912 128 0.0
.text 1311360 1311488 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2333984 2334112 128 0.0
.text 1296584 1296712 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304568 2304696 128 0.0
.text 1267168 1267296 128 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942303 128 0.0
text 637104 637232 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 927675 927803 128 0.0
text 632500 632628 128 0.0
nrf52840dongle_nrf52840 (read/write) 992855 992983 128 0.0
text 669304 669432 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852162 128 0.0
text 554024 554152 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912811 128 0.0
text 612680 612808 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822702 822830 128 0.0
text 529636 529764 128 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915339 915467 128 0.0
text 615148 615276 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910651 128 0.0
text 611176 611304 128 0.0
p6 all-clusters-app default (read/write) 2407448 2407624 176 0.0
.text 1365712 1365888 176 0.0
light-app default (read/write) 2330256 2330432 176 0.0
.text 1288520 1288696 176 0.0
lock-app default (read/write) 2299664 2299856 192 0.0
.text 1257928 1258120 192 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567220 128 0.0
.text 561772 561900 128 0.0
lock-app qpg6105+debug (read only) 515752 515880 128 0.0
.text 510432 510560 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841238 176 0.0
text 588184 588362 178 0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section d21dbff ba5faad change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573714 573838 124 0.0
.app_xip_area 479016 479140 124 0.0
.bss 77444 77444 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835484 835660 176 0.0
(read/write) 126980 126980 0 0.0
.bss 125080 125080 0 0.0
.data 1900 1900 0 0.0
.text 835476 835652 176 0.0
BRD4161A+rpc (read only) 822864 823056 192 0.0
(read/write) 143640 143640 0 0.0
.bss 141640 141640 0 0.0
.data 2000 2000 0 0.0
.text 822856 823048 192 0.0
window-app BRD4161A (read only) 806324 806500 176 0.0
(read/write) 125624 125624 0 0.0
.bss 123768 123768 0 0.0
.data 1856 1856 0 0.0
.text 806316 806492 176 0.0
esp32 all-clusters-app c3devkit (read only) 919202 919382 180 0.0
(read/write) 1376810 1376810 0 0.0
.dram0.bss 67376 67376 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 176064 176064 0 0.0
.flash.text 919202 919382 180 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 967535 967671 136 0.0
(read/write) 443240 443240 0 0.0
.dram0.bss 71856 71856 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 205224 205224 0 0.0
.flash.text 962151 962287 136 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660864 660992 128 0.0
.bss 77224 77224 0 0.0
.data 1868 1868 0 0.0
.text 575972 576100 128 0.0
lock k32w061+release (read/write) 661796 661924 128 0.0
.bss 77488 77488 0 0.0
.data 1892 1892 0 0.0
.text 576616 576744 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348784 2348912 128 0.0
.bss 186084 186084 0 0.0
.data 5296 5296 0 0.0
.text 1311360 1311488 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333984 2334112 128 0.0
.bss 180688 180688 0 0.0
.data 5576 5576 0 0.0
.text 1296584 1296712 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304568 2304696 128 0.0
.bss 180592 180592 0 0.0
.data 5568 5568 0 0.0
.text 1267168 1267296 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053896 2053896 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016496 1016496 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942175 942303 128 0.0
bss 118776 118776 0 0.0
rodata 108708 108708 0 0.0
text 637104 637232 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 927675 927803 128 0.0
bss 115820 115820 0 0.0
rodata 101160 101160 0 0.0
text 632500 632628 128 0.0
nrf52840dongle_nrf52840 (read/write) 992855 992983 128 0.0
bss 121616 121616 0 0.0
rodata 113464 113464 0 0.0
text 669304 669432 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852034 852162 128 0.0
bss 115564 115564 0 0.0
rodata 101884 101884 0 0.0
text 554024 554152 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912683 912811 128 0.0
bss 118828 118828 0 0.0
rodata 103768 103768 0 0.0
text 612680 612808 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822702 822830 128 0.0
bss 115648 115648 0 0.0
rodata 96992 96992 0 0.0
text 529636 529764 128 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915339 915467 128 0.0
bss 118576 118576 0 0.0
rodata 104152 104152 0 0.0
text 615148 615276 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910523 910651 128 0.0
bss 118600 118600 0 0.0
rodata 103256 103256 0 0.0
text 611176 611304 128 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533644 533644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451320 451320 0 0.0
p6 all-clusters-app default (read/write) 2407448 2407624 176 0.0
.bss 114428 114428 0 0.0
.data 2584 2584 0 0.0
.text 1365712 1365888 176 0.0
light-app default (read/write) 2330256 2330432 176 0.0
.bss 105272 105272 0 0.0
.data 2408 2408 0 0.0
.text 1288520 1288696 176 0.0
lock-app default (read/write) 2299664 2299856 192 0.0
.bss 105024 105024 0 0.0
.data 2360 2360 0 0.0
.text 1257928 1258120 192 0.0
qpg lighting-app qpg6105+debug (read only) 567092 567220 128 0.0
(read/write) 146936 146936 0 0.0
.bss 89416 89416 0 0.0
.data 1060 1060 0 0.0
.text 561772 561900 128 0.0
lock-app qpg6105+debug (read only) 515752 515880 128 0.0
(read/write) 146940 146940 0 0.0
.bss 88896 88896 0 0.0
.data 992 992 0 0.0
.text 510432 510560 128 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841062 841238 176 0.0
bss 87224 87224 0 0.0
noinit 37160 37160 0 0.0
text 588184 588362 178 0.0

@emargolis emargolis force-pushed the emargolis/feature/generate-x509-cert branch from ba5faad to 5092de1 Compare January 25, 2022 22:45
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

PR #13737: Size comparison from ede1388 to 5092de1

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ede1388 5092de1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577998 578122 124 0.0
.app_xip_area 483056 483180 124 0.0
efr32 lighting-app BRD4161A (read only) 839388 839564 176 0.0
.text 839380 839556 176 0.0
BRD4161A+rpc (read only) 826744 826936 192 0.0
.text 826736 826928 192 0.0
window-app BRD4161A (read only) 811716 811908 192 0.0
.text 811708 811900 192 0.0
esp32 all-clusters-app c3devkit (read only) 918892 919072 180 0.0
.flash.text 918892 919072 180 0.0
m5stack (read only) 968091 968227 136 0.0
.flash.text 962707 962843 136 0.0
k32w light k32w061+release (read/write) 662736 662864 128 0.0
.text 577608 577736 128 0.0
lock k32w061+release (read/write) 663776 663904 128 0.0
.text 578360 578488 128 0.0
linux chip-tool-ipv6only arm64 (read only) 8716252 8716700 448 0.0
.text 7341284 7341732 448 0.0
thermostat-no-ble arm64 (read only) 2049660 2050444 784 0.0
(read/write) 146785 146801 16 0.0
.data.rel.ro 73192 73216 24 0.0
.text 1703728 1704480 752 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2353048 2353176 128 0.0
.text 1315648 1315776 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338968 2339096 128 0.0
.text 1301568 1301696 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2305784 2305912 128 0.0
.text 1268384 1268512 128 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 946763 946891 128 0.0
text 639748 639876 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 932267 932395 128 0.0
text 635140 635268 128 0.0
nrf52840dongle_nrf52840 (read/write) 997443 997571 128 0.0
text 671944 672072 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 856622 856750 128 0.0
text 556664 556792 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913903 914031 128 0.0
text 612508 612636 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823958 824086 128 0.0
text 529460 529588 128 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916579 916707 128 0.0
text 614976 615104 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911747 911875 128 0.0
text 611004 611132 128 0.0
p6 all-clusters-app default (read/write) 2411464 2411656 192 0.0
.text 1369728 1369920 192 0.0
light-app default (read/write) 2334944 2335136 192 0.0
.text 1293208 1293400 192 0.0
lock-app default (read/write) 2300496 2300688 192 0.0
.text 1258760 1258952 192 0.0
qpg lighting-app qpg6105+debug (read only) 569704 569832 128 0.0
.text 564384 564512 128 0.0
lock-app qpg6105+debug (read only) 515956 516084 128 0.0
.text 510636 510764 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 845554 845730 176 0.0
text 590682 590860 178 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ede1388 5092de1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577998 578122 124 0.0
.app_xip_area 483056 483180 124 0.0
.bss 77688 77688 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 839388 839564 176 0.0
(read/write) 127228 127228 0 0.0
.bss 125328 125328 0 0.0
.data 1900 1900 0 0.0
.text 839380 839556 176 0.0
BRD4161A+rpc (read only) 826744 826936 192 0.0
(read/write) 143888 143888 0 0.0
.bss 141888 141888 0 0.0
.data 2000 2000 0 0.0
.text 826736 826928 192 0.0
window-app BRD4161A (read only) 811716 811908 192 0.0
(read/write) 125884 125884 0 0.0
.bss 124028 124028 0 0.0
.data 1856 1856 0 0.0
.text 811708 811900 192 0.0
esp32 all-clusters-app c3devkit (read only) 918892 919072 180 0.0
(read/write) 1384338 1384338 0 0.0
.dram0.bss 70704 70704 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180464 180464 0 0.0
.flash.text 918892 919072 180 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 968091 968227 136 0.0
(read/write) 451368 451368 0 0.0
.dram0.bss 75448 75448 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209760 209760 0 0.0
.flash.text 962707 962843 136 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662736 662864 128 0.0
.bss 77460 77460 0 0.0
.data 1868 1868 0 0.0
.text 577608 577736 128 0.0
lock k32w061+release (read/write) 663776 663904 128 0.0
.bss 77724 77724 0 0.0
.data 1892 1892 0 0.0
.text 578360 578488 128 0.0
linux chip-tool-ipv6only arm64 (read only) 8716252 8716700 448 0.0
(read/write) 391585 391585 0 0.0
.bss 56033 56033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261440 261440 0 0.0
.dynamic 560 560 0 0.0
.got 69232 69232 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534420 534420 0 0.0
.text 7341284 7341732 448 0.0
thermostat-no-ble arm64 (read only) 2049660 2050444 784 0.0
(read/write) 146785 146801 16 0.0
.bss 65665 65665 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73192 73216 24 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131372 131372 0 0.0
.text 1703728 1704480 752 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353048 2353176 128 0.0
.bss 189412 189412 0 0.0
.data 5296 5296 0 0.0
.text 1315648 1315776 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338968 2339096 128 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1301568 1301696 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305784 2305912 128 0.0
.bss 180832 180832 0 0.0
.data 5568 5568 0 0.0
.text 1268384 1268512 128 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053960 2053960 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016560 1016560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 946763 946891 128 0.0
bss 119024 119024 0 0.0
rodata 110400 110400 0 0.0
text 639748 639876 128 0.0
nrf52840dk_nrf52840+rpc (read/write) 932267 932395 128 0.0
bss 116068 116068 0 0.0
rodata 102856 102856 0 0.0
text 635140 635268 128 0.0
nrf52840dongle_nrf52840 (read/write) 997443 997571 128 0.0
bss 121864 121864 0 0.0
rodata 115156 115156 0 0.0
text 671944 672072 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 856622 856750 128 0.0
bss 115812 115812 0 0.0
rodata 103576 103576 0 0.0
text 556664 556792 128 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913903 914031 128 0.0
bss 119072 119072 0 0.0
rodata 104940 104940 0 0.0
text 612508 612636 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823958 824086 128 0.0
bss 115888 115888 0 0.0
rodata 98168 98168 0 0.0
text 529460 529588 128 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916579 916707 128 0.0
bss 118816 118816 0 0.0
rodata 105328 105328 0 0.0
text 614976 615104 128 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911747 911875 128 0.0
bss 118844 118844 0 0.0
rodata 104432 104432 0 0.0
text 611004 611132 128 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533648 533648 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711022 711022 0 0.0
bss 107664 107664 0 0.0
rodata 72592 72592 0 0.0
text 451324 451324 0 0.0
p6 all-clusters-app default (read/write) 2411464 2411656 192 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1369728 1369920 192 0.0
light-app default (read/write) 2334944 2335136 192 0.0
.bss 105516 105516 0 0.0
.data 2408 2408 0 0.0
.text 1293208 1293400 192 0.0
lock-app default (read/write) 2300496 2300688 192 0.0
.bss 105260 105260 0 0.0
.data 2360 2360 0 0.0
.text 1258760 1258952 192 0.0
qpg lighting-app qpg6105+debug (read only) 569704 569832 128 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 564384 564512 128 0.0
lock-app qpg6105+debug (read only) 515956 516084 128 0.0
(read/write) 146940 146940 0 0.0
.bss 89144 89144 0 0.0
.data 992 992 0 0.0
.text 510636 510764 128 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845554 845730 176 0.0
bss 87472 87472 0 0.0
noinit 37160 37160 0 0.0
text 590682 590860 178 0.0

woody-apple
woody-apple approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given this has been > 3 days for reviews.

@emargolis
Op Certs Generation: Support CASE Authenticated Tags and other Attrib…
6dc6a10 
…utes.

  - Added support for the subject and issuer DNs in the X509CertRequestParams structure.
  - Factored out ChipDN encoding and decoding into separate functions.
  - Other updates and cleanups.
@emargolis emargolis force-pushed the emargolis/feature/generate-x509-cert branch from 5092de1 to 6dc6a10 Compare January 26, 2022 06:31
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13737: Size comparison from 246473c to 6dc6a10

Increases (11 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section 246473c 6dc6a10 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 578586 124 0.0
.app_xip_area 483384 483508 124 0.0
k32w light k32w061+release (read/write) 664644 664772 128 0.0
.text 579380 579508 128 0.0
lock k32w061+release (read/write) 665696 665824 128 0.0
.text 580144 580272 128 0.0
linux chip-tool-ipv6only arm64 (read only) 8728948 8729396 448 0.0
.text 7352756 7353204 448 0.0
thermostat-no-ble arm64 (read only) 2058404 2059188 784 0.0
(read/write) 147457 147473 16 0.0
.data.rel.ro 73624 73648 24 0.0
.text 1711248 1712000 752 0.0
p6 all-clusters-app default (read/write) 2414704 2414896 192 0.0
.text 1372968 1373160 192 0.0
light-app default (read/write) 2336424 2336600 176 0.0
.text 1294688 1294864 176 0.0
lock-app default (read/write) 2303720 2303912 192 0.0
.text 1261984 1262176 192 0.0
qpg lighting-app qpg6105+debug (read only) 570044 570172 128 0.0
.text 564724 564852 128 0.0
lock-app qpg6105+debug (read only) 517724 517852 128 0.0
.text 512404 512532 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 846030 846206 176 0.0
text 591096 591274 178 0.0
Full report (12 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section 246473c 6dc6a10 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 578586 124 0.0
.app_xip_area 483384 483508 124 0.0
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
k32w light k32w061+release (read/write) 664644 664772 128 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579380 579508 128 0.0
lock k32w061+release (read/write) 665696 665824 128 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580144 580272 128 0.0
linux chip-tool-ipv6only arm64 (read only) 8728948 8729396 448 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534444 534444 0 0.0
.text 7352756 7353204 448 0.0
thermostat-no-ble arm64 (read only) 2058404 2059188 784 0.0
(read/write) 147457 147473 16 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73624 73648 24 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1711248 1712000 752 0.0
p6 all-clusters-app default (read/write) 2414704 2414896 192 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1372968 1373160 192 0.0
light-app default (read/write) 2336424 2336600 176 0.0
.bss 105644 105644 0 0.0
.data 2408 2408 0 0.0
.text 1294688 1294864 176 0.0
lock-app default (read/write) 2303720 2303912 192 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1261984 1262176 192 0.0
qpg lighting-app qpg6105+debug (read only) 570044 570172 128 0.0
(read/write) 146936 146936 0 0.0
.bss 89800 89800 0 0.0
.data 1060 1060 0 0.0
.text 564724 564852 128 0.0
lock-app qpg6105+debug (read only) 517724 517852 128 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512404 512532 128 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846030 846206 176 0.0
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 591096 591274 178 0.0

@andy31415 andy31415 merged commit 20c1f60 into project-chip:master Jan 26, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@emargolis @selissia
Op Certs Generation: Support CASE Authenticated Tags and other Attrib…
d854f08 
…utes. (project-chip#13737)

- Added support for the subject and issuer DNs in the X509CertRequestParams structure.
  - Factored out ChipDN encoding and decoding into separate functions.
  - Other updates and cleanups.
@emargolis emargolis mentioned this pull request Feb 2, 2022
Merged
@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emargolis @tcarmelveilleux @woody-apple @bzbarsky-apple @andy31415