Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new reviewer from Comcast #142

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Adding new reviewer from Comcast #142

merged 3 commits into from
Mar 27, 2020

Conversation

woody-apple
Copy link
Contributor

Problem

Adding @jelderton As a required reviewer

Summary of Changes

Updating reviewers & code owners

@woody-apple woody-apple changed the title Woody add reviewers Adding new reviewer from Comcast Mar 27, 2020
@woody-apple
Copy link
Contributor Author

@hawk248 @anush-apple @BroderickCarlin

hawk248
hawk248 approved these changes Mar 27, 2020
View reviewed changes
Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple woody-apple merged commit 7313c0e into project-chip:master Mar 27, 2020
jmartinez-silabs referenced this pull request in SiliconLabs/matter Oct 13, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #142: Cherry-Pick Modules Support to silabs_1.0
a21be1a 
Merge in WMN_TOOLS/matter from cherry_pick/module_support to silabs_1.0

Squashed commit of the following:

commit c15cb2cacb01bc32e8e9df8f9df23009d81e5d50
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Wed Oct 5 14:58:43 2022 -0400

    Add Modules to jenkins files

commit 16bb8eb8b5cc31e52cdef6821a7f1aa768bddcde
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Fri Sep 30 14:11:27 2022 -0400

    Fix build argument for custom examples

commit aaf606cbdc7379205df0f1e2e4fdb09a1f4ae651
Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Date:   Mon Sep 26 09:29:04 2022 -0400

    [Silabs] Add Support for Modules for Matter (project-chip#22793)

    * rename variables to be agnostic from board family

    * Add support for the BRD4317a

    * Add support for the mgm24 boards

    * Add argument to remove LEDs if necessary

    * Change default value to support multiple board types

    * Add Support for the BRD4316A

    * Add Support for BRD4319A

    * update matter_support submodule

    * Rename variable in missing location

    Co-authored-by: Andrei Litvin <andy314@gmail.com>
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@mkardous-silabs @jmartinez-silabs
Pull request project-chip#142: Cherry-Pick Modules Support to silabs_1.0
0722485 
Merge in WMN_TOOLS/matter from cherry_pick/module_support to silabs_1.0

Squashed commit of the following:

commit c15cb2cacb01bc32e8e9df8f9df23009d81e5d50
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Wed Oct 5 14:58:43 2022 -0400

    Add Modules to jenkins files

commit 16bb8eb8b5cc31e52cdef6821a7f1aa768bddcde
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Fri Sep 30 14:11:27 2022 -0400

    Fix build argument for custom examples

commit aaf606cbdc7379205df0f1e2e4fdb09a1f4ae651
Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Date:   Mon Sep 26 09:29:04 2022 -0400

    [Silabs] Add Support for Modules for Matter (project-chip#22793)

    * rename variables to be agnostic from board family

    * Add support for the BRD4317a

    * Add support for the mgm24 boards

    * Add argument to remove LEDs if necessary

    * Change default value to support multiple board types

    * Add Support for the BRD4316A

    * Add Support for BRD4319A

    * update matter_support submodule

    * Rename variable in missing location

    Co-authored-by: Andrei Litvin <andy314@gmail.com>
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #142: Cherry-Pick Modules Support to silabs_1.0
243162a 
Merge in WMN_TOOLS/matter from cherry_pick/module_support to silabs_1.0

Squashed commit of the following:

commit c15cb2cacb01bc32e8e9df8f9df23009d81e5d50
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Wed Oct 5 14:58:43 2022 -0400

    Add Modules to jenkins files

commit 16bb8eb8b5cc31e52cdef6821a7f1aa768bddcde
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Fri Sep 30 14:11:27 2022 -0400

    Fix build argument for custom examples

commit aaf606cbdc7379205df0f1e2e4fdb09a1f4ae651
Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Date:   Mon Sep 26 09:29:04 2022 -0400

    [Silabs] Add Support for Modules for Matter (project-chip#22793)

    * rename variables to be agnostic from board family

    * Add support for the BRD4317a

    * Add support for the mgm24 boards

    * Add argument to remove LEDs if necessary

    * Change default value to support multiple board types

    * Add Support for the BRD4316A

    * Add Support for BRD4319A

    * update matter_support submodule

    * Rename variable in missing location

    Co-authored-by: Andrei Litvin <andy314@gmail.com>
rerasool referenced this pull request in SiliconLabs/matter Nov 2, 2022
@mkardous-silabs @jmartinez-silabs
Pull request #142: Cherry-Pick Modules Support to silabs_1.0
df7042d 
Merge in WMN_TOOLS/matter from cherry_pick/module_support to silabs_1.0

Squashed commit of the following:

commit c15cb2cacb01bc32e8e9df8f9df23009d81e5d50
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Wed Oct 5 14:58:43 2022 -0400

    Add Modules to jenkins files

commit 16bb8eb8b5cc31e52cdef6821a7f1aa768bddcde
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Fri Sep 30 14:11:27 2022 -0400

    Fix build argument for custom examples

commit aaf606cbdc7379205df0f1e2e4fdb09a1f4ae651
Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
Date:   Mon Sep 26 09:29:04 2022 -0400

    [Silabs] Add Support for Modules for Matter (project-chip#22793)

    * rename variables to be agnostic from board family

    * Add support for the BRD4317a

    * Add support for the mgm24 boards

    * Add argument to remove LEDs if necessary

    * Change default value to support multiple board types

    * Add Support for the BRD4316A

    * Add Support for BRD4319A

    * update matter_support submodule

    * Rename variable in missing location

    Co-authored-by: Andrei Litvin <andy314@gmail.com>
chrisdecenzo pushed a commit that referenced this pull request Apr 10, 2023
@rawadhilal88
Enable TV Casting App Example to using Hardware-backed keys For DAC (#…
fb13051 
…26022)

* Enable TV Casting App Example to using Hardware-backed keys For DAC (#142)

It is best practice for private keys to not be available to the application layer in plain form. In
fact you can generate keys within the secure element on device, or TrustZone, that is not extractable
in plain form. In order to support such best practices, the change addresses this by modifying the DAC Provider's
SignWithDeviceAttestationKey function that is provided by the example tv castin app to:

- For Android, ask the Java application layer to do the signing via the Android Keystore.
- For iOS, request the SecKeyRef for the private key as part of setting the DAC provider and hence allowing the SDK
 to just sign using the Security APIs.

* Update JNI Interface in tv-app to allow app to sign messages for DAC stored in Android KeyStore

In an effort to leverage hardware keys for DAC, the JNI layer was updated to ask the JVM layer to
sign message by leveraging the Android KeyStore instead of requesting to the raw private key bytes
only to sign it within the c++ layer. This adds a level of security to the device attestation process.
lpbeliveau-silabs added a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Nov 28, 2024
@lpbeliveau-silabs
[SL-UP] Bugfix/silabs out rtt removal (project-chip#142)
9ff86c6
lpbeliveau-silabs added a commit that referenced this pull request Nov 28, 2024
@lpbeliveau-silabs
[Silabs] Silabs Uart Shell fixes (#36667)
439de24 
* [SL-UP] Bugfix/silabs out rtt removal (#142)

* [SL-UP] Bugfix/matter shell crash nullptr (#125)

* Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@lpbeliveau-silabs @yyzhong-g
[Silabs] Silabs Uart Shell fixes (project-chip#36667)
9a9ff6b 
* [SL-UP] Bugfix/silabs out rtt removal (project-chip#142)

* [SL-UP] Bugfix/matter shell crash nullptr (project-chip#125)

* Added checks on null ptr to prevent uart shell crash and modified ICD shell commands to be compatible with our internal structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawk248 hawk248 hawk248 approved these changes

@gerickson gerickson gerickson approved these changes

@tpmanley tpmanley tpmanley approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woody-apple @tpmanley @gerickson @hawk248