Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Separate Operational Credentials Issuer #14871

Merged
merged 6 commits into from
Feb 11, 2022
Merged

[Android] Separate Operational Credentials Issuer #14871

merged 6 commits into from
Feb 11, 2022

Conversation

joonhaengHeo
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Separate "Operational Credentials Issuer" code from AndroidDeviceWrapper

The current code is for temporarily creating and testing a certificate.
To create a Controller Application with Android Platform, you need to implement Operational Credentials.
By separating this part, you can easily reuse the code.

In particular, it is easy to identify when requesting a review of Golden SDK changes.
I think this part is a vendor specific extension.

Change overview

  • Separate OperationalCredentialsIssuer code. (Class Name : AndroidOperationalCredentialsIssuer)
  • Added code in AndroidDeviceWrapper so that ICAC can be used simply implementing in AndroidOperationalCredentialsIssuer class.

Testing

How was this tested? (at least one bullet point required)

  • Test Commissioning flow with example controllee app. (Ex, All-cluster-app)

@restyled-io restyled-io bot mentioned this pull request Feb 8, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14871: Size comparison from 97cf4ff to b286cdd

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 97cf4ff b286cdd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594398 594398 0 0.0
.app_xip_area 500252 500252 0 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552298 552298 0 0.0
.app_xip_area 459712 459712 0 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576306 576306 0 0.0
.app_xip_area 474400 474400 0 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865756 865756 0 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865748 865748 0 0.0
BRD4161A+rpc (read only) 853212 853212 0 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853204 853204 0 0.0
window-app BRD4161A (read only) 837960 837960 0 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 837952 837952 0 0.0
esp32 all-clusters-app c3devkit (read only) 937916 937916 0 0.0
(read/write) 1401098 1401098 0 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198464 198464 0 0.0
.flash.text 937916 937916 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 986251 986251 0 0.0
(read/write) 466136 466136 0 0.0
.dram0.bss 74592 74592 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 225376 225376 0 0.0
.flash.text 980867 980867 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678488 678488 0 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594236 594236 0 0.0
lock k32w061+release (read/write) 680388 680388 0 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595768 595768 0 0.0
linux all-clusters-app debug (read only) 2327369 2327369 0 0.0
(read/write) 140064 140064 0 0.0
.bss 54688 54688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205029 205029 0 0.0
.text 1960114 1960114 0 0.0
bridge-app debug+rpc (read only) 1704053 1704053 0 0.0
(read/write) 84296 84296 0 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140172 140172 0 0.0
.text 1447429 1447429 0 0.0
chip-tool debug (read only) 7383957 7383957 0 0.0
(read/write) 185392 185392 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 145888 145888 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 413077 413077 0 0.0
.text 6599045 6599045 0 0.0
chip-tool-ipv6only arm64 (read only) 7315220 7315220 0 0.0
(read/write) 289681 289681 0 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 187544 187544 0 0.0
.dynamic 560 560 0 0.0
.got 46528 46528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 396380 396380 0 0.0
.text 6309684 6309684 0 0.0
door-lock-app debug (read only) 1908457 1908457 0 0.0
(read/write) 110552 110552 0 0.0
.bss 42096 42096 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172786 172786 0 0.0
.text 1587250 1587250 0 0.0
lighting-app debug+rpc (read only) 2003289 2003289 0 0.0
(read/write) 115600 115600 0 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65640 65640 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162865 162865 0 0.0
.text 1685874 1685874 0 0.0
ota-provider-app debug (read only) 1711905 1711905 0 0.0
(read/write) 81336 81336 0 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33528 33528 0 0.0
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151206 151206 0 0.0
.text 1442114 1442114 0 0.0
ota-requestor-app debug (read only) 1701321 1701321 0 0.0
(read/write) 83288 83288 0 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34584 34584 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144823 144823 0 0.0
.text 1439698 1439698 0 0.0
shell debug (read only) 2300777 2300777 0 0.0
(read/write) 141616 141616 0 0.0
.bss 62080 62080 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205778 205778 0 0.0
.text 1938578 1938578 0 0.0
thermostat-no-ble arm64 (read only) 2129612 2129612 0 0.0
(read/write) 140641 140641 0 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74872 74872 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131932 131932 0 0.0
.text 1779712 1779712 0 0.0
tv-app debug (read only) 2525577 2525577 0 0.0
(read/write) 139800 139800 0 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73336 73336 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 195532 195532 0 0.0
.text 2156434 2156434 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389632 2389632 0 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352232 1352232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348800 2348800 0 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311400 1311400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312720 2312720 0 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275320 1275320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302692 2302692 0 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265264 1265264 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004731 1004731 0 0.0
bss 121280 121280 0 0.0
rodata 118072 118072 0 0.0
text 686436 686436 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 976207 976207 0 0.0
bss 117136 117136 0 0.0
rodata 109532 109532 0 0.0
text 671076 671076 0 0.0
nrf52840dongle_nrf52840 (read/write) 1021535 1021535 0 0.0
bss 122644 122644 0 0.0
rodata 116960 116960 0 0.0
text 692004 692004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911394 911394 0 0.0
bss 117840 117840 0 0.0
rodata 111332 111332 0 0.0
text 601460 601460 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936987 936987 0 0.0
bss 119616 119616 0 0.0
rodata 106472 106472 0 0.0
text 632356 632356 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844482 844482 0 0.0
bss 116212 116212 0 0.0
rodata 99644 99644 0 0.0
text 548156 548156 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541747 541747 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376920 376920 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939219 939219 0 0.0
bss 119368 119368 0 0.0
rodata 106656 106656 0 0.0
text 634600 634600 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934559 934559 0 0.0
bss 119372 119372 0 0.0
rodata 105948 105948 0 0.0
text 630632 630632 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803151 803151 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535824 535824 0 0.0
p6 all-clusters-app default (read/write) 2463712 2463712 0 0.0
.bss 117976 117976 0 0.0
.data 2584 2584 0 0.0
.text 1421976 1421976 0 0.0
light-app default (read/write) 2367176 2367176 0 0.0
.bss 107600 107600 0 0.0
.data 2432 2432 0 0.0
.text 1325440 1325440 0 0.0
lock-app default (read/write) 2332344 2332344 0 0.0
.bss 107304 107304 0 0.0
.data 2392 2392 0 0.0
.text 1290608 1290608 0 0.0
qpg lighting-app qpg6105+debug (read only) 585768 585768 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88856 88856 0 0.0
.data 1084 1084 0 0.0
.text 580448 580448 0 0.0
lock-app qpg6105+debug (read only) 531844 531844 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526524 526524 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865702 865702 0 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607624 607624 0 0.0

@pullapprove pullapprove bot requested a review from lazarkov February 10, 2022 00:17
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #14871: Size comparison from 56634bf to 41e7d86

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 56634bf 41e7d86 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606682 606682 0 0.0
.app_xip_area 508112 508112 0 0.0
.bss 81268 81268 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563158 563158 0 0.0
.app_xip_area 466148 466148 0 0.0
.bss 79740 79740 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584170 584170 0 0.0
.app_xip_area 477912 477912 0 0.0
.bss 88660 88660 0 0.0
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906792 906792 0 0.0
(read/write) 129000 129000 0 0.0
.bss 126960 126960 0 0.0
.data 2036 2036 0 0.0
.text 906784 906784 0 0.0
BRD4161A+rpc (read only) 894236 894236 0 0.0
(read/write) 145656 145656 0 0.0
.bss 143520 143520 0 0.0
.data 2136 2136 0 0.0
.text 894228 894228 0 0.0
window-app BRD4161A (read only) 841920 841920 0 0.0
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1904 0 0.0
.text 841912 841912 0 0.0
esp32 all-clusters-app c3devkit (read only) 943304 943304 0 0.0
(read/write) 1400250 1400250 0 0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 199040 199040 0 0.0
.flash.text 943304 943304 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 990967 0 0.0
(read/write) 465080 465080 0 0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 225712 225712 0 0.0
.flash.text 985583 985583 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683544 683544 0 0.0
.bss 78264 78264 0 0.0
.data 1908 1908 0 0.0
.text 597572 597572 0 0.0
lock k32w061+release (read/write) 688408 688408 0 0.0
.bss 78664 78664 0 0.0
.data 1952 1952 0 0.0
.text 601992 601992 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7478116 7478116 0 0.0
(read/write) 303409 303409 0 0.0
.bss 51777 51777 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 199520 199520 0 0.0
.dynamic 560 560 0 0.0
.got 47088 47088 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403020 403020 0 0.0
.text 6435220 6435220 0 0.0
thermostat-no-ble arm64 (read only) 2139804 2139804 0 0.0
(read/write) 142273 142273 0 0.0
.bss 59201 59201 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 74912 74912 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132956 0 0.0
.text 1788736 1788736 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396072 2396072 0 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358672 1358672 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2357760 0 0.0
.bss 182704 182704 0 0.0
.data 5632 5632 0 0.0
.text 1320360 1320360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321288 0 0.0
.bss 182592 182592 0 0.0
.data 5608 5608 0 0.0
.text 1283888 1283888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307292 0 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1269864 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015363 1015363 0 0.0
bss 123020 123020 0 0.0
rodata 119416 119416 0 0.0
text 693908 693908 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984183 984183 0 0.0
bss 120208 120208 0 0.0
rodata 110780 110780 0 0.0
text 673520 673520 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031067 1031067 0 0.0
bss 124416 124416 0 0.0
rodata 118276 118276 0 0.0
text 698528 698528 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 921958 921958 0 0.0
bss 119584 119584 0 0.0
rodata 112656 112656 0 0.0
text 608944 608944 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945083 945083 0 0.0
bss 121400 121400 0 0.0
rodata 108160 108160 0 0.0
text 636948 636948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852594 852594 0 0.0
bss 117992 117992 0 0.0
rodata 101332 101332 0 0.0
text 552756 552756 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944507 944507 0 0.0
bss 121120 121120 0 0.0
rodata 107520 107520 0 0.0
text 637208 637208 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 939847 939847 0 0.0
bss 121124 121124 0 0.0
rodata 106812 106812 0 0.0
text 633244 633244 0 0.0
shell nrf52840dk_nrf52840 (read/write) 805927 805927 0 0.0
bss 112400 112400 0 0.0
rodata 78812 78812 0 0.0
text 537036 537036 0 0.0
p6 all-clusters-app default (read/write) 2482304 2482304 0 0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440568 1440568 0 0.0
light-app default (read/write) 2388648 2388648 0 0.0
.bss 109352 109352 0 0.0
.data 2528 2528 0 0.0
.text 1346912 1346912 0 0.0
lock-app default (read/write) 2352104 2352104 0 0.0
.bss 109072 109072 0 0.0
.data 2488 2488 0 0.0
.text 1310368 1310368 0 0.0
qpg lighting-app qpg6105+debug (read only) 592956 592956 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90536 90536 0 0.0
.data 1112 1112 0 0.0
.text 587636 587636 0 0.0
lock-app qpg6105+debug (read only) 558708 558708 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90520 90520 0 0.0
.data 1064 1064 0 0.0
.text 553388 553388 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874334 0 0.0
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613082 0 0.0

@andy31415 andy31415 merged commit df19dfd into project-chip:master Feb 11, 2022
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@joonhaengHeo @restyled-commits @fuxingguo16
[Android] Separate Operational Credentials Issuer (project-chip#14871)
ebd5add 
* Seperate OperationalCredentialsIssuer in Android

* Restyled by whitespace

* Restyled by clang-format

* Remove unused code

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinh0 austinh0 austinh0 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joonhaengHeo @woody-apple @austinh0 @andy31415 @restyled-commits