-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent storage to session manager #15062
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_persistent_storage_session_manager
Feb 11, 2022
Merged
Add persistent storage to session manager #15062
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_persistent_storage_session_manager
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
add_persistent_storage_session_manager
branch
from
February 11, 2022 02:45
4f57404
to
8b17df5
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs and
kghost
February 11, 2022 02:45
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 11, 2022 02:46
bzbarsky-apple
approved these changes
Feb 11, 2022
PR #15062: Size comparison from 24271c7 to 8b17df5 Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Full report (40 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jepenven-silabs
force-pushed
the
add_persistent_storage_session_manager
branch
from
February 11, 2022 15:48
eeccfe7
to
35d3650
Compare
jepenven-silabs
force-pushed
the
add_persistent_storage_session_manager
branch
from
February 11, 2022 15:50
35d3650
to
2851ffc
Compare
PR #15062: Size comparison from 512ab16 to 2851ffc Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 11, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Add persistent storage to session manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Break down of #14996
Group message counter needs access to the persistent storage delegate so that they can persist between reboot (spec 4.5.1.3 )
Change overview
Add a PersistentStorageDelegate pointer to the constructor of
SessionManager
this pointer is unused for now but will be used once #14996 is mergedTesting
Same as 14996