[flashing scripts] Log errors from subprocesses #15593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem It's difficult to troubleshoot errors frome external commands run by the flashing scripts, because their output is captured and not reported. #### Change overview Log command stdout and stderr in case of failure. #### Testing Manual run.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #15593: Size comparison from bb6bb37 to 64532f7 Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Comment on lines
+228
to
+232
| self.log(fail_level, '--- stdout ---') | ||
| self.log(fail_level, exception.stdout) | ||
| self.log(fail_level, '--- stderr ---') | ||
| self.log(fail_level, exception.stderr) | ||
| self.log(fail_level, '---') |
There was a problem hiding this comment.
nit: shouldn't be better to have only one single log entry?
Suggested change
| self.log(fail_level, '--- stdout ---') | |
| self.log(fail_level, exception.stdout) | |
| self.log(fail_level, '--- stderr ---') | |
| self.log(fail_level, exception.stderr) | |
| self.log(fail_level, '---') | |
| self.log(fail_level, '--- stdout ---\n' | |
| f'{exception.stdout}\n--- stderr ---\n' | |
| f'{exception.stderr}\n---') |
There was a problem hiding this comment.
Lets follow up in a separate PR if needed. I would like to have this version in to catch the reason of the flakyness. In most cases these logs will not be used.
There was a problem hiding this comment.
Unresolved after merge. @kpschoedel could you followup in a separate PR or argue that it is not needed?
there would also be the option of 'every stdout/stderr line should have its own log line' so that things align nicely in logs.
There was a problem hiding this comment.
Yes, I'll address this one way or another, when we catch the parttool error or separately.
andy31415
approved these changes
Feb 25, 2022
bzbarsky-apple
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's difficult to troubleshoot errors frome external commands
run by the flashing scripts, because their output is captured
and not reported.
Change overview
Log command stdout and stderr in case of failure.
Testing
Manual run.