Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] Use new chip SHA256 class to re-implement CHIP provisioning HASH #1564

Merged
merged 1 commit into from
Jul 16, 2020
Merged

[linux] Use new chip SHA256 class to re-implement CHIP provisioning HASH #1564

merged 1 commit into from
Jul 16, 2020

Conversation

yufengwangca
Copy link
Contributor

Problem
CHIP provisioning hash logic within configuration manager is temporarily disabled and wait for final CHIP SHA256 implementation.

Summary of Changes

  • SHA256 class for CHIP is merged. Replace legacy SHA256 with chip::Crypto::Hash_SHA256_stream in configuration manager
  • Enable flag CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH

fixes #<1166>

* SHA256 class for CHIP is merged. Replace legacy SHA256 with chip::Crypto::Hash_SHA256_stream
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,125
.debug_loc,0,87
.debug_str,0,53
.debug_line,0,41
.debug_abbrev,0,21
.debug_frame,0,16
.debug_macro,0,15
.debug_aranges,0,8
.debug_ranges,0,8
[Unmapped],0,6


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .eh_frame 24 24
chip-standalone-demo.out .eh_frame_hdr 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_loc,0,202
.debug_info,0,160
.debug_line,0,67
.debug_ranges,0,64
.debug_abbrev,0,58
.debug_str,0,53
.strtab,0,37
.eh_frame,24,24
.symtab,0,24
.debug_aranges,0,16
.eh_frame_hdr,8,8
[Unmapped],0,-41


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,110
.debug_str,0,53
.debug_line,0,36
.debug_frame,0,24
.debug_abbrev,0,21
.debug_aranges,0,8
.debug_ranges,0,8
[Unmapped],0,4


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@turon
Copy link
Contributor

turon commented Jul 14, 2020

@andy31415 ?

/** @brief Clears the first `len` bytes of memory area `buf`.
* @param buf Pointer to a memory buffer holding secret data that should be cleared.
* @param len Specifies secret data size in bytes.
* @return void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: @return void does not seem too useful (even doxygen would show me the signature)

@andy31415 andy31415 merged commit 6962ff3 into project-chip:master Jul 16, 2020
@yufengwangca yufengwangca deleted the pr/linux/crypto branch July 16, 2020 23:34
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
…ASH (project-chip#1564)

* SHA256 class for CHIP is merged. Replace legacy SHA256 with chip::Crypto::Hash_SHA256_stream
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
…ASH (project-chip#1564)

* SHA256 class for CHIP is merged. Replace legacy SHA256 with chip::Crypto::Hash_SHA256_stream
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
Merge in WMN_TOOLS/matter from update_wifi_sdk_3_1_3_rc5 to RC_2.3.0-1.3

Squashed commit of the following:

commit 939a05892d58d6f2ed63fc1343ba32b07ecbb018
Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
Date:   Fri Feb 9 15:37:23 2024 -0500

    Bump wifi_sdk sha to tag v3.1.3-rc5
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from update_wifi_sdk_3_1_3_rc5 to RC_2.3.0-1.3

Squashed commit of the following:

commit 939a05892d58d6f2ed63fc1343ba32b07ecbb018
Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
Date:   Fri Feb 9 15:37:23 2024 -0500

    Bump wifi_sdk sha to tag v3.1.3-rc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants